From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752377AbbJEID6 (ORCPT ); Mon, 5 Oct 2015 04:03:58 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33729 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbbJEID4 (ORCPT ); Mon, 5 Oct 2015 04:03:56 -0400 X-AuditID: cbfee68e-f791c6d000001498-a7-56122eeaf294 Date: Mon, 05 Oct 2015 08:03:54 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH v2] extcon: gpio: Add the support for Device tree bindings To: =?utf-8?Q?=EC=B5=9C=EC=B0=AC=EC=9A=B0?= , "linux-kernel@vger.kernel.org" Cc: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "devicetree@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20151005072214313@myungjoo.ham Msgkey: 20151005072214313@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20151005072214313@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <194162595.571031444032234245.JavaMail.weblogic@epmlwas07a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkRPeVnlCYwcUmGYvLu+awOTB6fN4k F8AYxWWTkpqTWZZapG+XwJUxZcdbpoIHihVftws0ML5R6GLk5BASUJdYtOQkG4gtIWAisfz0 PnYIW0ziwr31QHEuoJqljBLfFp5ihCnqndUOlZjDKDH9ylSwBIuAisSjS9NZuhg5ONgE9CRm fk4GCQsL+EnMfPSaHaReRKCNUaKl8QcjiMMssIdJ4n3rOlaIM5Qk1ux7xQJi8woISpyc+YQF YpuqxOS9u5lBhvIKqElc+ccFERaXuDD3EtSlvBIz2p9ClctJTPu6hhnClpY4P2sDI8w3i78/ horzSxy7vYMJwhaQmHrmIFSNlsS11j6oOXwSaxa+ZYGp33VqOTPMrvtb5kL1SkhsbXkCdj6z gKLElO6H7CBnMgtoSqzfpY/uE14Bd4l97RvA4SAhMJVD4vSCZqYJjEqzkNTNQjJqFsIoZCUL GFlWMYqmFiQXFCelFxnpFSfmFpfmpesl5+duYgSmhdP/nvXtYLx5wPoQowAHoxIPr0SSYJgQ a2JZcWXuIUZTYCxNZJYSTc4HJp+8knhDYzMjC1MTU2Mjc0szJXHeBKmfwUIC6YklqdmpqQWp RfFFpTmpxYcYmTg4pRoYWZdWrzPeWV4tkMO498jUbnHFYxe66+9FJB49wPdeUEfIyf/q9YQt B42mvMjy2cQj6xipuMI43/vHxRX9Ub4HNQxCxba3bMl98sxv/cmIyZMOxJ1wzHHx5XUUjvjy 8NMy4bRHjJx6SjdFdny2PvqqI+H1yyWTe2+w5N80KuWRV44239TWfmmvEktxRqKhFnNRcSIA NOV++QYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tPt1XekJhBtuni1pc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q+NYK0MDAyNToJqEtIwp O94yFTxQrPi6XaCB8Y1CFyMnh5CAusSiJSfZQGwJAROJ3lntULaYxIV764FsLqCaOYwS069M ZQRJsAioSDy6NJ2li5GDg01AT2Lm52SQsLCAn8TMR6/ZQepFBNoYJVoafzCCOMwCe5gk3reu Y4XYpiSxZt8rFhCbV0BQ4uTMJywQ21QlJu/dzQwylFdATeLKPy6IsLjEhbmX2CFsXokZ7U+h yuUkpn1dwwxhS0ucn7WBEeboxd8fQ8X5JY7d3sEEYQtITD1zEKpGS+Jaax/UHD6JNQvfssDU 7zq1nBlm1/0tc6F6JSS2tjwBO59ZQFFiSvdDdpAzmQU0Jdbv0kf3Ca+Au8S+9g3sExhlZyFJ zULSPQuhG1nJAkaWVYyiqQXJBcVJ6RUmesWJucWleel6yfm5mxjBKejZkh2MDResDzEKcDAq 8fAeiBcME2JNLCuuzD3EKMHBrCTCq60lFCbEm5JYWZValB9fVJqTWnyI0RQYZxOZpUST84Hp Ma8k3tDY2MTMxNTSxMLA1FxJnPfmXoYwIYH0xJLU7NTUgtQimD4mDk6pBsZtAZxNcoJ/ms8a PFqyz5d9atmzmxu2JU+vq2joibkftfGrxmWLFLlVip966jl9jS5/D7w3eybLDx1xzZwotQc+ BfvF3q6zT3a8U5/6/vXcCfKO9coBIlKZbsbn2fZO2nl3fb64kpGDxrlXirbtcefiP9+fb6/f cyXY96Z4vPE1Rc0ZsziLuJVYijMSDbWYi4oTAT+SX3VXAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9584593005341 > > This patch adds the support for Device tree bindings of extcon-gpio driver. > The extcon-gpio device tree node must include the both 'extcon-id' and > 'extcon-gpio' property. > [] > > Signed-off-by: Chanwoo Choi Except for some beautification issues described below, Signed-off-by: MyungJoo Ham > --- > This patch is based on following patch[1]. > [1] https://lkml.org/lkml/2015/10/3/304 > > Changes from v1: > - Create the include/dt-bindings/extcon/extcon.h including the identification > of external connector. These definitions are used in dts file. > - Fix error if CONFIG_OF is disabled. > > .../devicetree/bindings/extcon/extcon-gpio.txt | 38 +++++++ > drivers/extcon/extcon-gpio.c | 110 ++++++++++++++++----- > include/dt-bindings/extcon/extcon.h | 44 +++++++++ > include/linux/extcon/extcon-gpio.h | 6 +- > 4 files changed, 173 insertions(+), 25 deletions(-) > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-gpio.txt > create mode 100644 include/dt-bindings/extcon/extcon.h > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt > new file mode 100644 > index 000000000000..70c36f729963 > --- /dev/null > +++ b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt [] > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index 279ff8f6637d..7f3e24aae0c4 100644 > --- a/drivers/extcon/extcon-gpio.c > +++ b/drivers/extcon/extcon-gpio.c > @@ -1,8 +1,8 @@ > /* > * extcon_gpio.c - Single-state GPIO extcon driver based on extcon class > * > - * Copyright (C) 2008 Google, Inc. > - * Author: Mike Lockwood > + * Copyright (C) 2015 Chanwoo Choi , Samsung Electronics > + * Copyright (C) 2008 Mike Lockwood , Google, Inc. > * > * Modified by MyungJoo Ham to support extcon > * (originally switch class is supported) Let's make it in chronological order. (may need to "beautify the last two lines as well) I.e., 2008-->2012-->2015 or 2015-->2012-->2008. Not 2015-->2008-->2012 > @@ -26,12 +26,14 @@ [] > diff --git a/include/dt-bindings/extcon/extcon.h b/include/dt-bindings/extcon/extcon.h > new file mode 100644 > index 000000000000..14c7f36b2206 > --- /dev/null > +++ b/include/dt-bindings/extcon/extcon.h [] > diff --git a/include/linux/extcon/extcon-gpio.h b/include/linux/extcon/extcon-gpio.h > index 7cacafb78b09..bcc6d7f7116a 100644 > --- a/include/linux/extcon/extcon-gpio.h > +++ b/include/linux/extcon/extcon-gpio.h [] > @@ -38,7 +38,7 @@ struct gpio_extcon_pdata { > unsigned int extcon_id; > unsigned gpio; > bool gpio_active_low; > - unsigned long debounce; > + unsigned int debounce; What about u32, making it more clear? ( > + device_property_read_u32(dev, "debounce-ms", &pdata->debounce); ) > unsigned long irq_flags; > > bool check_on_resume; > -- > 1.8.0 {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I