mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Juha-Matti Tilli" <juha-matti.tilli@iki.fi>
To: "Marcel Holtmann" <marcel@holtmann.org>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
	"Deepak Kumar Singh" <deepak.singh@oss.qualcomm.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Jeff Johnson" <jjohnson@kernel.org>,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	ath11k@lists.infradead.org, ath12k@lists.infradead.org,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Chris Lew" <christopher.lew@oss.qualcomm.com>,
	"Raj Kumar Bhagat" <raj.bhagat@oss.qualcomm.com>,
	"Jeff Hugo" <jeff.hugo@oss.qualcomm.com>
Subject: Re: [PATCH v3 2/4] net: qrtr: Assign unique node id for MHI endpoints
Date: Thu, 01 Oct 2026 17:20:27 +0300	[thread overview]
Message-ID: <19433f85-4cf1-4ec1-a26f-0eab7df062df@app.fastmail.com> (raw)
In-Reply-To: <0A4EB216-06E0-4A7D-A0FD-821DD371773B@holtmann.org>

On Wed, Sep 30, 2026, at 17:33, Marcel Holtmann wrote:
> > Well, in defense of Manivannan's patchset it currently works for PCI+AHB
> > setups better than the last version of that by Denis/Mihai/me (although 
> > I could easily fix that), and it may be simpler for userspace to
> > continue using nid than having to bind to an endpoint, which requires
> > more changes in userspace code.
> > 
> > The userspace just needs to know the nid.
> 
> and existing userspace? You can _NOT_ break existing userspace.
> 
> Don’t you need to re-write all existing QRTRIPC packets to actually even make this work?

Well, from what I understand this rewriting is the plan.

It is true that if someone has a single card, the nid changes, thus
maybe breaking userspace if the userspace has hardcoded nid.

But if someone has multiple cards, the breakage to userspace is less
with this patch, since userspace can keep on using the same code and
just change the nid, whereas with the endpoint_id patch, the userspace
needs code changes to bind to an endpoint.

BR, Juha-Matti

  reply	other threads:[~2026-10-01 14:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 13:41 [PATCH v3 0/4] net: qrtr: Add support for using identical MHI endpoint devices Manivannan Sadhasivam via B4 Relay
2026-09-22 13:41 ` [PATCH v3 1/4] net: qrtr: Allow the host QRTR to assign a unique node id Manivannan Sadhasivam via B4 Relay
2026-09-25  7:43   ` netdev-bot+sashiko
2026-09-22 13:41 ` [PATCH v3 2/4] net: qrtr: Assign unique node id for MHI endpoints Manivannan Sadhasivam via B4 Relay
2026-09-25  7:43   ` netdev-bot+sashiko
2026-09-29 16:45   ` Deepak Kumar Singh
2026-09-29 17:05     ` Marcel Holtmann
2026-09-29 17:16       ` Juha-Matti Tilli
2026-09-29 17:19         ` Robert Marko
2026-09-29 19:34         ` Manivannan Sadhasivam
2026-09-29 20:37           ` Marcel Holtmann
2026-09-30  5:54             ` Juha-Matti Tilli
2026-09-30 14:33               ` Marcel Holtmann
2026-10-01 14:20                 ` Juha-Matti Tilli [this message]
2026-10-01 15:39                   ` Marcel Holtmann
2026-10-01 20:05                     ` Manivannan Sadhasivam
2026-09-29 19:32       ` Manivannan Sadhasivam
2026-09-29 19:28     ` Manivannan Sadhasivam
2026-09-22 13:41 ` [PATCH v3 3/4] wifi: ath11k: Connect to the QMI server belonging to the device owned by this driver Manivannan Sadhasivam via B4 Relay
2026-09-25  7:43   ` netdev-bot+sashiko
2026-09-22 13:41 ` [PATCH v3 4/4] wifi: ath12k: " Manivannan Sadhasivam via B4 Relay
2026-09-22 15:52   ` Raj Kumar Bhagat
2026-09-23  6:42   ` Juha-Matti Tilli
2026-09-25  7:43   ` netdev-bot+sashiko
2026-09-29  8:59 ` [PATCH v3 0/4] net: qrtr: Add support for using identical MHI endpoint devices Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19433f85-4cf1-4ec1-a26f-0eab7df062df@app.fastmail.com \
    --to=juha-matti.tilli@iki.fi \
    --cc=andersson@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=christopher.lew@oss.qualcomm.com \
    --cc=davem@davemloft.net \
    --cc=deepak.singh@oss.qualcomm.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=raj.bhagat@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®