From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754619AbdHZNBE (ORCPT ); Sat, 26 Aug 2017 09:01:04 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:47498 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbdHZNBC (ORCPT ); Sat, 26 Aug 2017 09:01:02 -0400 From: "Rafael J. Wysocki" To: Takashi Iwai Cc: Andy Shevchenko , Lee Jones , Darren Hart , Andy Shevchenko , Mika Westerberg , Johannes Stezenbach , Hans de Goede , Platform Driver , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC Date: Sat, 26 Aug 2017 14:52:24 +0200 Message-ID: <1951917.lb8WZjqdIa@aspire.rjw.lan> In-Reply-To: References: <20170825134443.14843-1-tiwai@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, August 25, 2017 5:38:11 PM CEST Takashi Iwai wrote: > On Fri, 25 Aug 2017 17:24:19 +0200, > Andy Shevchenko wrote: > > > > On Fri, Aug 25, 2017 at 4:44 PM, Takashi Iwai wrote: > > > > One really minor nit (fine if it will be ignored): > > > > > +config CHTDC_TI_PMIC_OPREGION > > > > CHTDC_TI_PMIC_OPREGION -> CHT_DC_TI_PMIC_OPREGION > > Ah, the world is inconsistent... > > > > obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o > > > obj-$(CONFIG_BXT_WC_PMIC_OPREGION) += pmic/intel_pmic_bxtwc.o > > > obj-$(CONFIG_CHT_WC_PMIC_OPREGION) += pmic/intel_pmic_chtwc.o > > > +obj-$(CONFIG_CHTDC_TI_PMIC_OPREGION) += pmic/intel_pmic_chtdc_ti.o > > > > Ditto (as you can notice by above context). > > ... where the file name is combined. > > I really don't mind, too. > > Rafael, please let me know if you want a resubmission with this > correction. Yes, please (but just this one patch should be sufficient). Thanks, Rafael