From: Oliver Neukum <oneukum@suse.de>
To: Constantine Shulyupin <const@makelinux.com>
Cc: nsekhar@ti.com, gregkh@linuxfoundation.org,
davinci-linux-open-source@linux.davincidsp.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open
Date: Wed, 10 Oct 2012 14:35:36 +0200 [thread overview]
Message-ID: <1952553.sIPjpLauNn@linux-lqwf.site> (raw)
In-Reply-To: <1349865174-21649-1-git-send-email-const@MakeLinux.com>
On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote:
> From: Constantine Shulyupin <const@MakeLinux.com>
>
> Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.
>
> Some last changes in function skel_open and finally commit
> 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
> introduced a bug in function skel_open, which this patch fixes.
>
> --
> Changelog:
> -- Fixed accordinly feedback of Oliver Neukum oneukum@suse.de: also need to drop the lock.
Well, touching file->private_data is not nice. It is correct, but
really dirty. The skeleton driver should be nice. Could you introduce
a second label for goto at the right place?
Regards
Oliver
prev parent reply other threads:[~2012-10-10 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 10:32 Constantine Shulyupin
2012-10-10 12:35 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1952553.sIPjpLauNn@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=balbi@ti.com \
--cc=const@makelinux.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®