From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117AbbLDO2t (ORCPT ); Fri, 4 Dec 2015 09:28:49 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:57115 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbbLDO2r (ORCPT ); Fri, 4 Dec 2015 09:28:47 -0500 From: Arnd Bergmann To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , MPT-FusionLinux.pdl@avagotech.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Peter Zijlstra , Christoph Hellwig , linux-arm-kernel@lists.infradead.org Subject: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS Date: Fri, 04 Dec 2015 15:27:40 +0100 Message-ID: <1953916.xaj9Y2FReq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:cQ+WVsYDK9vRQTNoVYrk1x/vicxH1J11BdztBaXA9wt2d7mTLp8 EjOzh0LRF3BtuNscCfci8oh19NW1eMkOnYEhMy1ZQI9da4TGPjPeAq7r/MPpbfyd3VwHCEt VZgsDSGCBny9ALyRQ/8xAt9bBz91mhOmudQYx2N7fTcTFi8JZ3Xylq3pqW4h9SolFk2CT3s JOTTiMvZucV+gTgijjJvg== X-UI-Out-Filterresults: notjunk:1;V01:K0:+xuBrY32YhI=:1Jk/9terMVbmCMXFpBAhnO E6NaHSihcW7XxsI5TB1j1WqYSH1e7Zc6j7MTOvjwJC3HoKAr1PVzl8gCXaTMFygE8pJT3y7d1 C9XdUUuGrGh+2yyD6lAeEHKxdXbnQSMAi9wFAjqItkzMI3LXkdUcfV6Fw77XLmbihViSaQifX 0eK9TsRd4uciP6SozvNuuCOnY56x4mKubU0A2s76D0ahwzmhiQLVJuxBp1aimQiY5B1UUdhtI BSNsYTa1mVycDQKXjzJvZOMAQMt6e4hugs/cxqQgk9s9koCPa2LNUP72INHl7xYyvtK0pH/ra XOdE7S7bK1PEYsuupVi/M4MgQJ28JyNyFw2NSgmNBvBZz23Fu6WFapnvMhwGnhF7RjW19GE4w +sO1k6yJ2gydHEpBbaw+egZotVMPyWeQin+VJP0jGj78SXct2haGV8M310va9k1yUGERxzYca d2u8lVoIEoAkixAkKq14I3+X24nhaf95sE35UTKDm8o+BnqDmKZnyuZ/NHwrnN0xdTQjjNQ/Z yCMHqrj+Z48y2RPoLi737YvCGL+f9uIf5Y3Atmx1YhWjgCLENEfLj7Nweiw1XwvIcm7oOMFTv QmW/wF7Dy06wK4KrrBm/kvoXYrAeVkT4asklVvlYPbezOnlMr3+cHL6LQ4Wr5Odo7gZZ1P3UF ueJ2AgiCpojg4EQYyy6hMjg7+mDsiteZoTyxnWQ07/TrRgAHHcaWw3ljFTs3NBVhI2oilD22Z hXu1450HoFfFoLhi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies: warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && PCI && SCSI) 0x7E5F9A79 Fri Dec 4 12:36:08 CET 2015 failed drivers/scsi/mpt3sas/mpt3sas_base.c: In function 'mpt3sas_remove_dead_ioc_func': drivers/scsi/mpt3sas/mpt3sas_base.c:140:2: error: implicit declaration of function 'pci_stop_and_remove_bus_device_locked' [-Werror=implicit-function-declaration] drivers/scsi/mpt3sas/mpt3sas_base.c: In function '_base_disable_msix': drivers/scsi/mpt3sas/mpt3sas_base.c:1921:2: error: implicit declaration of function 'pci_disable_msix' [-Werror=implicit-function-declaration] This adds the same dependencies that SCSI_MPT3SAS has. Signed-off-by: Arnd Bergmann Fixes: b840c3627b6f ("mpt3sas: Add dummy Kconfig option for backwards compatibility") --- This appeared on today's linux-next with ARM randconfig builds diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig index 25dc38f25ec6..33dc427cfe9a 100644 --- a/drivers/scsi/mpt3sas/Kconfig +++ b/drivers/scsi/mpt3sas/Kconfig @@ -74,6 +74,7 @@ config SCSI_MPT3SAS_MAX_SGE config SCSI_MPT2SAS tristate "Legacy MPT2SAS config option" + depends on PCI && SCSI default n select SCSI_MPT3SAS ---help---