From: Deepak R Varma <drv@mailo.com>
To: Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Cc: Ira Weiny <ira.weiny@intel.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Sumitra Sharma <sumitraartsy@gmail.com>,
Deepak R Varma <drv@mailo.com>
Subject: [PATCH v3 1/6] gfs2: Replace kmap_atomic() by kmap_local_page() in stuffed_readpage
Date: Fri, 30 Jun 2023 03:19:29 +0530 [thread overview]
Message-ID: <1955d9c440240f4c97efd80f3efca550871fe0ef.1688073459.git.drv@mailo.com> (raw)
In-Reply-To: <cover.1688073459.git.drv@mailo.com>
kmap_atomic() is deprecated in favor of kmap_local_{folio,page}().
Therefore, replace kmap_atomic() with kmap_local_page() in
stuffed_readpage().
kmap_atomic() disables page-faults and preemption (the latter only for
!PREEMPT_RT kernels), However, the code within the mapping/un-mapping in
stuffed_readpage() does not depend on the above-mentioned side effects.
Therefore, a mere replacement of the old API with the new one is all that
is required (i.e., there is no need to explicitly add any calls to
pagefault_disable() and/or preempt_disable()).
Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
Changes in v3:
- split into 2 patches
- included in the patch set. Was sent as standalone patch previously
Changes in v2:
- Update patch description to correct the replacement function name from
kmap_local_page to kmap_local_folio
fs/gfs2/aops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 3b41542d6697..3eac4f2f5c27 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -432,10 +432,10 @@ static int stuffed_readpage(struct gfs2_inode *ip, struct page *page)
if (error)
return error;
- kaddr = kmap_atomic(page);
+ kaddr = kmap_local_page(page);
memcpy(kaddr, dibh->b_data + sizeof(struct gfs2_dinode), dsize);
memset(kaddr + dsize, 0, PAGE_SIZE - dsize);
- kunmap_atomic(kaddr);
+ kunmap_local(kaddr);
flush_dcache_page(page);
brelse(dibh);
SetPageUptodate(page);
--
2.34.1
next prev parent reply other threads:[~2023-06-29 21:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 21:48 [PATCH v3 0/6] gfs2: kmap{_atomic} conversion to kmap_local_{page/folio} Deepak R Varma
2023-06-29 21:49 ` Deepak R Varma [this message]
2023-07-01 11:02 ` [PATCH v3 1/6] gfs2: Replace kmap_atomic() by kmap_local_page() in stuffed_readpage Fabio M. De Francesco
2023-06-29 21:50 ` [PATCH v3 2/6] gfs2: Replace kmap_atomic()+memcpy by memcpy_from_page() Deepak R Varma
2023-07-01 11:17 ` Fabio M. De Francesco
2023-06-29 21:50 ` [PATCH v3 3/6] gfs2: Replace kmap() by kmap_local_page() in gfs2_unstuffer_page Deepak R Varma
2023-07-01 13:01 ` Fabio M. De Francesco
2023-06-29 21:51 ` [PATCH v3 4/6] gfs2: Replace kmap_atomic() by kmap_local_page() in lops.c Deepak R Varma
2023-07-01 13:16 ` Fabio M. De Francesco
2023-06-29 21:51 ` [PATCH v3 5/6] gfs2: Replace kmap() by kmap_local_page() in gfs2_read_super Deepak R Varma
2023-07-01 13:45 ` Fabio M. De Francesco
2023-06-29 21:52 ` [PATCH v3 6/6] gfs2: Replace kmap_atomic() by kmap_local_page() in gfs2_write_buf_to_page Deepak R Varma
2023-07-01 13:54 ` Fabio M. De Francesco
2023-08-10 15:28 ` Deepak R Varma
2023-07-03 9:17 ` [PATCH v3 0/6] gfs2: kmap{_atomic} conversion to kmap_local_{page/folio} Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1955d9c440240f4c97efd80f3efca550871fe0ef.1688073459.git.drv@mailo.com \
--to=drv@mailo.com \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=sumitraartsy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®