From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f100.google.com (mail-pj1-f100.google.com [209.85.216.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C84E039769E for ; Thu, 20 Aug 2026 18:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787251354; cv=none; b=AQMwvN83IQ4a2v8k6EjRfvhyX4ISodShiM10JM3x1/2ru7MTCDOAmi8d8C9d06+iy6O4V+A+n3SUC29cdB4VuraLWRjQQPbfh1eA7ueTHsa6zewQ7MQa1f4Uz31AnXP2e0LsLbTCKMaJ477NpO2i/TVjoaaNvX1j4n4B2a1Nh5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787251354; c=relaxed/simple; bh=SYX+JlrGNTDEXjKAoWcQL6ELgpKDbWRqmiR8KoABcNw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kjvlV92Cw7BRBDH390/hnA2+p8dIEoiSba7bVxScPAI8qFYs0Wbcg7VI+SEcSNT4iVXkB6eOiFUUshbgMKQQ2fgRwDhmNVres0APif8WbZ+GT/9glbPTbSdiTgjBQjajmj5geO51KeIH3gx1fAJMap0f0QCEyFQO4vSQiVMuR9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=EFoC2iyL; arc=none smtp.client-ip=209.85.216.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="EFoC2iyL" Received: by mail-pj1-f100.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so144596a91.0 for ; Thu, 20 Aug 2026 11:42:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787251352; x=1787856152; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=fEKZKwe8xin78Zky0TWTYOaM5koa7MSpaMH+Oal8e4c=; b=RnOBo5bHayuKbSnhagOEtPK7EnJeU5Ytxj4AY4bY2TWEIKOn7ueeI86Tzzm/5IlirL ui6QmHbdx50oYXnO0/5kIDE61NUqCV4LTbCC+CQ9IHd8MBnkFE9CR1xKQPWLcUGrbE1F HRVVwNK/lBo6IKCC7jHq3MHzeA73P45qrSnsJANO+rNqk/7KAtWlQn+essYwYKbk9OOA 7cKceMoEYnfPD+9kjj5wATQ1dqAMnLLWy84S1yQYgHmFUa8YeALhtuTD0AnprQDgxlhF eBwhLDCNziYx8rdgW6OGwKdeGlwWcDPI0HXRaJMOWOf5CVdXxl3f+oQll+zQQCLuWX0/ nm+A== X-Forwarded-Encrypted: i=1; AHgh+RqvBUBkpQFAyW+XYcUfRrbHZDaTYwLUanEk8V+zM9gQgMgOBcXdfiz3ym53VnIk4e7fRGr7L0GKUmOomaE=@vger.kernel.org X-Gm-Message-State: AFuF++m3pM1fue4Ax38XoYoes1DSSQwxLTjL9EZw0ho/3drrOsXBAmJb SZwN9BfyhmjubSc7kRgGRRTbKf5FtiFpTqpk2dQE3HlB1NSXwhZirRe+Fd0+GkGWDhY3WmLd2Xn T0uHNq3iYlJcdcS7cJkCcHZJ8WkfeBbtoavUMrWMYtQGyXrGwAULpdv00dI5n3G6IsUo/vFpGS5 m210ewzpqKJOvHrytUDWUPkYELZQ2f0APlx0U8kxp3Wy5XAx97y2hLqvrU71k8Lj6bOelI0/ItX U41ceb4b9UYZDjGUg== X-Gm-Gg: AR+sD11o60uWKthCEbh2KlbfK7Q7+WVVUh02NJNJhbrhxa6FGfPfGG+oJbHS8NIAzK9 UQuiXI2JOn/LTVecqFy8j7VdvfBLMPY6ZRplsgJ5tTOjRLn74AX4czdy2/n92BtHq2zD5k5eeRW xTt7/ga5WL3SlAf1PhfArrgDl/CVxUpWCeRqJVGauUHna3O/zXkrmDfVu/w4d7mzTCDJYDFNC6G S5INVJgP4AnWC8cb75fpEJH8Ywi404cGruxJB0LbhaHT+x2FXeDde5qw+iqz/UO6U6C8UJODvKt dCgTJE5cdIFYSFSBSeMm9lWeSbWnKRcddEAEoAhCcL5OKqNGN8qgETL6m6LVuffRTCvEroyeXxd 23jM17+n9DM4tj1PrAAPMSjVwbLoRLj2X3NgQ5hXqbrPyZpyDkUNFLh+MBOUvYdoB21Ca3uLWxV HZVic/FKnVLSFuZhR/XahPurv06OqDXmt9tA== X-Received: by 2002:a17:90b:33c4:b0:395:4de4:92be with SMTP id 98e67ed59e1d1-395c3552287mr914099a91.13.1787251351862; Thu, 20 Aug 2026 11:42:31 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-16.dlp.protect.broadcom.com. [144.49.247.16]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-395c4577762sm8630a91.2.2026.08.20.11.42.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Aug 2026 11:42:31 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-90a91f4c6f1so1753526d6.3 for ; Thu, 20 Aug 2026 11:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1787251350; x=1787856150; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fEKZKwe8xin78Zky0TWTYOaM5koa7MSpaMH+Oal8e4c=; b=EFoC2iyLRY7Bk+U7ReY85lzmeomUvwoHMvQyrFNL30fy1lIx3OYvUIVIH3OGhvZs4n /mMbn8ql7H/+danzRE+GtcTDOHu1DVRdXXiFV9nk3DowLxH8ppCNIZAm5VEQofovwVKn bKJFsnXf8ysU0RmDn2eAqXOnKxfld0YIkQKgU= X-Forwarded-Encrypted: i=1; AHgh+RqyUGHC7CL2yYgffrewEBcmK6FtqK2pg17BkpiX+tEb2onXfgYqVJzDiUgXi6xvT5L4Odk4czkQAxgruvA=@vger.kernel.org X-Received: by 2002:a05:6214:124d:b0:8ee:5e59:7b04 with SMTP id 6a1803df08f44-90c80e00b57mr2004826d6.18.1787251350424; Thu, 20 Aug 2026 11:42:30 -0700 (PDT) X-Received: by 2002:a05:6214:124d:b0:8ee:5e59:7b04 with SMTP id 6a1803df08f44-90c80e00b57mr2003896d6.18.1787251349742; Thu, 20 Aug 2026 11:42:29 -0700 (PDT) Received: from [10.69.70.219] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c5f2906afsm44099346d6.25.2026.08.20.11.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 11:42:29 -0700 (PDT) Message-ID: <1958a140-a3ff-4f0c-8982-9695d1dbd8a1@broadcom.com> Date: Thu, 20 Aug 2026 11:42:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] net: broadcom: Improve IRQ error handling To: Florian Fainelli , Paolo Abeni , phucduc.bui@gmail.com, Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260820111456.97947-1-phucduc.bui@gmail.com> Content-Language: en-US From: Justin Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 8/20/26 9:45 AM, Florian Fainelli wrote: > On 8/20/26 06:30, Paolo Abeni wrote: >> On 8/20/26 1:14 PM, phucduc.bui@gmail.com wrote: >>> From: bui duc phuc >>> >>> Hi all, >>> >>> This series improves IRQ error handling in several Broadcom Ethernet >>> drivers by propagating IRQ lookup and request errors instead of >>> silently ignoring them. >>> >>> The changes were found by manual code inspection and compile-tested >>> only. >> ## Form letter - net-next-closed >> >> We have already submitted our pull request with net-next material for >> v7.3, >> and therefore net-next is closed for new drivers, features, code >> refactoring >> and optimizations. We are currently accepting bug fixes only. >> >> Please repost when net-next reopens after Aug 31st. >> >> RFC patches sent for review only are obviously welcome at any time. >> >> See: https://www.kernel.org/doc/html/next/process/maintainer- >> netdev.html#development-cycle >> > > Not seeing much value in these patches, to be honest. Agreed. I prefer the current behavior. Even if the optional WoL IRQ exist, but fails to initialize correctly, the rest of the network functions will still work. No need to take down everything in this case. Thanks, Justin