From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754522AbdEIPpw (ORCPT ); Tue, 9 May 2017 11:45:52 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:47021 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754054AbdEIPpt (ORCPT ); Tue, 9 May 2017 11:45:49 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: get/put_cpu() usage in block/blk-mq.c To: Mike Galbraith References: <1494310029.20252.44.camel@gmx.de> <1494342256.4440.3.camel@gmx.de> <842b9fc5-5a8e-d147-0b14-3c9f9540336d@fb.com> <1494344459.4440.17.camel@gmx.de> CC: LKML From: Jens Axboe Message-ID: <19592821-f779-176e-ecb5-a98e846824d6@fb.com> Date: Tue, 9 May 2017 09:45:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494344459.4440.17.camel@gmx.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CY4PR21CA0047.namprd21.prod.outlook.com (10.175.113.161) To CY4PR15MB1189.namprd15.prod.outlook.com (10.172.177.11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3e17b13c-ce91-4e26-4834-08d496f273c1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;3:03gjpWVpRxM3AI8dez9O/jReXpvWZKZh+o9EWUKvIXY6HYu8mUnVC1otwuwXWqv5CWBa2fGevfIxHHqxHAD1fIQSNT2xxe4TpDoZiLSUVaiNmdVuHam5y5UUmMI337aXh4XWP5JW0Xkx+t8Mtj8ZLIcTWUJ9MihkFjzejPeKRuZ6jpSkiEgiZse2oANhPslLEeuDtyzCE7ZGPZoTmWPPW80S3MCmfmv0Y+ZB4qPmyTL9jtuA6l9qbp3FO0uwCMGt3aDY+Tl7qyB6dzWl2GRz0DHbZsorAO4CwQJXrS0s78IA9Tdt1VpRMMTFBIeOB7WApwUQX+6yqA0r4cp9xIbOWA==;25:kd6+VPW3EmzKoSHJJdx37/hlTo0IBbi0rkiwyPtBy7jeq4hpToWkxQaPvcM89jpHJm+12SnRxTy1jLuhprm6mrG7prKSaxUSNveJYThtvJy5zT2L1rILUyuy39+daTNhyDao5p/6EX4UJH0o0bMPGmWjeNzoV67Cq333kIwIRL2RikWNMjxfxlR6KSrfJN29ezCHYRIHIu/p3L8/ZLhM2P4nKhUkLOcNZ+V/MeB2Dv7lV0lGAYlGl6CCnKJxAgVjPsy5ULM6xC8I1fz8d+MiDBT07DX+AlRnT//QbchZMgDVgJDC1bOtT6UCkYC97dLmB0+0wINoWBt9xVgmej1KTUw80gro1CRFFAM1BGDjF80qTjDoQqvmmrLV7tHIQpkhnAskZfCprT15esQB1GlVQZP9ERy5T1ySRvuDu6dDXRfr1IGWhvI+GHUFNNPF1hB77cUwauAHXKQJUvovz82N8uywmRWfHL5We7x60dWrqTo= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;31:jCF1ZYxrtw8YkrZGg+f2/O75K5cxOHOd7qJ4o7sfTkqJzlloGPnih5vU1wUn3UfmwwReies92aq1o+RTTKiZC1q++vbWGNJujzlo9TaiMgKtut4O4fqBAmsBM06I8LHjmCVnfkDFlBDQBFCT0ke9WlK30GvZtunplK2irL5880DI3K7hGSh706hb4FhxEE7oLA9MEkzlsN6jV/+HR5XyGIujyY4V4f5989Y8wVGy4QZ6AMgVBrGGGS9SwHQad0GqDUZCrBZ2EzahG6JA5AOo4A==;20:1db6Ljwi47UqVR3TRHa9+qzQ07sbx/Noqms/4EL+RhU2Fq1xhE961sGopivMMANmKI92ylni9FejR/dsfqTqcVgqDZJJF9oYUVzsEA9oHEHw466RyObugIo2f25em/qBciAPa/hKZvJC0BVKdMi45uFJUxZ8wTeAd4hC6JDc0KXHhMGd60TdPNSSwfE/NLGhI5xkDgiM51kZ3fevXTnWc2rinm3y8uP3ziPgpdL36/efypxjejLrwTNZMr62jm+CuG/e9HS93GFnnFMquHs9i7qBqlYKEZUDkVRm/051q7PBTmxuB6/iJzR8B+pwNlmEThWvGlvRrMSZTQKkymWglo6g3vJtWoeEv4jjX2oaen28fOwZbgs4ztrCVtQ1H1hXBeviYQMwYHVl1MS/oRWCebKbluKBG83ft3DhteJumJc2hcyL1z6JXp9d4UZQTAZ7xtsM8bRfZPJa5W5QP55xY9gTfLIdjbN9vFozq/2w8NM0EclbNZFEds3r58Kb0c/p X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(6072148);SRVR:CY4PR15MB1189;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;4:bOuz5fgIER0ptwCddkQip1EunVCmZNgI2Tzh7UTAkPwj7aM/ZtFEjw9y0AL+ClzfbklCwVg2CsEFof5llUlia7rGCvTLoqDuBFwH1gU1A91dhct6jAt0D3LG114J8hBTqtW1hGBedfDe4PoD7xmZa2BkiXVOAJQyJFd3I2HcoMLQsJe5tpiOT61e2f2kPGjZ07EXxUZhwN0pQkjVmiFlvwfSqlHwleDtfhSylYxWQWBPL6Jfo9T8YhKdguX6lqIQtjoWd+A3qwIJIcPoWvsakkfxv+vaffTBr9mVG3k6Pwm2A++41xuBsS8G4cIy3clgnm6m8+hAHgIGNvhajluhbYK+tY0arSu07neqb72qOdo9zdAa+bIQHE+TNvBfBUjyXLmwZj7dWB/4QaGwpI/gFjlB7LEmvjZz+UQSY45kbQiM4HQpRhNFpmXYY0oT5sSzpjvrwo5RpSR7jc61FepyEetcbnowQ3shNWtrMWoBvwLthpunI7PdInfaHKzhB0dwCEY5n49WsxYNoZVDcgX1C2ZBRarmvDDeu454jJuKy6v8+9INXS0/ENKRtP+RHgfG4rNoqGYyz5VTgzqAFqXB1ETgMlWyM0cY4mBolKv7NFQX69g33FKLT5Oh31sltgqpGAD07CigZo0lJ5bsehCe1Gf056vZzCAjbVSAbhxL4aGt6s27AodwO3XSY6ylhFXpp+mFmDOuwFYpj1xODUQyewMb/MOqCaVglEatziU/SFzgcsSInBkR5QEPGpBTO0az1I2SvtvdQ7F3UNYPJwqNlqBQrn1okGhvaSwKsV1rZZM= X-Forefront-PRVS: 0302D4F392 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39410400002)(39400400002)(39850400002)(39840400002)(39450400003)(377454003)(24454002)(52314003)(377424004)(77096006)(6486002)(47776003)(4001350100001)(189998001)(66066001)(230700001)(117156002)(53546009)(83506001)(31696002)(42186005)(25786009)(4326008)(8676002)(81166006)(86362001)(8666007)(36756003)(229853002)(6246003)(90366009)(5660300001)(50986999)(478600001)(93886004)(65956001)(50466002)(110136004)(38730400002)(305945005)(23676002)(2906002)(54356999)(76176999)(6916009)(53936002)(7736002)(2950100002)(33646002)(3846002)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1189;H:[192.168.1.160];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjE1TUIxMTg5OzIzOkkrUm5CcXZCVGx2SGlKcjVkZkhVREFhM3Fw?= =?utf-8?B?czdtN1EvOGFBOCtnUmwyQ2I1alExZFVNenUrUFIxU1lpbllPOWlFZWx6WlpD?= =?utf-8?B?am1pZXFKU1N2bDhmSzlFeXN5QVY4Q0UrbzJuMXlFOUtYUndLTHZ4MWVxamVC?= =?utf-8?B?eE54cXpqQmRlY3BMRk9meUNhSGRoMlRjU0tmSzBQWi8rWEFZZU5xS0pFcFZG?= =?utf-8?B?VEVZaDBRaUJ3OEFuN2s5ZmlwRGVwdDJKRkpleFpjZWxicmRMRkU1RGpMQkwz?= =?utf-8?B?RjhXcXJzZ2wrZGlDZGZ6WHpBRTdkMGtOdVVmWXRTMVhCSDA2V2d1amdwVy9h?= =?utf-8?B?OEFjMTNhR3hMSFMzQkRjRUlXSGI0aXkrL2ZSaEZ4ZnZ5ZStQZVBBRHFtNWxM?= =?utf-8?B?Q2VkK3liQjFGUmxLakJWYllEZ1EvR1NlUjlSTFhSdGphSkVQcy9NZ0owTlhv?= =?utf-8?B?elA2QjQ5dTc3aEVKaVE3SkpFU0dTRDI1dTU4K3FvYlk3T0pBRk1yaUZnVlND?= =?utf-8?B?eGlPa0h6S0F4VXUvM3EwaTUzTUh6WlFzKzZNVXJnVDNFSlVycys5RURxZ3lN?= =?utf-8?B?eWd4L0cyNytPRThtMCtET3lZOFJYUTRLSlJFb1czNkhhQ2dqcE5vZmREai96?= =?utf-8?B?L0svWGo5czlyVktRbUVsTUNaOTNFWHlPYkFScll2NmxJbHZNNlhJREhFb0VE?= =?utf-8?B?U2Y1bDB3aGU1b0ROVjB4dTVhcDlacFNFNUs4cHJoV0Y5ODFyVjdMWnB1T0dl?= =?utf-8?B?MFh4Q3NNNTNsL1RtQ1NvTEMvUk0xSVlnUWJxV3dncjZGZTd5YWxxNFdnUitl?= =?utf-8?B?cno3UTBCL3JQTjdmWWNZQWdEVVlacko4dGJKVXU3V2JaeHdXREJxWGlDS25v?= =?utf-8?B?VWg1T1BXRlVPVmNQNG9pNEw1WXIvNFhWSnRueGJjRDUrMzVIbzJxUTY5emRM?= =?utf-8?B?dC9qaG1sQTNvYmNlZW5LT3lIZjdUM2FyTVFWZmsrOFRKakQvaUcvdG1pWFlu?= =?utf-8?B?SWZRRUlWd1ZZV3lZRFFLSWZMQlplRVk3MXB2a25Dc2NLNUVBTHlsZ1FGYjJ5?= =?utf-8?B?S1lnS2E1THdRQUtmNk50VE41RTBDRDZWOEJsSHlPM1YvamlPREVGQW96Tlhx?= =?utf-8?B?YkJJbThFczBVTWRVVEVzQXFwUnZGSmpTNUpEN200ZEFqUzUyTy8ra3QyRlNR?= =?utf-8?B?ZWl4bnRYOW00MEIwRk90VUdOMkRmUkU1NTdjNG12S00zRHo1SHk2SWNHdnZn?= =?utf-8?B?cW5yY0xnNHUyVGdwb05qUUtkWDBFd0dQd211Lys2T3NpdGFKV3F1WkhqTVJ6?= =?utf-8?B?QWFEdmp0VDNVbU8zODlUaU5STTN3NGc0MXVOdVZTenAzNVFzSDJYdDkzOXpN?= =?utf-8?B?WkxweXYvaDBQN0d0L1JWUHhqaXRiNG9sMzc5RlAvUmhOMmZrWU5zb0Y2d2cy?= =?utf-8?B?bDgzUmgwbGNBeWkxb3BBV0Z0MWdmNDJnL2t4dHNmbjZjR0p0T2dkZ0dEUk56?= =?utf-8?B?MXdzUFNlV2JIRHFXdmZ6UmlxQ0JjQklkcC8veXFrcmJMQ2xndE1oMkxLTTZC?= =?utf-8?B?b29VSDRLaHQxR20wdHlMaXdQVWJuSmpKSnJmNklPbzVhckxyME1zRnNxSDZR?= =?utf-8?B?cnZKT2pIbjhsWUhlZXlHcUJtV0d5SC9DYU1xSkpaeEIxaitJZkg0dlduUUlT?= =?utf-8?B?NWdqTHpsNENzU3dKUkpuUWRNS3kvVWdnZ25vZXBiUWNUckRONVUwaHFQZFFK?= =?utf-8?B?ZnhlTW1HTm1xSGtUdm5lL01ySisrdDhWZnl5Q0xrTVdUVHY1Z1FGZ2JMOUVs?= =?utf-8?Q?30PYXsDF5r2AA?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;6:vF38kpNzLxcJXqqANfjCoQcUjweETFiiN5X/i6SS3wW2Deph06/ZdUXnZoqcpb3WENFUr0e6x/GBQLj6q71vwSpAj8T/8fdPR2MKDCdsRHG9D//q0N0o7boe7VeF6L6gLtui0GjZVGQUxp4H68R28AdAd2yFgEaA1d2a5bL0+QhXbsZBxYSCvdkH5Tkpcr5akJgeCki1En+m5PiemFHElVuxyfCCZr3yuPHhuKdJFMpxDlG04x9RvyHfaV/RK8fy4rI54Vu3hgLi/zjxC40YitGEN9yOoiy6A/e9p21q1VGaSpHz2p63+f9HAPjsryGu0kZnXcBTsyRt5qAH7t6MfrhGazW//jpncyD5R7v5IO3sZ5AN9U0N5d/nRYzooq/KQ8NuqqNUUutKdyQssvhihY3LLU5f3tAFaEDWZnW2MGmdtS7WA+jr0ZKQkyeFA0FxsFxMIG9+hfA3AGRgzTkqC7p0UU2b8FV59potV7iQa6h/UPGgVtKSKslrt0d+1wg0NNbdzUdtaNjK7Qss+L0MVw==;5:L6Rxoor0OfZg1oc2yjXxpEg+LVHYhAa/zmf+S+v2hoSkyQcFOXjQwjh/Kim/ya7LyrgfGKla+rkgzfw93oVccN6RxurWnfkrX7Snn6ZthEZsPYawORzPvNWOACtLsAG3DjelhM7SaPpKiV92sK6k3Q==;24:ESC/vYjnPGwdTstyAm4gWF6geM4QcjTSQ44h9b0MbpvDinyvpJHjTUYUZGckPNys5KkgC+2KdbOvdspO6vZF1GhLc6R1ns4EUw3bZrEDQQ4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;7:Q16wXzzNM3kPiLE8cyctmi0UrncB1G+cx0SnMjI3Y0vfSGL8Z1969DCIITnJ6gurtzsG9CJn1JgVJI9NdmPQgpda5mdRK8K6hhxuKoE/RmEfxPDSNyuyN4YVNYo0ib3jDOh/vcpW3/mjaGAVKA7JYVzkQzV1pmSNcP0xBCz4LLNwx0qiVPWGrABOxDuKx8PPJxYnrRp6T5QI1Ji1jHMOixJbkC79Oys/+fxpCw3e/0u0qCNAjZBmLX7Yc3tlQSyy9xuQ0Pu9NP/GSzXnWanpYvKbgYlSS/IyA8kGIR2tL+VQ46xtwVnyRwMFBQtn1l1ihzfwNiGezZQ0r8UhvihzAQ==;20:NGsy9m9uPuXAPL+UifvfWtabaZ/Epw4lGpIAgIMGYtmo/dNxffxnacDPXI2pzfW+XyrrBH+WviflUCWAgrOAInkwSHQLggCrrLubMT4pKg7pT9TSvWIUYK9vyKu2iG7bYUt+n1Xy0NPmKr3lSMAirKdOtyqAzRimFdkMnaMU0SM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2017 15:45:43.2499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1189 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-09_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2017 09:40 AM, Mike Galbraith wrote: > On Tue, 2017-05-09 at 09:15 -0600, Jens Axboe wrote: >> On 05/09/2017 09:13 AM, Jens Axboe wrote: >>> On 05/09/2017 09:04 AM, Mike Galbraith wrote: >>>> On Tue, 2017-05-09 at 08:53 -0600, Jens Axboe wrote: >>>>> On 05/09/2017 12:07 AM, Mike Galbraith wrote: >>>>>> Hi Jens, >>>>>> >>>>>> I was about to fix up this splat.. >>>>>> >>>>>> [ 445.022141] loop: module loaded >>>>>> [ 445.078116] BUG: using smp_processor_id() in preemptible >>>>>> [00000000] code: loop0/3801 >>>>>> [ 445.085873] caller is debug_smp_processor_id+0x17/0x20 >>>>>> [ 445.091016] CPU: 7 PID: 3801 Comm: loop0 Tainted: G >>>>>> E 4.12.0-default #40 >>>>>> [ 445.098838] Hardware name: IBM System x3550 M3 -[7944K3G] >>>>>> -/69Y5698 , BIOS -[D6E150AUS-1.10]- 12/15/2010 >>>>>> [ 445.108564] Call Trace: >>>>>> [ 445.111016] dump_stack+0x65/0x89 >>>>>> [ 445.114330] check_preemption_disabled+0xde/0xf0 >>>>>> [ 445.118945] debug_smp_processor_id+0x17/0x20 >>>>>> [ 445.123300] blk_stat_add+0xb0/0x130 >>>>>> [ 445.126876] __blk_mq_complete_request+0xb5/0x150 >>>>>> [ 445.131575] blk_mq_complete_request+0x16/0x20 >>>>>> [ 445.136020] loop_queue_work+0x5f/0xaa0 [loop] >>>>>> [ 445.140461] ? _raw_spin_unlock_irq+0x21/0x40 >>>>>> [ 445.144816] ? finish_task_switch+0x85/0x270 >>>>>> [ 445.149085] ? __schedule+0x291/0x8c0 >>>>>> [ 445.152747] kthread_worker_fn+0xc2/0x1d0 >>>>>> [ 445.156754] kthread+0x114/0x150 >>>>>> [ 445.159983] ? __kthread_init_worker+0xb0/0xb0 >>>>>> [ 445.164424] ? kthread_park+0x60/0x60 >>>>>> [ 445.168085] ret_from_fork+0x2c/0x40 >>>>> >>>>> Is it from this_cpu_ptr() in blk_stat_add()? >>>> >>>> Yeah. >>> >>> So why is this complaining, doesn't rcu_read_lock() disable >>> preemption? >> >> Ah, I guess it doesn't if PREEMPT_RCU is set. How about the below? > > Should do it. I was about to run LTP (where it turned up) again > anyway, I'll add this. No news is good news, what you should hear. Thanks, let me know, so I can add your tested-by (or whatever you prefer). -- Jens Axboe