From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756369AbcECUKQ (ORCPT ); Tue, 3 May 2016 16:10:16 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:62103 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755835AbcECUKO (ORCPT ); Tue, 3 May 2016 16:10:14 -0400 From: Arnd Bergmann To: Thierry Reding Cc: Kishon Vijay Abraham I , Stephen Warren , Alexandre Courbot , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] phy: tegra-xusb: add pinctrl dependency Date: Tue, 03 May 2016 22:10:02 +0200 Message-ID: <1959742.2n4CUJfeCu@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160503160708.GA20266@ulmo.ba.sec> References: <1462289101-797073-1-git-send-email-arnd@arndb.de> <20160503160708.GA20266@ulmo.ba.sec> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/t4bFhL/BZbganvTytfb1Hb40IqZYrmIsFz66/U4HytEbsZ3GK0 myiX9B7p36zLEqzCv7l0EP7ql1ero7QbnHkLd2GDLgKb1tOVGJ1kbTd6aJ1WZ+xLaMi7QWv hidDraiSEoEBbD2YH5bni4Ybv13YnNiF1BW104grekn/s3rLxgRPIxp6qcCRxRuI6Rm5MXr xLY3aJraKGAYwiOacMxuA== X-UI-Out-Filterresults: notjunk:1;V01:K0:+nGVOnPevtM=:b7hoArQU7Uul6xL0f2BSBM HpUouwOVnFFrDXo4/vdrwzruPEIGZTRJW8YebHaZOzmRLNEsVbUkDyBByqHxjQidln6sbhauo V0+tsCqIOKvioF/1x6/CBLykXl8sDcadzQMMYyYcZadSLG8YL/M86XCDMGigbiPDifIY9610i ydY/rv2Ldzh4aYV9nxllG+fOSwGigEJXcQ72S6po1KTOOLPOrCuSeiXEOdIhsVJaI4108Qc/u 3E/TQPvTTJOQH1EuZjVUIi1m76Irbn0pQ04or+fB6KO7SBTRZB21Z/gQpqtIzZGk0Ip8KFkv7 jDvpiC28nVV2xNTDKbmtER39mkccdNp4RIWdxZ1Rv9ct/mQ+9W7MZP9Vv8OR/6GctuBp1/dMH pqouAMQPAe/Hr3xHxzd+098R0IJYFi7DureVH1CIkCKkBwChScan26blrtJoe9eg3z174kvWe V/1AKB5ghJ0byyiOxKEXQdjogbUe3S9Qilv2B7AZ1duq2fJYIoCAEShQGIgbFdaM3mr+XHWnA TEXh6qijAnNbzmxRDRQbO+WANHGzkpPZkzB6qAypQBlYS5uIpvkUU6PgcaxlIDFWMwD/tvCKf IGhFVzMOZF/9QwapKdh/UipAP23XC63b/6b5xelAJjwmmkbOoBA6RLlYh/xUyGXZlJZjyfdow aq9W7vhpQJfn0jVe5BblqULD8Q5XHE2cZQ/voSi4X3h1Fpvzi2IiQYMpDffQr9w1YVjCVM578 +CRZ3/by7H4H4ANw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 May 2016 18:07:08 Thierry Reding wrote: > Wouldn't that be more of a case for a select dependency? I'm thinking > something like the below (untested, yet). > I usually prefer 'depends on' in a case like this, but it doesn't make a huge difference. If we end up using 'select' here, we should make the other symbol invisible though. > --- >8 --- > diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig > index a3b1de953fb7..59e0dba9259a 100644 > --- a/drivers/phy/tegra/Kconfig > +++ b/drivers/phy/tegra/Kconfig > @@ -1,6 +1,7 @@ > config PHY_TEGRA_XUSB > tristate "NVIDIA Tegra XUSB pad controller driver" > depends on ARCH_TEGRA > + select PINCTRL_TEGRA_XUSB > help > Choose this option if you have an NVIDIA Tegra SoC. > > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > index e4bc1151e04f..42a5c1dddfef 100644 > --- a/drivers/pinctrl/Makefile > +++ b/drivers/pinctrl/Makefile > @@ -23,7 +23,7 @@ obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o > obj-$(CONFIG_PINCTRL_ROCKCHIP) += pinctrl-rockchip.o > obj-$(CONFIG_PINCTRL_SINGLE) += pinctrl-single.o > obj-$(CONFIG_PINCTRL_SIRF) += sirf/ > -obj-$(CONFIG_PINCTRL_TEGRA) += tegra/ > +obj-$(CONFIG_ARCH_TEGRA) += tegra/ > obj-$(CONFIG_PINCTRL_TZ1090) += pinctrl-tz1090.o > obj-$(CONFIG_PINCTRL_TZ1090_PDC) += pinctrl-tz1090-pdc.o > obj-$(CONFIG_PINCTRL_U300) += pinctrl-u300.o This change helps, but feels a little unclean. It also prevents us from adding a '|| COMPILE_TEST' dependency. How about making PHY_TEGRA_XUSB silent, and adding the 'select' in the phy driver along with 'depends on PINCTRL_TEGRA'? Arnd