From: "Bastien ROUCARIES" <roucaries.bastien@gmail.com>
To: "Jesper Nilsson" <jesper.nilsson@axis.com>,
linux-kernel@vger.kernel.org,
"David Miller" <davem@davemloft.net>
Subject: Re: lib/klist.c: bit 0 in pointer can't be used as flag
Date: Wed, 14 Jan 2009 00:11:32 +0100 [thread overview]
Message-ID: <195c7a900901131511l7077eebar8396267e3f2b670b@mail.gmail.com> (raw)
In-Reply-To: <20090113.144521.97357573.davem@davemloft.net>
On Tue, Jan 13, 2009 at 11:45 PM, David Miller <davem@davemloft.net> wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Date: Wed, 14 Jan 2009 07:40:19 +0900
>
>> > It may be that we've worked around the other spots, although I haven't
>> > seen anything like that, we might just have been lucky until now.
>> >
>> > Can you recall another place where this trick is used?
>>
>> rmap.
>> Don't CRIS use mmu?
>
> I'm beginning to suspect the issue is only with objects
> in the kernel image itself. Dynamically allocated memory
> is properly aligned and therefore the "low bit status bits
> in pointer" trick works.
Perhaps using a pointerhackalign trick on this structure where
#define pointerhackalign(x) __attribute__ ((aligned (x)))
and declare
struct klist_node {
...
} pointerhackalign(2);
Because __attribute__ ((aligned (x))) could only increase alignment
it will safe to do that and serve as documentation purpose :)
Regards
Bastien
next prev parent reply other threads:[~2009-01-13 23:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 15:14 Jesper Nilsson
2009-01-13 21:10 ` David Miller
2009-01-13 22:12 ` Jesper Nilsson
2009-01-13 22:40 ` KOSAKI Motohiro
2009-01-13 22:45 ` David Miller
2009-01-13 23:11 ` Bastien ROUCARIES [this message]
2009-01-14 10:19 ` Jesper Nilsson
2009-01-14 10:21 ` David Miller
2009-01-14 10:36 ` Jesper Nilsson
2009-01-14 10:45 ` David Miller
2009-01-14 11:02 ` Jesper Nilsson
2009-01-14 15:12 ` Jesper Nilsson
2009-01-14 18:17 ` Greg KH
2009-01-14 21:53 ` Jesper Nilsson
2009-01-13 23:54 ` KOSAKI Motohiro
2009-01-13 23:59 ` Greg KH
2009-01-14 10:25 ` Jesper Nilsson
2009-01-14 0:33 ` Hugh Dickins
2009-01-14 10:18 ` Jesper Nilsson
2009-01-13 22:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=195c7a900901131511l7077eebar8396267e3f2b670b@mail.gmail.com \
--to=roucaries.bastien@gmail.com \
--cc=davem@davemloft.net \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®