From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAFA39461 for ; Tue, 1 Apr 2025 16:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743526672; cv=none; b=l/6uJt1TB2JMMOoUrUTx/mnY2QaGPpF8G1dw5i56O3BenLSjERcbs8XIWJ2IXJtRCYQYq3ycR33fcoSDPK6RBaOKpFDr/xxBRFM1NfP7nLlu9p6UfSIaQwMc+yox5rDARv65U58mRxqGdeWDEPQcT+DWIxeXU8AKSs00lye08us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743526672; c=relaxed/simple; bh=F0V2cxyptzlCagkPfeXyVKb1UCEuS/E5+mcuEtZlLrw=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=F20oKIuCpgy3r6o58wuU0E1Q/khWvVSzDSatg99ZCj3zKTJdJgzn9hQa7yDCGmKL4NM0veMFvLu+ifXMZxnZcHOWVbNq+qAEAj4mRHhUrMQSBv56C7JnQi8lgo305mvs88oKLlaTC1+Nl2ARPFPuBA+ersGkebRdqWQNKEgjBJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=cW5mZKyF; arc=none smtp.client-ip=209.85.161.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cW5mZKyF" Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-601ff283d70so1729785eaf.3 for ; Tue, 01 Apr 2025 09:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1743526669; x=1744131469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=vq1eST4XdAuqIXqauWM348TcT38DynoDIrbdBB+uK9Y=; b=cW5mZKyFOXP5n1yH/xv8m6AT3P5IHyqWgB5RV9lZwBab+kwhbTk7RV6kkVnKxYvt7Z PtnCZQCDeI8fvIoz7MYskSKt79i/Gmmbxut3xoFflX9TLpTIjBhkI47X2fsVSUtN0T03 hJChLF/I94d3xh2jAKVe5y1c8aBMB/yk3pCGo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743526669; x=1744131469; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vq1eST4XdAuqIXqauWM348TcT38DynoDIrbdBB+uK9Y=; b=q2yZ2FQkgKVJxa9y8k7PsC9xkAXDV1Dn5GxIEnJBhFnyBvNC4ckfMBrq3H1xWveRYw zsyNz19e6HdxeP1TwYDgSd/6IYzpEVvnlfXQB496funw/XcHegoOxAUROyM92dboSeFX pH8WV0pxSDr/Ahr1zy+EpPoXjyK0TLAKUIL8CtC95fqFdbjORO4OtjWRhhhH7nVi2uWx WaD/qIJ75NLGtzvQLbWKMTUxCjYb5uHZPgb+dp3Gpx4I0fF/YpuSlyVunO2Z5ol7Po0h d6sj+7KGegLQPtewHWQN3w4TeaGqJfv471n5JtR477JM+0+O+4H70kYDjDzD/LYa7g0S 1wlA== X-Forwarded-Encrypted: i=1; AJvYcCUF+d3gmEt4ucDo0Y4zA2EX//L1BZbV69p8KiTIbB0dHipX0zDVHXNujjBlfK8XFvb3cc4HtigJD27cjGc=@vger.kernel.org X-Gm-Message-State: AOJu0YyeL08SaJNziM51dO6LlEC11P/A19SWamXi+0ewdui4RAylGDtu NkFtD3U3zIAwrJOkRlgvJj92G8jexpa+nBslBqf6+fb9yxPk44l7jzOIM0jsEQ== X-Gm-Gg: ASbGncvRblVUbfXDOsIa4kMn9q1KKfrfpDHFoLuH6u6SGfjOO2ICFUcyGdtJfs4bKQf DqLS+8FW58he1rLruWNjbzsJR+JSq2z5LmETPetrszUomzbqa2Mjm71yPxW2fhomn/kT4kDjzV0 SZ0zNqjN21QCwh/95fegUhgF8bfcOC9OdL86YJQd91KqUuQIyY5Jharh/iiqyy/0zQF67b+GmVI NVU2yMj2wxV8OvzERZPRp533M1qfs21BW8TTDRQfYXVt3A3cx/ojcb/tv53+OBS27H40VgDkwb0 lDQ27K7qJj6OvQKCBTSTSa/yXSO2O5WM0PDYXbvPet613ug4FpbxfvUBmM8inC79Jgzpzt9Hh+q 6Ert7hVI= X-Google-Smtp-Source: AGHT+IGBx1noyN3TJ313n9Kthyl/Yjyce+VVSvoH/kFWvJU9RS3mJIOp7wnfQiVem0qSyin3ne6N0w== X-Received: by 2002:a05:6808:3448:b0:3fa:39cc:3be9 with SMTP id 5614622812f47-3ff0f4eb1a7mr9016782b6e.2.1743526668749; Tue, 01 Apr 2025 09:57:48 -0700 (PDT) Received: from [192.168.178.39] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ff05278de3sm2002721b6e.36.2025.04.01.09.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 09:57:47 -0700 (PDT) From: Arend Van Spriel To: Henry Martin CC: , , , Date: Tue, 01 Apr 2025 18:57:42 +0200 Message-ID: <195f2498f70.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20250401140924.29168-1-bsdhenrymartin@gmail.com> References: <20250401140924.29168-1-bsdhenrymartin@gmail.com> User-Agent: AquaMail/1.54.1 (build: 105401536) Subject: Re: [PATCH v1] wifi: brcmfmac: acpi: Add NULL check in brcmf_acpi_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On April 1, 2025 4:09:36 PM Henry Martin wrote: > devm_kasprintf() returns NULL when memory allocation fails. Currently, > brcmf_acpi_probe() does not check for this case, which results in a NULL > pointer dereference. > > Add NULL check after devm_kasprintf() to prevent this issue. > > Fixes: 0f485805d008 ("wifi: brcmfmac: acpi: Add support for fetching Apple > ACPI properties") > Signed-off-by: Henry Martin > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c > index c4a54861bfb4..4885d5d0a0af 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/acpi.c > @@ -25,6 +25,8 @@ void brcmf_acpi_probe(struct device *dev, enum > brcmf_bus_type bus_type, > settings->board_type = devm_kasprintf(dev, GFP_KERNEL, > "apple,%s", > o->string.pointer); > + if (!settings->board_type) > + return -ENOMEM; brcmf_acpi_probe() has void return type so this would give a compiler warning. I expect submitted patches at least do pass compilation. After digging through the driver code I see a null check everywhere it is used. Can you please provide a kernel log with a null deref so I may have a clue where it goes wrong? If any. Regards, Arend >