From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>, Ingo Molnar <mingo@redhat.com>,
Jiang Liu <jiang.liu@huawei.com>,
linux-acpi@vger.kernel.org, x86@kernel.org,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@linaro.org, linaro-kernel@lists.linaro.org,
linaro-acpi@lists.linaro.org
Subject: Re: [PATCH v2 0/6] Remove the duplicated _MAT evaluation and simplify _acpi_map_lsapic()
Date: Mon, 02 Sep 2013 14:12:22 +0200 [thread overview]
Message-ID: <1961453.53nfG0bXEh@vostro.rjw.lan> (raw)
In-Reply-To: <1378094259-5922-1-git-send-email-hanjun.guo@linaro.org>
On Monday, September 02, 2013 11:57:33 AM Hanjun Guo wrote:
> v1->v2: Return specific error value instead of just return -1, and
> correct some grammar mistake in changelog.
>
> For cpu hot add, evaluate _MAT or parse MADT will did twice to get
> APIC id:
> acpi_processor_add()
> acpi_processor_get_info()
> acpi_get_cpuid() will evaluate _MAT or parse MADT;
> acpi_processor_hotadd_init()
> acpi_map_lsapic() will evaluate _MAT again;
>
> This patch set introduces apic_id in struct processor to save parsed
> APIC id, and use it to remove the duplicated _MAT evaluation.
>
> Further more, the new logical cpu number will be generated in
> acpi_register_lapic(), this can be returned to remove the cpumask
> allocation and operation to simplify _acpi_map_lsapic().
>
> There are also some cleanups for the ACPI processor dirver code.
I like the series, so I've queued it up for 3.13.
Thanks,
Rafael
> Hanjun Guo (2):
> ACPI / processor: remove unnecessary if (!pr) check
> ACPI / processor: Remove outdated comments
>
> Jiang Liu (4):
> ACPI / processor: Introduce apic_id in struct processor to save
> parsed APIC id
> ACPI / processor: use apic_id and remove duplicated _MAT evaluation
> x86 / ACPI: simplify _acpi_map_lsapic()
> ACPI / processor: remove some dead code in acpi_processor_get_info()
>
> arch/ia64/kernel/acpi.c | 38 ++----------------
> arch/x86/include/asm/mpspec.h | 2 +-
> arch/x86/kernel/acpi/boot.c | 88 +++++++++--------------------------------
> arch/x86/kernel/apic/apic.c | 8 ++--
> drivers/acpi/acpi_processor.c | 22 +++--------
> drivers/acpi/processor_core.c | 26 +++++++++---
> include/acpi/processor.h | 3 ++
> include/linux/acpi.h | 2 +-
> 8 files changed, 60 insertions(+), 129 deletions(-)
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-09-02 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 3:57 Hanjun Guo
2013-09-02 3:57 ` [PATCH v2 1/6] ACPI / processor: Introduce apic_id in struct processor to save parsed APIC id Hanjun Guo
2013-09-02 3:57 ` [PATCH v2 2/6] ACPI / processor: use apic_id and remove duplicated _MAT evaluation Hanjun Guo
2013-09-02 3:57 ` [PATCH v2 3/6] x86 / ACPI: simplify _acpi_map_lsapic() Hanjun Guo
2013-09-02 3:57 ` [PATCH v2 4/6] ACPI / processor: remove some dead code in acpi_processor_get_info() Hanjun Guo
2013-09-02 3:57 ` [PATCH v2 5/6] ACPI / processor: remove unnecessary if (!pr) check Hanjun Guo
2013-09-02 3:57 ` [PATCH v2 6/6] ACPI / processor: Remove outdated comments Hanjun Guo
2013-09-02 12:12 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1961453.53nfG0bXEh@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=hanjun.guo@linaro.org \
--cc=jiang.liu@huawei.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®