From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757088AbcEFAF5 (ORCPT ); Thu, 5 May 2016 20:05:57 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:62644 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754684AbcEFAFz (ORCPT ); Thu, 5 May 2016 20:05:55 -0400 From: "Rafael J. Wysocki" To: Steve Muckle , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: cpufreq governors broken with !CONFIG_SMP? Date: Fri, 06 May 2016 02:09:07 +0200 Message-ID: <1961527.dEtpL4HAvs@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160505234922.GA14673@sky.smuckle.net> References: <20160505234922.GA14673@sky.smuckle.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 05, 2016 04:49:22 PM Steve Muckle wrote: > While working on a few patches for schedutil I noticed that the CFS > cpufreq hooks depend on PELT, which depends on CONFIG_SMP. > > I compiled and ran a UP kernel with intel_pstate. Running a cpu-bound > task did not result in the frequency increasing beyond fmin. For some reason > ondemand is working for me with the same test, not sure why yet. > > It appears dbs/intel-pstate/schedutil have a dependency on CONFIG_SMP > now. Or am I missing something? You're right AFAICS. For governors other than schedutil fixing that would be a matter of adding a !CONFIG_SMP variant of update_load_avg() that will call cpufreq_update_util() and do nothing else. It doesn't matter what is passed via util and max then. In turn, schedutil should probably depend on CONFIG_SMP. Peter?