From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20D6922D4F6; Tue, 8 Apr 2025 16:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744128157; cv=pass; b=DJyXGKXZuXJj1+vv291zR947ieId3fIkc69GrStgsafbQhdcelg2S5gCy0sOCo+zPR0gqdpIaec4u3ynXjhkbYgjZS7b0ywNS8EAuR1uwHTeTfQg+7dQcUmMlNyC+Dzl6Ojukvn7UIjkmvSsAA9sLljiAeqT19mqJNDCaNAt4wM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744128157; c=relaxed/simple; bh=kNGFGf98aTPJsaOMz438U5XU6vW4iKbgq8UC54nobAE=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=dxu4QBMoyy8U4DiG1ob1Ww8i8PPuyIbRyOvjDbaQESNvwRxHovavLwWWhQTN87txRrENv1QW5+pvLnUYH56KqFeF0JqH9S5VeiJSvO05esu3srauLZHVuAlbo8e0tsZzSZat1iQl7Iw6D7TstqpoIJIzL0vi+85oJtI8byJi9MA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=martyn.welch@collabora.com header.b=kRsY0/+o; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=martyn.welch@collabora.com header.b="kRsY0/+o" ARC-Seal: i=1; a=rsa-sha256; t=1744128129; cv=none; d=zohomail.com; s=zohoarc; b=mnvA0U6gu5D1adVHNyzGk6daeByrjdf2vkFwznYEwD6irNssbWrechvnb0X19BCHnyJ1zWM+yTZPy0v88i7ZknKkGkwAZdugpxNNh1bXOxn1dmnzTS7TWPs+ohZCP/CHuaaXHySAwSdG1rdYFgwlCfEobHYO1L0uuOlOCLdMHic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744128129; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=pfOSYHYspGzottUnArFkYcpitk4r7QWdZuM3+8JN/mM=; b=b9YxsACy0OWipiJ9j9dxKTf4ITMizDCae13iZ/kdtVxbfacz6Nbh0SEc/cL3AFGfoAf1QAzOgZf/Jwx+WiDg4LIb6iqpqgA21VrHbBUEjliAqdrNmEm2fDw6U1Wxt85IooWgGQLUPHTjCqT2WoXZTSbHW2V8uu4OUuPlvTS/beo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=martyn.welch@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1744128129; s=zohomail; d=collabora.com; i=martyn.welch@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=pfOSYHYspGzottUnArFkYcpitk4r7QWdZuM3+8JN/mM=; b=kRsY0/+or4//xtvdrskrfgxm1Tp+3Jpiq5gdpzPUvH1ydRgK2D2q/JgE5JzxJD+4 B5UZp4nWbrKYEUCCtrAzG8sh84EoTbl0AwKekdrLKR57f3P87+v0wxqvHcAuwdTREuD W728ScZPxgXfVg2sepYFuOGC/l3s8ELU0a06MMrg= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1744128127769606.6585613743389; Tue, 8 Apr 2025 09:02:07 -0700 (PDT) Date: Tue, 08 Apr 2025 17:02:07 +0100 From: Martyn Welch To: "Andrew Lunn" Cc: "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "kernel" , "devicetree" , "linux-kernel" , "imx" , "linux-arm-kernel" Message-ID: <196162332ff.b61ad5b5564260.8672918780815538746@collabora.com> In-Reply-To: References: <20250327123907.542132-1-martyn.welch@collabora.com> Subject: Re: [PATCH v2] arm64: dts: imx8mp: Add device tree for Nitrogen8M Plus ENC Carrier Board Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail ---- On Thu, 27 Mar 2025 14:25:38 +0000 Andrew Lunn wrote --- > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-nitrogen-som.dtsi > > @@ -0,0 +1,415 @@ > > +&eqos { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_eqos>; > > + phy-handle = <ðphy0>; > > + phy-mode = "rgmii-id"; > > + status = "okay"; > > + > > + mdio { > > + compatible = "snps,dwmac-mdio"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy0: ethernet-phy@4 { > > Just conformation, the PHY is on the SOM? Are the magnetics and RJ45 > socket on the SOM, or the carrier? > The PHY is on the SOM, the magnetics and RJ45 socket are on the carrier. > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <4>; > > + eee-broken-1000t; > > > +#if 0 > > + interrupts-extended = <&gpio3 2 IRQ_TYPE_LEVEL_LOW>; > > + reset-gpios = <&gpio3 16 GPIO_ACTIVE_LOW>; > > +#endif > > Please don't have disabled properties. > ack. > > + reg-mask = <0x90>; > > What does this property do? It is not one i recognise. > Good question. Seems I missed quite a few bits whilst trying to clean this DTB up. Will try again.... Martyn > Andrew >