From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBFEEC07E85 for ; Tue, 11 Dec 2018 10:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB62D2082F for ; Tue, 11 Dec 2018 10:48:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB62D2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726471AbeLKKsF (ORCPT ); Tue, 11 Dec 2018 05:48:05 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:58880 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbeLKKsF (ORCPT ); Tue, 11 Dec 2018 05:48:05 -0500 Received: from 79.184.252.35.ipv4.supernova.orange.pl (79.184.252.35) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.183) id 7b48bb81d93096dd; Tue, 11 Dec 2018 11:48:03 +0100 From: "Rafael J. Wysocki" To: Viresh Kumar , Yangtao Li Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] cpufreq: pmac64: add of_node_put() Date: Tue, 11 Dec 2018 11:47:45 +0100 Message-ID: <1962056.WEnsRsenr7@aspire.rjw.lan> In-Reply-To: <20181126060226.wsludir4g7bao4lk@vireshk-i7> References: <20181123133340.26849-1-tiny.windzz@gmail.com> <20181126060226.wsludir4g7bao4lk@vireshk-i7> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 26, 2018 7:02:26 AM CET Viresh Kumar wrote: > On 23-11-18, 08:33, Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > g5_neo2_cpufreq_init() doesn't do that, so fix it. > > > > Signed-off-by: Yangtao Li > > Acked-by: Viresh Kumar > > --- > > Changes in v2: > > -update changelog > > --- > > drivers/cpufreq/pmac64-cpufreq.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c > > index be623dd7b9f2..1d32a863332d 100644 > > --- a/drivers/cpufreq/pmac64-cpufreq.c > > +++ b/drivers/cpufreq/pmac64-cpufreq.c > > @@ -411,6 +411,7 @@ static int __init g5_neo2_cpufreq_init(struct device_node *cpunode) > > pfunc_set_vdnap0 = pmf_find_function(root, "set-vdnap0"); > > pfunc_vdnap0_complete = > > pmf_find_function(root, "slewing-done"); > > + of_node_put(root); > > if (pfunc_set_vdnap0 == NULL || > > pfunc_vdnap0_complete == NULL) { > > pr_err("Can't find required platform function\n"); > > Acked-by: Viresh Kumar Patch applied, thanks!