From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA4B2C08D0 for ; Mon, 8 Dec 2025 13:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765200487; cv=none; b=iIoJ5EhXCwVI+do24hSm/Twn/O+sOxlvB5KYbe8s3SzHSGvdLcAth6N0ylh93/6YLEjHqNIeM9DakuKF6HtMm7s5N4lI7e2Hdt0n6H2aGNetvS2UQt49Td8cctPu13FkKrHS3F7FN3e6OgEXt07GnMUrMTHNLna/FnDpMpYHh2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765200487; c=relaxed/simple; bh=ZvUsiZtvhhNdLAfSWiOEhbkDZkzZTRSe61KoteKi8Lc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ff7MFOGpJC8zpPw5Vxh/O18eFFES5z7SS5RsloYPrIWBbA35wD84Ww84HwNxvGj57wtbCeMTvZ8SqoY+8ayckZWu1u0prOc8zX00yS3V/HXYRzD1v5W4/mzR9/bpbPrPusmGxLFp0VTCObPIWpvh124UPziJ9fBq6aa3qcF05yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GQdsSDS7; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GQdsSDS7" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7ade456b6abso3644404b3a.3 for ; Mon, 08 Dec 2025 05:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765200485; x=1765805285; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DbHHkduGncpuPtot795Xe6V8uWxMjY6W8fGIG+hxDeg=; b=GQdsSDS7x+qbAyZ1oLp2/vuQG2rzfXNmK5l+7sCecDd4AB7q60xWIcayC2cIQlGHZ9 rNaLVfqaLiwUuELyixSX9aF96MkS1hZMriJPLESp/Vrcle48Bbezo0Pn97NREUPdlIJc 3HPIG0EwIki1L4nu2me0O5usBG+zdkjNE/QFchyQD9w/PBrgIf7PDTQ54opn5lOusYeS i23kVyQFErSqC1DczjXhvtQScTOSHapQXBX2aP0XqEzSGKVDnkgWCdXSv4FWX2x9nWVi eVN5uRMfpNHyaHtvauzborYQYo45g12QQtYDfSZawJ6gs+sW1WoOP7Cwu/HrvXloojOg uSeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765200485; x=1765805285; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DbHHkduGncpuPtot795Xe6V8uWxMjY6W8fGIG+hxDeg=; b=nQgNvWHJWEKLtEcyxoRb2Fu/6UH8/C28z8Jce9aKASwv5KCGlcUKzZlVyJ+sknRRIB wihYn/Mu1CwWxWsiTmecSiGecPERHmEgcCsGok3QeKW4ptRbU3pBRoGS5wiyD1edCcFm z8TAsMbtPHAepRjKWaVzYEx5RJPaJEqhfxR5auFFghEX0szT/aZiW5QKWCRIzytG7Bh+ SADJrqjjQ0X34NoBFW/kIOfjnMtzJXQvyPnK0HV+XIXedQo0aQv/nnMp2RIANAec/YUZ m1gpjAm+tu73kkXh2UbQOZr9QOrx7r3ZeTn0LIXzIi+z0LPi/jmKQxVFOkAp++3Jz/JN SC2g== X-Forwarded-Encrypted: i=1; AJvYcCVnCs6kUc5ko7RUkQ0h6pj4ysCnpNblEkZuB4/eO5sKGzalUVIIZ406rHXeV8eL6I1X5ODBG31znAsjMB8=@vger.kernel.org X-Gm-Message-State: AOJu0YzvvKRIGuOkrRD/dQjR2wBph7SfK8hgxoeXFxmIl0HgjFaeuxG1 gjAgDjzLyPEyqsdIEnv/JMrBadwrr0+pAqrb61r3EFW+XY8qX7dXzTrh X-Gm-Gg: ASbGncsCtkKvzZy3D6YGCYFbUWtaVpAH1QG3/RU7ei9c6xBk8RD6LGivmN6g2tEdXAq juE/DhAyt/VLHOu1r8XhUo2WBV728JfUlNRSghUDSShYPmnxiFaXbFNXljqYB+sKXehGtkYbUkC ixo08MOhxjvIXOOS1i8WayZHyESfzBPHWsuxFpN5eQa2n/VY11ktIj9RDvukneiELJstHM5hTCp LVuQld6KsIuoZ7i8zdXlOjgA/hENVRJn+YTJw/r7etbRlM9KVKPIDbZwvHZVs0iLt2+S5/+JRXY CL4BjCel4tCt+NUDBeiVVDHY+0Aeb7D+AvvInVaovTpjsbDbKvJuofAjROt66aeSBjJlJDDSEr+ VWCoZK6bCUgKGMnBfwxUH2kd92yRDItKelTma1gYt83Y2kREBKnK1hiisBR01sbAC045Tz15oVT AZJJgpMrk= X-Google-Smtp-Source: AGHT+IEJink5dffLsMfjiF2kZmo0I3LJowM/dJuNuWV+1SloCdfrgSufG4LI0yl6V1FTUBYmf5D2Fg== X-Received: by 2002:a05:7022:2226:b0:11b:e21e:5653 with SMTP id a92af1059eb24-11e03262c31mr5354387c88.19.1765200484612; Mon, 08 Dec 2025 05:28:04 -0800 (PST) Received: from [0.0.0.0] ([2605:52c0:1:b17:84f1:a0ff:fe39:857a]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df76e2eefsm58067184c88.6.2025.12.08.05.28.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 05:28:04 -0800 (PST) Message-ID: <19627811-c325-4ef3-8982-59fcd9ecbdfb@gmail.com> Date: Mon, 8 Dec 2025 21:27:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme-pci: add quirk for Wodposit WPBSNM8-256GTP to disable secondary temp thresholds To: Ilikara Zheng , linux-kernel@vger.kernel.org Cc: Mingcong Bai , Kexy Biscuit , stable@vger.kernel.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , "open list:NVM EXPRESS DRIVER" References: <20251208132340.1317531-1-ilikara@aosc.io> Content-Language: en-US From: RigoLigo In-Reply-To: <20251208132340.1317531-1-ilikara@aosc.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi all, On 2025-12-08 21:23, Ilikara Zheng wrote: > Secondary temperature thresholds (temp2_{min,max}) were not reported > properly on this NVMe SSD. This resulted in an error while attempting to > read these values with sensors(1): > > ERROR: Can't get value of subfeature temp2_min: I/O error > ERROR: Can't get value of subfeature temp2_max: I/O error > > Add the device to the nvme_id_table with the > NVME_QUIRK_NO_SECONDARY_TEMP_THRESH flag to suppress access to all non- > composite temperature thresholds. > > Cc: stable@vger.kernel.org > Signed-off-by: Ilikara Zheng > --- > drivers/nvme/host/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index e5ca8301bb8b..31049f33f27d 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -3997,6 +3997,8 @@ static const struct pci_device_id nvme_id_table[] = { > .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, > { PCI_DEVICE(0x1e49, 0x0041), /* ZHITAI TiPro7000 NVMe SSD */ > .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, > + { PCI_DEVICE(0x1fa0, 0x2283), /* Wodposit WPBSNM8-256GTP */ > + .driver_data = NVME_QUIRK_NO_SECONDARY_TEMP_THRESH, }, > { PCI_DEVICE(0x025e, 0xf1ac), /* SOLIDIGM P44 pro SSDPFKKW020X7 */ > .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, > { PCI_DEVICE(0xc0a9, 0x540a), /* Crucial P2 */ I have tested this patch on a CTCISZ 3B6000M-NUC with an exact same SSD and this has resolved the error with sensor(1). Tested-by: Wu Haotian