From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: <Dinh.Nguyen@freescale.com>
Cc: <linux-kernel@vger.kernel.org>,
amit.kucheria@canonical.com, linux@arm.linux.org.uk,
s.hauer@pengutronix.de, bryan.wu@canonical.com,
grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org,
daniel@caiaq.de, u.kleine-koenig@pengutronix.de,
xiao-lizhang@freescale.com, valentin.longchamp@epfl.ch
Subject: Re: [PATCHv6] ARM: imx: Add iram allocator functions
Date: Fri, 8 Oct 2010 15:53:31 +0200 [thread overview]
Message-ID: <19631.8795.122477.334402@ipc1.ka-ro> (raw)
In-Reply-To: <1286545333-30323-1-git-send-email-Dinh.Nguyen@freescale.com>
Hi,
Dinh.Nguyen@freescale.com writes:
[...]
> +void __iomem *iram_alloc(unsigned int size, unsigned long *dma_addr)
> +{
> + if (!iram_pool)
> + return NULL;
> +
> + *dma_addr = gen_pool_alloc(iram_pool, size);
> + pr_debug("iram alloc - %dB@0x%p\n", size, (void *)*dma_addr);
^^^^^^^^
Is there any reason to insist on this silly type cast instead of using
the format string that fits the data type?
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
prev parent reply other threads:[~2010-10-08 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 13:42 Dinh.Nguyen
2010-10-08 13:53 ` Lothar Waßmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19631.8795.122477.334402@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=Dinh.Nguyen@freescale.com \
--cc=amit.kucheria@canonical.com \
--cc=bryan.wu@canonical.com \
--cc=daniel@caiaq.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
--cc=xiao-lizhang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®