From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932616Ab2HVVpr (ORCPT ); Wed, 22 Aug 2012 17:45:47 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:58604 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932343Ab2HVVpm (ORCPT ); Wed, 22 Aug 2012 17:45:42 -0400 From: Dmitry Torokhov To: Linus Walleij Cc: Christopher Heiny , "Rafael J. Wysocki" , Jean Delvare , Linux Kernel , Linux Input , Allie Xiong , William Manson , Peichen Chang , Joerie de Gram , Wolfram Sang , Mathieu Poirier , Linus Walleij , Naveen Kumar Gaddipati , Henrik Rydberg Subject: Re: [RFC PATCH 1/17] input: RMI4 public header file and documentation. Date: Wed, 22 Aug 2012 14:45:35 -0700 Message-ID: <1965688.fPKEQJnVvJ@dtor-d630.eng.vmware.com> User-Agent: KMail/4.8.5 (Linux/3.5.1-1.fc17.x86_64; KDE/4.8.5; x86_64; ; ) In-Reply-To: References: <1345241877-16200-1-git-send-email-cheiny@synaptics.com> <1345241877-16200-2-git-send-email-cheiny@synaptics.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 22, 2012 09:08:00 PM Linus Walleij wrote: > On Sat, Aug 18, 2012 at 12:17 AM, Christopher Heiny > wrote: > > > +/* Helper fn to convert a byte array representing a short in the RMI > > + * endian-ness to a short in the native processor's specific endianness. Is RMI-endiannes different from BE and LE (joking)? Please simply state what on-wire endianness is and use xx_to_cpu() or cpu_to_xx() as needed. I think I mentioned it about a year ago already... Thanks. -- Dmitry