From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpcmd0757.aruba.it (smtpcmd0757.aruba.it [62.149.156.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 382092C187 for ; Mon, 2 Mar 2026 15:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.149.156.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772465097; cv=none; b=L/eL2iLnvFJBD8/AabWLkWNDNlLk1E3OMWRAC+6xp8851wpnxt7XjDfi57K1KbQQ4wHMdCHWU/5UlEkNF439l4TPoBwD0p+7fvGmPJtKXgJ2tmW69FzYbGwHMkL89sHKS0o1PpWBLJJuhSEPJXz3rE1dd/mwSv7ybZlEe+svhNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772465097; c=relaxed/simple; bh=J0ZnMTdKI+bJR4+i+w7RZK7tewJ2r9YqMGStqETuOD8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tjYfZP8cn/OnU8jTko/J2LyE7xYbXkD67vcVn9lfAT10fKmINo6ACmgrgtW2Ua92dTGqQWWz3drlH4sO7Jf1+fXDvTq1Ly0AFBdVPk0McTv97TNWw6ZhiIj1sIGSM86EQUo3ij8euc681+/bellhEX7Ym8yTN639in0l0Lqjvzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enneenne.com; spf=pass smtp.mailfrom=enneenne.com; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b=Pqo0PHpq; arc=none smtp.client-ip=62.149.156.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=enneenne.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enneenne.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="Pqo0PHpq" Received: from [192.168.0.189] ([109.118.83.103]) by Aruba SMTP with ESMTPSA id x58WveIugtpTfx58Yvc0fg; Mon, 02 Mar 2026 16:24:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1772465092; bh=J0ZnMTdKI+bJR4+i+w7RZK7tewJ2r9YqMGStqETuOD8=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=Pqo0PHpq9QOjaDm0PN0pbi9RXkfA2e941C4FCttI9W6aGPMCnHt5Gbiw05M5yNmrm OLQtH7ZnFe4M/LuLYkHIPCqy4k9j8BVUS9T7rnIBZAryMffuav2V1ixpsRcICXkVES DhKcYPi7JI5xKS9Bfetjyy/yQdnT9L4dfX2KKzTNwtrJIaUcnR77+QdfIglpzihTSZ xRSshbatAHrfSpmszZtJD2zv/SIWhia13Sb5+zAFp8NiVcu19kGNOS2+xCxBqxLpWT 8QxWoczLxqg2ymC3KNvOKG6DcRxlJNe+hb0nZQ7a3+lHjgT53xuevNSrhUQI3h5IoN LuXQStEptdoAw== Message-ID: <196781d0-5d92-4b5d-b863-780609147f5b@enneenne.com> Date: Mon, 2 Mar 2026 16:24:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pps: change pps_class to a const struct Content-Language: en-US To: Jori Koolstra , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman References: <20260302151132.3302993-1-jkoolstra@xs4all.nl> From: Rodolfo Giometti In-Reply-To: <20260302151132.3302993-1-jkoolstra@xs4all.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfM9oYkxsX4erVn5xKI+i41qQHJkq0yMu0WkcgsfSTnJNsgj/M5WMrXU5REdlnlFhw62uqf5SmwT9tvk8uFUYNZ85CKRjpAIybY/ZAPu9O1hBwqHuyCY0 FYqQbOZxLfkIEFn0eoCwIdZU6g3aAADf+F4ouNXK0Gte4dEekn4Y7YbOoXD9CVdWiLYGQLQvdQQZ5tL36MdkMFw9Ce2QVbrPSfX3lMxb/+/ApvryIsDrJYQM GFF3b0kCpIFdmozTtGmNfzQI518LmECGP1mk7s6hdws= On 3/2/26 16:11, Jori Koolstra wrote: > The class_create() call has been deprecated in favor of class_register() > as the driver core now allows for a struct class to be in read-only > memory. Change pps_class to be a const struct class and drop the > class_create() call. > > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Jori Koolstra Acked-by: Rodolfo Giometti > --- > drivers/pps/pps.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/drivers/pps/pps.c b/drivers/pps/pps.c > index c6b8b6478276..de1122bb69ea 100644 > --- a/drivers/pps/pps.c > +++ b/drivers/pps/pps.c > @@ -26,7 +26,10 @@ > */ > > static int pps_major; > -static struct class *pps_class; > +static const struct class pps_class = { > + .name = "pps", > + .dev_groups = pps_groups > +}; > > static DEFINE_MUTEX(pps_idr_lock); > static DEFINE_IDR(pps_idr); > @@ -379,7 +382,7 @@ int pps_register_cdev(struct pps_device *pps) > } > pps->id = err; > > - pps->dev.class = pps_class; > + pps->dev.class = &pps_class; > pps->dev.parent = pps->info.dev; > pps->dev.devt = MKDEV(pps_major, pps->id); > dev_set_drvdata(&pps->dev, pps); > @@ -408,7 +411,7 @@ void pps_unregister_cdev(struct pps_device *pps) > { > pr_debug("unregistering pps%d\n", pps->id); > pps->lookup_cookie = NULL; > - device_destroy(pps_class, pps->dev.devt); > + device_destroy(&pps_class, pps->dev.devt); > > /* Now we can release the ID for re-use */ > mutex_lock(&pps_idr_lock); > @@ -460,18 +463,19 @@ EXPORT_SYMBOL(pps_lookup_dev); > > static void __exit pps_exit(void) > { > - class_destroy(pps_class); > + class_unregister(&pps_class); > __unregister_chrdev(pps_major, 0, PPS_MAX_SOURCES, "pps"); > } > > static int __init pps_init(void) > { > - pps_class = class_create("pps"); > - if (IS_ERR(pps_class)) { > - pr_err("failed to allocate class\n"); > - return PTR_ERR(pps_class); > + int err; > + > + err = class_register(&pps_class); > + if (err) { > + pr_err("failed to register class\n"); > + return err; > } > - pps_class->dev_groups = pps_groups; > > pps_major = __register_chrdev(0, 0, PPS_MAX_SOURCES, "pps", > &pps_cdev_fops); > @@ -487,7 +491,7 @@ static int __init pps_init(void) > return 0; > > remove_class: > - class_destroy(pps_class); > + class_unregister(&pps_class); > return pps_major; > } > > > base-commit: d466c332e106fe666d1e2f5a24d08e308bebbfa1 -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming