From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <srinivas.kandagatla@linaro.org>
ARC-Seal: i=1; a=rsa-sha256; t=1525422258; cv=none;
        d=google.com; s=arc-20160816;
        b=PQzG/rS9jWh1N/DeNguVe2kFckG4MuOjN5n/t8jw2lis22LyFdVlGYhbsIX1Ki0Mng
         SksqliRxXZVgm9e3b+L7EBybFGwVQjDiB2LAiI5vSq1/yktsporT6g/kQ89641yeTcoJ
         8yOm6Gg8X/zD5+hkVLuB+I1zmu8GuGa8cOAyWD4Xm3SITqSa9xgm6EM+85I1nN2IUXnT
         Vbfw38k11K7iLM4mFnbkr7hADc2xp83LhbU4C/jtqWfKsx4y4kYg40AaQO0Hfp4zM31P
         t3ooQtcj4n2Ogtj55uLXSK67LUsIcSdFwNYeeBzIaqdIrt2aUeeCNOz4RSS5RvEnCgph
         r1UA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:content-language:in-reply-to:mime-version
         :user-agent:date:message-id:from:references:cc:to:subject
         :dkim-signature:arc-authentication-results;
        bh=OyKJLr+kOfs3EYteNku65oVbKNb42VH8zsYCQGGKqgk=;
        b=sFtFA/pzaU2NOj5lTrZqqOkwQ5FZHb5UuEaLhvChA7gERVvKmDDogKelbxFAQwYMHR
         C8Vn05nyq0BJ8lBcnZgazFQpREhFJZMqrcTozeYzlGP2GT+ltmrH2+4ICNoUcZwWvxhh
         5obw94iGZcqveEIlamK7FrssxCbodLnBR4YKGBiA5494ZUwhROzMB9dL3dzAzsYFoQpA
         r+j4tiuyTjgtqqDZjyiXcBWlPDbSU4vtPEeXdL8caufA7Jg9ep1ZtVVaun3buc9+mRTv
         vYFSO0D+XKSG3X+e2OCCJrYVOZB2KPYIFuoAeJbj2qtVaTNQe2wxEFthVrFZ8fKs2y6s
         qCSA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=IsTmGZup;
       spf=pass (google.com: domain of srinivas.kandagatla@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=srinivas.kandagatla@linaro.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=IsTmGZup;
       spf=pass (google.com: domain of srinivas.kandagatla@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=srinivas.kandagatla@linaro.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
X-Google-Smtp-Source: AB8JxZoEDLDurKnboX+dlQA5pHHel1nUwY3Vj0dK5tXgBJiT7QqkX5pkdv1JU2yPP6RdecawLRAIFw==
Subject: Re: [alsa-devel] [PATCH v7 16/24] ASoC: qdsp6: q6asm: Add support to
 audio stream apis
To: Rohit Kumar <rohitkr@codeaurora.org>, andy.gross@linaro.org,
 broonie@kernel.org, linux-arm-msm@vger.kernel.org,
 alsa-devel@alsa-project.org, robh+dt@kernel.org, bgoswami@codeaurora.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
 rohkumar@qti.qualcomm.com, gregkh@linuxfoundation.org, plai@codeaurora.org,
 tiwai@suse.com, lgirdwood@gmail.com, david.brown@linaro.org,
 linux-arm-kernel@lists.infradead.org, spatakok@qti.qualcomm.com,
 linux-kernel@vger.kernel.org
References: <20180501120820.11016-1-srinivas.kandagatla@linaro.org>
 <20180501120820.11016-17-srinivas.kandagatla@linaro.org>
 <f3b3d90b-6504-328e-c9f4-a3b3f085d9dc@codeaurora.org>
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <196824c5-2b0c-1f1b-edd9-0ba6e82ac0f7@linaro.org>
Date: Fri, 4 May 2018 09:24:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <f3b3d90b-6504-328e-c9f4-a3b3f085d9dc@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1599263628693117168?=
X-GMAIL-MSGID: =?utf-8?q?1599521169949127684?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

Thanks Rohit for testing this!


On 04/05/18 08:11, Rohit Kumar wrote:
> 
> 
> On 5/1/2018 5:38 PM, Srinivas Kandagatla wrote:
>> +static int __q6asm_run(struct audio_client *ac, uint32_t flags,
>> +          uint32_t msw_ts, uint32_t lsw_ts, bool wait)
>> +{
>> +    struct asm_session_cmd_run_v2 *run;
>> +    struct apr_pkt *pkt;
>> +    int pkt_size, rc;
>> +    void *p;
>> +
>> +    pkt_size = APR_HDR_SIZE + sizeof(*run);
>> +    p = kzalloc(pkt_size, GFP_KERNEL);
> Should be GFP_ATOMIC as this API is also called from interrupt context

Yes, these should be a GFP_ATOMIC, Will fix this up in next version.

thanks,
srini

>> +    if (!p)
>> +        return -ENOMEM;
>> +
> [..]
>> +int q6asm_read(struct audio_client *ac)
>> +{
>> +    struct asm_data_cmd_read_v2 *read;
>> +    struct audio_port_data *port;
>> +    struct audio_buffer *ab;
>> +    struct apr_pkt *pkt;
>> +    int pkt_size;
>> +    int rc = 0;
>> +    void *p;
>> +
>> +    if (!(ac->io_mode & ASM_SYNC_IO_MODE))
>> +        return 0;
>> +
>> +    pkt_size = APR_HDR_SIZE + sizeof(*read);
>> +    p = kzalloc(pkt_size, GFP_KERNEL);
> same here. GFP_ATOMIC
>> +    if (!p)
>> +        return -ENOMEM;
> [..]
>> +int q6asm_write_async(struct audio_client *ac, uint32_t len, uint32_t 
>> msw_ts,
>> +               uint32_t lsw_ts, uint32_t flags)
>> +{
>> +    struct asm_data_cmd_write_v2 *write;
>> +    struct audio_port_data *port;
>> +    struct audio_buffer *ab;
>> +    struct apr_pkt *pkt;
>> +    int pkt_size;
>> +    int rc = 0;
>> +    void *p;
>> +
>> +    pkt_size = APR_HDR_SIZE + sizeof(*write);
>> +    p = kzalloc(pkt_size, GFP_KERNEL);
> GFP_ATOMIC
>> +    if (!p)
>> +        return -ENOMEM;
>>
> Thanks,
> Rohit
>