From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 539C832AAB8 for ; Thu, 8 Jan 2026 06:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767854550; cv=none; b=nn6TCQK1yWUxvNU5IwsPmyOH4eKrvd6qebJ5nnd4iyfVQPpK5xmsqCrFi9A0HmJmcdqtXva8amfsSQFOiZZrpytmZ3Pz2eH0vYJjX/uI/4a9VMZDVVzqpdtu8r1Ufub2fAxeasGgSdlDtW/W0a3j1j5l2oMJpb5C/nidvnby1m8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767854550; c=relaxed/simple; bh=gjY9ZKn8AerPInOiDxILLNSmV+KOCcEfYN2pjsDhsqU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AbraZZsMf/xAOz/Jo7RLgeXwJeMKE2PyAke+6aTxv/h0yXsp2HmYrE9gJU9b5AoKbIaru4ttMk9CmybGZgactphex2BuOaWq8yVPdh+YHAnt5XH6dvc/CCn2isxrqtmr/R+OD4HT33Rz6WZholjikg+J2WV1xoIXLL6c3rSexmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QKhnNDBN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M8t85zK2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QKhnNDBN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M8t85zK2" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6084nsoZ2454297 for ; Thu, 8 Jan 2026 06:42:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R0HL95ihOA9A0q4vhcsR+DDHK/KRkyUqp/m1FXpo87I=; b=QKhnNDBN9kV34WFr rdpYxIJE8Uq8tARAF734Y+13k6u76CdN+/DVscaKDwDm7SIt76Bb2Hv8MdwK6ATe bP6pF0akP1Z0IBg/rD9VYnwIbM6K4yp9v4Po2S9Gxa6HyyzLjMm/pn7pQmiBs7zo s+2F1Ttt34k4/A5/HXgWK7IShhyreF2lkeC6RzSSof/379YCQlZU3wVs7PieElTq 2yjrfKz01c0KMUKBl11LLw71H6atUfhdnB3ghODVMJ0JPu05OKcIfTJsaP7bZQwh 0rcEWhH3sWHnONHr3gXKm7lM8h3BtKB4ouQFWjiI7BZc3Tai97F9CamOICPq3++5 nuH+Jw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhmnbknp8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Jan 2026 06:42:20 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0fe4ade9eso31886645ad.0 for ; Wed, 07 Jan 2026 22:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767854540; x=1768459340; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R0HL95ihOA9A0q4vhcsR+DDHK/KRkyUqp/m1FXpo87I=; b=M8t85zK2wEGdY61/WlWyP9BNOkZ+u8D3VxxUTw2+vuXVmFuGOfqpAgcIYZMwMsTcqi OsOEJ6v+mS4idiKqim3oxmxnOHjZ+K2hC9ZTBLDqgEqtwGVe33m62S+u93HOKRcCCnxO 35PhguxfDmGFtJ/ooIGh4XW79FP+v1VGHc2ePD8eRpbjjzJ5KwleOVknsa9CxWMo8PyQ ln2RE5nQl6KvRy9gaCGzK2kz3qbSLl8b3mHMpc9UreKkKqDCM/ZR6PrtHoNapmIy8k5n EUpSyzuUwvG2J6jp45kHZ4/EnMhVRxyFrscJ4gNAEM2e+Ri6wsqjQ+qzNn6MPB/vlkXh rtLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767854540; x=1768459340; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R0HL95ihOA9A0q4vhcsR+DDHK/KRkyUqp/m1FXpo87I=; b=olG38qIFA4IVtoUn5VzeqBOrIeCo7RUOOcSKV8DD0WrRscXlDUq0GP38BbQ1DYeDnS 13d1wEsMs9nZr8Jg4v9aHzaz0RlaVpovju47egrZ7xrWHLsZhxFuK/dl4gBeALFJhUyY Jzl3dfqJhFRaCkN0SwyKxhy2VcY2etQ2ddR/bNyTSRRNWsv7XYIMjNdx+TSyIQlGMzRr eH7mx3ZNJQsMOEwHvNgzNqhe1jzt90BIDMAhLXWcQOI2ZfHDUh0VHi2WbCcTAA1Aw/IH CXLuZwksFUbaKIPycudSagyvmUbxVWBamvEMkJAWoP+9FjBnAfrB+ZQPYazP3GpNq1om ZkOA== X-Forwarded-Encrypted: i=1; AJvYcCXJ0IblH1471vo0ziWJVs74CwBXosI8U5ZNNpleByHY+Pyyhy8MkjUqOKEEKpn8najS17+7+MKUqlvA5TM=@vger.kernel.org X-Gm-Message-State: AOJu0YwealTCku/LU7CysgGdOwbhuMU4+Jkk4f2H/NIt+zH4G8v12Lme GnKMHL5SZ0nId5o2YQhsz8N8o0KVdxB25pQZUBJAgQnMULSVh5V6mQ2J3a4zrdVlwVAaRrAQ7es S0PotuKSjbNUN+s3yxicfgQ0AjekOjCUIIaQrJ4AzfeqJUSvoWV+rEtZM1c3ZR1vrcUU= X-Gm-Gg: AY/fxX5bPFBj4y2/l1LTnv9S8DWGS+a6b2U6Td0vG4hGqrMiliEffLUKOm4BJq8DkfH WHvygMbMmHcf6mGKbolPkzPWdxopgYRbgWmoqWCQQ6JKLCjP9l5NdbuggCWrR+B8aFlSNFuMqQG MZ3tqwy6s+NV2QBYnVtOzlxGHgwlOenSJ4MbKisPJ+1yYSUC7gaCvL58eCTyRiDZqFKDb9cN1qx S6g+Dh2so8bDF5QbOgrMC3RAH5dc65ZGRk5AnVLKC5OofwR5QVBE5Q+E5zbA0CaCdk0varMJNqw CidARNrS/f3OHx5IDm7k5av06jT/olk6t5JBZJUO5t54fjdFyU/eR93jBT1VHukaqdJAYbrcZbZ CUP7zNt0JpN6PwD+pGnLfIn9EGlp7Mgile8fozqwWyxE4cp1mIwOgMHVvFZUsnKHnGxBECbimrK c= X-Received: by 2002:a17:903:2291:b0:2a2:d2e8:9f25 with SMTP id d9443c01a7336-2a3ee47f0a8mr48295345ad.33.1767854540235; Wed, 07 Jan 2026 22:42:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7M+L6O5fEzMSPTGxFCu18f1uj4PsDXgMaJwRJ81d5LiIm1cAmxdvtAeQNQJeQcqh+4t1ljw== X-Received: by 2002:a17:903:2291:b0:2a2:d2e8:9f25 with SMTP id d9443c01a7336-2a3ee47f0a8mr48295015ad.33.1767854539759; Wed, 07 Jan 2026 22:42:19 -0800 (PST) Received: from [10.133.33.102] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc8803sm67804025ad.71.2026.01.07.22.42.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 22:42:19 -0800 (PST) Message-ID: <196858fc-e425-4cc0-a4b8-94a0ff4e512d@oss.qualcomm.com> Date: Thu, 8 Jan 2026 14:42:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] clk: qcom: cmnpll: Account for reference clock divider To: George Moussalem , Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Luo Jie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_pavir@quicinc.com, quic_suruchia@quicinc.com References: <20260106-qcom_ipq5332_cmnpll-v2-0-f9f7e4efbd79@oss.qualcomm.com> <20260106-qcom_ipq5332_cmnpll-v2-1-f9f7e4efbd79@oss.qualcomm.com> Content-Language: en-US From: Jie Luo In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDA0MiBTYWx0ZWRfX5R44dCPIZPeV /04HOttEsNJF2saoBrcKvwuVkPsB2THcu+QwXlPPQgas2LqK0bEreypq46Mfd+s21+4L2i3DtP2 Xo+Sly7zG01Zrn8K8R6EQy9Vpt0xvxqoW4isZxRExDmRo6IWLfUteuZ4ZQ9tNA/TIPccSiBKqzI Zoe2YXKnJ+gaW2EQbuilfSZZLhO+qUul6eTXfk81tzaKqXPJL7MdXSAcnihfm0f/Ozlc/uK0uI2 AwFoG7dftGYHuroFlg7SGfT0gYBwvBo7S+uO3YnF0dtHuFdRLYOmRN5mIapMkiy2x3xSzczMvzD XCRWTap+92Sur5yBlueGWaqnNzNM0tCERG1ovpVDvgnWdc7aAKfFjHf+mz+ltafKQ1O1XgoxZ74 Qt1j7EvzhDzb49PRNZRLiK+8CTFw2d+CqOhMdMp7GcAGU1cspnl3M+5wng6tkJAEmvHsU1w/FoZ QiiYMcWPgxulZat5fJA== X-Proofpoint-GUID: CGV_3Aikx71bdIU-LE-HTQgjhFlInCaJ X-Authority-Analysis: v=2.4 cv=eIkeTXp1 c=1 sm=1 tr=0 ts=695f51cc cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=NVhx1d5adPAbhb5xwd0A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: CGV_3Aikx71bdIU-LE-HTQgjhFlInCaJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-08_01,2026-01-07_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601080042 On 1/7/2026 9:17 PM, George Moussalem wrote: >> Read CMN_PLL_REFCLK_DIV and divide the parent rate by this value before >> applying the 2 * FACTOR scaling. This yields the correct rate calculation: >> rate = (parent_rate / ref_div) * 2 * factor. >> >> Maintain backward compatibility with earlier platforms (e.g. IPQ9574, >> IPQ5424, IPQ5018) that use ref_div = 1. > Just tested this patch and can confirm IPQ5018 also has a ref_div of 2. > With this patch applied, the correct assigned clock rate of 4.8GHz is > also reported: > > root@OpenWrt:~# cat /sys/kernel/debug/clk/clk_summary | grep cmn -A 3 -B 3 > > deviceless > no_connection_id > xo-clk 1 1 0 48000000 > 0 0 50000 Y deviceless > no_connection_id > ref-96mhz-clk 1 1 0 96000000 > 0 0 50000 Y deviceless > no_connection_id > cmn_pll 0 0 0 > 4800000000 0 0 50000 Y deviceless > no_connection_id > eth-50mhz 0 0 0 50000000 > 0 0 50000 Y deviceless > no_connection_id > sleep-32khz 0 0 0 32000 > 0 0 50000 Y deviceless > no_connection_id > xo-24mhz 0 0 0 24000000 > 0 0 50000 Y deviceless > no_connection_id > > Once accepted, I will submit a patch to correct the assigned clock rate > from 9.6GHz to 4.8GHz as the ref div is now properly applied. Thanks for validating this on the IPQ5018 platform.