From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39144C4363A for ; Mon, 19 Oct 2020 15:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE59222284 for ; Mon, 19 Oct 2020 15:47:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="GKPSIti2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730379AbgJSPrZ (ORCPT ); Mon, 19 Oct 2020 11:47:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730051AbgJSPrX (ORCPT ); Mon, 19 Oct 2020 11:47:23 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 996A5C0613D0 for ; Mon, 19 Oct 2020 08:47:23 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id t25so14529823ejd.13 for ; Mon, 19 Oct 2020 08:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/7dlTxDiqmcYkSqeqEAM+MSSzQMjAQV5ACnbOJwdXNY=; b=GKPSIti2Z/Los0GUsvzfd9b0pNWNRyk+Tp6tSJGWcodh0ZDS5rAPvU9/PP5UueYRae LTe0tyMpJZyGoqqmLOhvPZy7dgX7XgwaPENmWQhJzDi6QF5n3X0R7Y7EncbENJsahSSY ZFR77cCmsWF4Hc0odVeXoQVhNHFRhLdTFzeO2VpDnVX0zQdA2e6uoOj+nDFJjmMveApN IdVippUwlK0s6VWNuDj31K2HTeVxFujFVrJZh6VXowRdg9iptmvk++8Exj3X9Yj3eH1j qrqELC1FidYtjTsia++6v1J8QNZ0iNkUqdGzrSXlK9xy3Aul39YiNzJa3CtjIjFCv7qw 3GSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/7dlTxDiqmcYkSqeqEAM+MSSzQMjAQV5ACnbOJwdXNY=; b=PXTlfEfKxVgy65k4+G5slwCwW+UJd5d5BnIzVLhP3p0u/KUZnGmGr2O+vZUu1zaEIK oCER9dlP4x+zeD5Me334M1QrnorzpZ0mXzNgJySzKk8SUMpUt8dkp6aRysKo82cYXBDl oEHimmCGyS0sYqN2BPdOAAnuu+kHDideE6osCa+9OCYYaIaNvJCSh/T7AfOCCNT8ThrI Ksiu6BM4+Nu2cSRtHj/NHcsuz53TiGrlh26qJsJdx1rtrVvCiSbsWxEnKs1gdtbCletL 88g/n5gteLaQTW/tbx6dtQKF2roiE1X4NJvGlFPMW6HB23h1eo6PAyqbovKfwYDr8WuJ a/lQ== X-Gm-Message-State: AOAM530sMVH89HIDxv3ksz3pdO5vmQ8jdTlHpDjyo5+arleQrh3j86Kn HJpCaw1tY2QgZ8i+zw71toWaankK+D6/6sAE X-Google-Smtp-Source: ABdhPJz5DJFN2XyIY0pHmL87n5yVNzMdfSg5FjUwur2ImOFkINOE9kNC92wznoRr9FRqBrJlnjZFAw== X-Received: by 2002:a17:906:453:: with SMTP id e19mr489674eja.391.1603122441874; Mon, 19 Oct 2020 08:47:21 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([2a02:578:85b0:e00:b49:2ba2:dca5:18d2]) by smtp.gmail.com with ESMTPSA id i23sm499558eja.66.2020.10.19.08.47.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2020 08:47:21 -0700 (PDT) To: Geert Uytterhoeven , Paolo Abeni , Mat Martineau , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org References: <20201019113240.11516-1-geert@linux-m68k.org> From: Matthieu Baerts Subject: Re: [PATCH] mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it Message-ID: <1968b7a6-a553-c882-c386-4b4fde2d7a87@tessares.net> Date: Mon, 19 Oct 2020 17:47:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201019113240.11516-1-geert@linux-m68k.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the patch! On 19/10/2020 13:32, Geert Uytterhoeven wrote: > MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature the > user may not want to enable. Fix this by making the test depend on > MPTCP instead. I think the initial intension was to select MPTCP to have an easy way to enable all KUnit tests. We imitated what was and is still done in fs/ext4/Kconfig. But it probably makes sense to depend on MPTCP instead of selecting it. So that's fine for me. But then please also send a patch to ext4 maintainer to do the same there. Reviewed-by: Matthieu Baerts Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net