From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F38745FFAD; Thu, 10 Sep 2026 11:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789038006; cv=none; b=jGaVmpqBxAyLLxdPgNCSYi9PzqX9yrYuhBz32n7Yy/Hnh5kIyVoDhaIzvycViSWz/ajnO9D/+KsDNJQ37AVqqgf+GZpW4SDyU3f7MYGNJUIHaIYhc0JXorY/Chg1p3wPfUaX8mF0WVCaDXIbGr+vMbTnvn1OWvIscfTy7LjXkEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789038006; c=relaxed/simple; bh=VxopizQOt9Z5PoBJpdv/MLPT4QTThIOGxEH8whjbAzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DXxs1uSPPXkAt3Ogy1YuOKFl67XEhDtM8HIbq1KSNvwuAasePuYpwZLHwwkaKkpAW/+TUSKbSJDiHioYX61TIByWjAYPsu292U6DqgFEXSQ4NiAcaQQYt1kxxkr2m9gfsYwrgBUA48cQT7ARtyxxJMdUNTPh2Hjjfdlgyk0eZVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RBAs3Dyk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RBAs3Dyk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17FF61F00893; Thu, 10 Sep 2026 10:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789038003; bh=Hr7oGdsTn1ApVbMUVv7wZOuEszEEdCdnleGoKRCPC4A=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=RBAs3DykizAcG6ccbF6gR4FjdvFtoyTxL249sbCZidqesp6sH12kPXM/tt7h3mk5h a7G+BA0Riez4Yz1i+7+NWWHOSDF6NRMPVUmfhaWxQrYwrijylDKKZ6Zf4BHpDXS+dw UAFOcP1gvZZ1LZxxniwWgllm8b2aKj5uFVekfs0QSQt6FbU7GlINbsQgBudFwAKiVn wkMq4PpoloKMGJ0kkVmo7tsy0WVi+I+uWej7sLKehznfsaURRslpTA87qpu/3tBA5G hh4RObF7dmSlftszEMXOL2oEX1bVpvXafwKWXIXWkeIx/IjtR2/P8GyHV4HEWRLA/j 2rdKXX6tvmn+Q== Message-ID: <1968ed37-3836-44df-a266-9a37219c2f6f@kernel.org> Date: Thu, 10 Sep 2026 12:59:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] kselftest: mm: replace usage of /proc/self/smaps for check_huge_xxx() helper To: Yeoreum Yun Cc: Andrew Morton , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Kevin Brodsky , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260907-fix_split-v5-0-822b810458bc@arm.com> <20260907-fix_split-v5-2-822b810458bc@arm.com> <956df69d-8c0a-420f-889e-7df2842605dc@kernel.org> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/10/26 12:54, Yeoreum Yun wrote: >> On 9/7/26 10:19, Yeoreum Yun wrote: >>> Since glibc commit 321e1fc73f (“malloc: Enable 2MB THP by default on AArch64”), >>> glibc may call madvise(MADV_HUGEPAGE) for sufficiently large allocations >>> made by memalign(). >>> >>> The underlying VMA may start at a different address from the aligned >>> address returned by memalign(). Furthermore, a subsequent >>> madvise(MADV_HUGEPAGE) call does not split the VMA because the flag is >>> already set. >>> >>> This causes split_huge_page_test to fail because the check_huge_xxx() >>> helpers incorrectly require the address returned by memalign() to >>> match the VMA start address reported in /proc/self/smaps. >>> >>> Instead of relying on /proc/self/smaps, use /proc/self/pagemap and >>> /proc/kpageflags to detect huge-page mappings and large folios: >>> >>> 1. If hpage_size == pmd_pagesize, check PAGE_IS_HUGE instead of >>> using check_large_folios(), since only the mapping type matters. >>> This identifies PMD-mapped huge pages. >>> 2. Otherwise, use check_large_folios() to detect large folios. This >>> covers mTHP cases. >>> 3. Check the folio flags according to the type of huge page. >>> >>> Suggested-by: David Hildenbrand (Arm) >>> Suggested-by: Zi Yan >>> Reviewed-by: Zi Yan >>> Reviewed-by: Baolin Wang >>> Tested-by: Baolin Wang >>> Acked-by: Lorenzo Stoakes (ARM) >>> Signed-off-by: Yeoreum Yun >>> --- >>> tools/testing/selftests/mm/vm_util.c | 145 ++++++++++++++++++++++------------- >>> tools/testing/selftests/mm/vm_util.h | 1 + >>> 2 files changed, 92 insertions(+), 54 deletions(-) >>> >>> diff --git a/tools/testing/selftests/mm/vm_util.c b/tools/testing/selftests/mm/vm_util.c >>> index 4821a3563036..dc62ce84e143 100644 >> >> [...] >> >>> >>> - if (hpage_size == pmd_pagesize) >>> - return __check_pmd_huge(addr, "AnonHugePages: ", nr_hpages, hpage_size); >>> +static bool check_huge_type(uint64_t categories, uint64_t kpageflags, >>> + enum check_huge_type type) >>> +{ >>> + const bool file = categories & PAGE_IS_FILE; >>> + const bool swapbacked = kpageflags & KPF_SWAPBACKED; >>> + >>> + switch (type) { >>> + case CHECK_HUGE_ANON: >>> + return !file; >>> + case CHECK_HUGE_FILE: >>> + return file && !swapbacked; >>> + case CHECK_HUGE_SHMEM: >>> + return file & swapbacked; >>> + } >> >> Why do we even need CHECK_HUGE_SHMEM? >> >> That's really just a legacy thing for using smaps to identify huge pages. >> >> It's sufficient to identify CHECK_HUGE_FILE if you know that you have shmem mapping. >> >> You will not arbitrarily have non-shmem folios in a shmem mapping :) > > Agree. but there seems the case where discern whethr the mapping is > with regular file or shmem like tmpfs -- khugepaged test where using > __shmem_ops. So I think it would be better to keep this as-is. Let's not add or maintain unnecessary complexity. hmem_check_huge can really just become check_huge_file. Even file_check_huge can just be simplified. There must be a pretty good reason why we'd want to keep this. -- Cheers, David