From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B7AEB64DD for ; Fri, 23 Jun 2023 09:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbjFWJJK (ORCPT ); Fri, 23 Jun 2023 05:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbjFWJJH (ORCPT ); Fri, 23 Jun 2023 05:09:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35B35213B for ; Fri, 23 Jun 2023 02:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687511306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t296XX7Ide+MxH8Ui7MMhn8jUrjQ4TRebXX4EzAUHEE=; b=eTQzKWoVx/IO3t90ZZVxjew/tTNqKBJ2sd984krbapBsgQ7BQqmVzzbunhaOEgyF9idT4Y QvSDP5PG0fEcZJu19EgFkK8rjf6THIg+p6Fb7vijTfuzOXS83avcM8g7hcGdJjnG8d5Eag wO4OBrI7OT8TqCHiwwhKoqDKlqQ/GR8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-157-u4jdwn5dMhqzFVv4305B2A-1; Fri, 23 Jun 2023 05:08:22 -0400 X-MC-Unique: u4jdwn5dMhqzFVv4305B2A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 35F118CC202; Fri, 23 Jun 2023 09:08:21 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80F51492C13; Fri, 23 Jun 2023 09:08:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230622191134.54d5cb0b@kernel.org> References: <20230622191134.54d5cb0b@kernel.org> <20230622132835.3c4e38ea@kernel.org> <20230622111234.23aadd87@kernel.org> <20230620145338.1300897-1-dhowells@redhat.com> <20230620145338.1300897-2-dhowells@redhat.com> <1952674.1687462843@warthog.procyon.org.uk> <1958077.1687474471@warthog.procyon.org.uk> To: Jakub Kicinski Cc: dhowells@redhat.com, Eric Dumazet , netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Menglong Dong Subject: Re: [PATCH net-next v3 01/18] net: Copy slab data for sendmsg(MSG_SPLICE_PAGES) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1969747.1687511298.1@warthog.procyon.org.uk> Date: Fri, 23 Jun 2023 10:08:18 +0100 Message-ID: <1969749.1687511298@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jakub Kicinski wrote: > If we can't reach instant agreement -- > can you strategically separate out the minimal set of changes required > to just kill MSG_SENDPAGE_NOTLAST. IMHO it's worth getting that into > 6.5. Paolo Abeni wrote: > Given all the above, and the late stage of the current devel cycle, > would you consider slicing down this series to just kill > MSG_SENDPAGE_NOTLAST, as Jakub suggested? I could do that. There is also another alternative. I could just push the sendpage wrappers up the stack into the higher-level callers. Basically this: int udp_sendpage(struct sock *sk, struct page *page, int offset, size_t size, int flags) { struct bio_vec bvec; struct msghdr msg = { .msg_flags = flags | MSG_SPLICE_PAGES }; if (flags & MSG_SENDPAGE_NOTLAST) msg.msg_flags |= MSG_MORE; bvec_set_page(&bvec, page, size, offset); iov_iter_bvec(&msg.msg_iter, ITER_SOURCE, &bvec, 1, size); return udp_sendmsg(sk, &msg, size); } and kill off sendpage and MSG_SENDPAGE_NOTLAST. David