mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Jonathan Cameron <jic23@kernel.org>, Andreas Klinger <ak@it-klinger.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, mripard@kernel.org,
	shawnguo@kernel.org, heiko@sntech.de, icenowy@aosc.io,
	laurent.pinchart@ideasonboard.com, knaack.h@gmx.de,
	lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
	christophe.jaillet@wanadoo.fr, tglx@linutronix.de,
	mchehab+samsung@kernel.org, davem@davemloft.net,
	paulmck@linux.ibm.com, devicetree@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] iio: ping: add parallax ping sensors
Date: Wed, 13 Nov 2019 12:09:43 +0100	[thread overview]
Message-ID: <196ba1f0-9d9f-9f46-c86e-2c41a7835c59@ysoft.com> (raw)
In-Reply-To: <20191110170650.00527b8b@archlinux>

On 10. 11. 19 18:06, Jonathan Cameron wrote:
> On Thu, 7 Nov 2019 14:00:47 +0100
> Andreas Klinger <ak@it-klinger.de> wrote:
  
[snip]

>> + *
>> + *          +---+            +------------------------+
>> + * GPIO     |   |            |                        |
>> + * ping:  --+   +------------+                        +----------------
>> + *          ^   ^            ^                        ^
>> + *          |<->|            interrupt                interrupt
>> + *         udelay(5)         (ts_rising)              (ts_falling)
>> + *                           |<---------------------->|
>> + *                           .  pulse time measured
>> + *                           .  --> one round trip of ultra sonic waves
>> + *                           .                        .
>> + * ultra           +-+ +-+ +-+                        .
>> + * sonic           | | | | | |                        .
>> + * burst: ---------+ +-+ +-+ +-----------------------------------------
>> + *                                                    .
>> + * ultra                                    +-+ +-+ +-+
>> + * sonic                                    | | | | | |
>> + * echo:  ----------------------------------+ +-+ +-+ +----------------
> 
> Nice diagram ;)

Using the '+' characters at the edges and '-' characters for levels makes it
not easily readable in some cases. Especially for the short subsequent bursts.
What about this?

      * GPIO      ___              ________________________
      * ping:  __/   \____________/                        \_________________
      *          ^   ^            ^                        ^
      *          |<->|            interrupt                interrupt
      *         udelay(5)         (ts_rising)              (ts_falling)
      *                           |<---------------------->|
      *                           .  pulse time measured
      *                           .  --> one round trip of ultra sonic waves
      *                           .                        .
      * ultra                     .                        .
      * sonic            _   _   _.                        .
      * burst:  ________/ \_/ \_/ \_________________________________________
      *                                                    .
      * ultra                                              .
      * sonic                                     _   _   _.
      * echo:   _________________________________/ \_/ \_/ \_________________
      */

Michal

      reply	other threads:[~2019-11-13 11:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 13:00 Andreas Klinger
2019-11-10 17:06 ` Jonathan Cameron
2019-11-13 11:09   ` Michal Vokáč [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=196ba1f0-9d9f-9f46-c86e-2c41a7835c59@ysoft.com \
    --to=michal.vokac@ysoft.com \
    --cc=ak@it-klinger.de \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=icenowy@aosc.io \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=mripard@kernel.org \
    --cc=paulmck@linux.ibm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®