From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874F736196A for ; Wed, 5 Aug 2026 16:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785947877; cv=none; b=DjKgoH/M971c+rCgSxMczRxVpbf0I0mVdSU5QDRvfBrVybCu3XgydTHEa75/EMddcxbQLT8dxlk1BfINtYk99XN3OY2qHTJTg2mSJ/8NYOdouKC2YotaMJdu35cxv09Ou7VMdV8cR/HuhZxxWJ6ElMqYz2iZSEFh0AwuJbklHQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785947877; c=relaxed/simple; bh=8+2PylqWNZrDsBe0yH710HlQGVqpY2LoeL2x1geD5HI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uR/9fVXjmeueBWfZjL9PIDpfAHnHBGrNbqnqSeh7WfBeIC41ORIE7f4Odp6W+XfmyNYD20xLdvXGqsn1rGFh0rgP4idXCzyM303CDYVKMOQp7svwllbON7aQNCU+mlqz97Xt0RXrFgiKdj2jfuEOFaNHly6wvMHEaj8cSR8mGp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E/q1PROb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j/m+PpQG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E/q1PROb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j/m+PpQG" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 675FVTeV303082 for ; Wed, 5 Aug 2026 16:37:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WdGxg9qUyCSflIvbg1X6LXTFMLPukJPalp2YGPQ7aHY=; b=E/q1PRObfw/N3Rsi BwqWsOC7t+FK8Xhiu7LCUSSo+vxTvUEjlxklV7MbfhIoszyWrskLy+nocoXXRFHu AJJ54d+LaReUw+XU163W1YYf1D38ZJfLcoxSZ0VcmEDyj+szGXpwPJHrcV6zT0Cp H+zYFB8TNymNKLQLrFVopvUw4SYZBdjUYmkvtfC71pfvXqHCvQVucK44IdPPPCTX JWW+dz4Mi3Fb7CsOHERAJ/sPSoG0AToDBBU1JSylq/Qz6xj0qdzsO5Aly4AighZI dxuOVCEq7Lwi5pwnAInwd0aN2GnbNdHvJYlUOrtOWXd6Iz2C77lRJqfXQGauzu9i iqBNZA== Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fuu3ukxsa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 05 Aug 2026 16:37:55 +0000 (GMT) Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-4a442461e63so236858b6e.3 for ; Wed, 05 Aug 2026 09:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785947875; x=1786552675; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WdGxg9qUyCSflIvbg1X6LXTFMLPukJPalp2YGPQ7aHY=; b=j/m+PpQGVYZJbfT9Ar6o5Agx0zjf4LXWSBnzLxDotz7hqQQ80hVelD8w4ZMmyj1pw7 ZGE/NvC4F/4EhNg3M1QfLJRoo563hskUPrNJoo8Xytq0EfJ6tEtGutL0OXaxIiSvIdqV E/5cAwkQwywRNVI7QMjkJ4cTCcNO3Z2UBSfdJiyj6Kqnb0F4o9KUCOPBJllyogaEiH4y jus1C4/vYZyj3UOJYiTIu5Ica//QG7SWycj/tU5VGBnq2FDzmCuJcsZZxmIvEoBcOAUu AeGsvMla/ujGNAuecPQRlrcDoPIsQQ4q1kpAbx0OB6uYCi6gOvSn/ZVD1aBO2Kp/Yd0e IBpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785947875; x=1786552675; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WdGxg9qUyCSflIvbg1X6LXTFMLPukJPalp2YGPQ7aHY=; b=TbDYFJ+G+oIDAM/4xy3MvI3q26XD6PVvrAFnS2R0xhAkTZKh0Z1CgGNEk7sQe1T5g/ 6b7OVOKszazuPJGvdnWnOZ5a+yXg08v7h4ujDGeL47xvsZxWFJovrS/BEkc1dloSNnNT 6Jg5SJpO0XC9B8f+lqhOhN4P8F/NxrKxXOSXjFJlvqe91j5lTDK2EvsP9JD4CbIkTmq6 KI59J2+0zI6ekVVq5D3Fne+fiZzB/qHAkE2yY+gySN9vLNac8u6bv6muhlq+8r87vyia 8U8Hpz+p7eL2colqs3DHOPIBvO7+fx1gOKVLO1SGmr7louiXTWJVVoobAP5e+dcDKQ9f Z2gw== X-Forwarded-Encrypted: i=1; AHgh+RquOmAaJLN0JosxxtkhwfFxJZVDAUqcvZbyVXMLNngk4h2+h1hMuDEmyvS7pfH4DBB6hxlPioiybPFpol0=@vger.kernel.org X-Gm-Message-State: AOJu0YyIooHy21oSaHkijUGF+gOhPhpoYvHACeQ1O0yW43Ksv2KK+4nF OfK8x4NFfFzNaFlzVl7eyowBIBtPWD1dtLNFNHB6kk+8OsrvMWKQgJ0zQXumvQzVgFNxDq82MM7 kH1AO1zOwP9qRCvkdll+ez4jFVnjFNBXAZVdcG+hMO1lA49OOhJJcpmhLL+5dvioqmPo= X-Gm-Gg: AR+sD10L0VEYMqj0EX09FB0jnzexaHethEMblVY5AEVwas+YhSA1RrLN+Met1XSPhyp mk0NrhmvVpz58np9P2MTCTVagj0ujicmJQ7VYmA8zm7/TSpXxfhO8+aC9MP065RmIeV07vIdOG/ lYQLA/QOUC4c938vG3rUD9h5CVaLOo2Wk91jQmD7wg1f1goDVdIKrx+CByvB3ZSrMPsGUfEzo1Z RIekTcqZ4Iuu1TujZsvhizVqBeDP0fjl8X9hUbbiixH4nfoUMyLJ4YsdVh9EtASp1ocx1LmsYu5 jtWa0BWhCXsLUKs5oIb5dqrKmCS4T/daehEF9rsAZPt7j4mt9q9k2Y7X1sbX3CRytR96skRvkhr b/2HeMvU5KFNwiYzeXwJP6hO4RKiJwzarWkCUsc4eB/6d1Xbako63fEnyedF11g== X-Received: by 2002:a05:6808:1588:b0:4af:5d69:1cb8 with SMTP id 5614622812f47-4afadbf4d3amr2748589b6e.0.1785947874719; Wed, 05 Aug 2026 09:37:54 -0700 (PDT) X-Received: by 2002:a05:6808:1588:b0:4af:5d69:1cb8 with SMTP id 5614622812f47-4afadbf4d3amr2748569b6e.0.1785947874259; Wed, 05 Aug 2026 09:37:54 -0700 (PDT) Received: from [10.110.6.162] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4afae458389sm2360760b6e.2.2026.08.05.09.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 09:37:54 -0700 (PDT) Message-ID: <196c4ff1-bf93-4c56-8d9a-4b00c6b3924c@oss.qualcomm.com> Date: Wed, 5 Aug 2026 09:37:52 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] media: v4l2-core: Add support for video encoder ROI control To: Bryan O'Donoghue , Mauro Carvalho Chehab , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel test robot References: <20260804-enc_roi_enable-v3-0-e03b622a2d48@oss.qualcomm.com> <20260804-enc_roi_enable-v3-2-e03b622a2d48@oss.qualcomm.com> <3cb31ce1-bb06-4202-aeb6-8e8437e57085@kernel.org> Content-Language: en-US From: Deepa Guthyappa Madivalara In-Reply-To: <3cb31ce1-bb06-4202-aeb6-8e8437e57085@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODA1MDEzNSBTYWx0ZWRfX6PeLR0WLqFAX C8UrqEpIL7BgGiklp+H3IWHwscgpJtWl93I3uYnVJYF5rhZXVH1EgTTBrhryMVEBDRzF4UYjKDP 8X3YE765Tim765LOTgrT03SkhIgJqm0= X-Proofpoint-GUID: 8nfpPvblFRqwO-9b4uZO31cZuqxQQ4hH X-Authority-Analysis: v=2.4 cv=B5aJFutM c=1 sm=1 tr=0 ts=6a7366e3 cx=c_pps a=WJcna6AvsNCxL/DJwPP1KA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=T4rr7CIfql8Qit_6xdcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Y9Zt4tPzoBS9L09Snn2:22 X-Proofpoint-ORIG-GUID: 8nfpPvblFRqwO-9b4uZO31cZuqxQQ4hH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA1MDEzNSBTYWx0ZWRfX23ctVn0Ls7hh xFdFqyQJeqnGSvotAhWdiEtseHq7B2pYVZTL+fbjpTlP485kj11DHNyP88VNgJS9HWswXmCj5Ob 62wgwDppwzwYkYRw7+68fe7RyNKs91WKT0SCHXFiSXGUJbNkmwq2M//cStMUTPyPQ/sEWadijij uFLUrUt3sIrOFKac+m+7EY77tQs/rQ8MJ2H0q0tIINcCCRt74WOHBlwyamLHRft/z/tswJWQAEU JxfXxRn7bt0DVsi6HHJAfZJFW+dMiNG3PCkMaI8lgzh0fh8yFkSeDlRb5cPXG24DQCewfLemYE8 WXIRlYKJsFE70L4ExUncaM+DDdgF9DVjixuN8PjQrzTVzMw6nWaIU1fBfWLe9LTMKrC/sS2JkfO W5K/DBbX7rHSM4YOpmE/MIDHzZWnv2x/xks0ecUVPiuZUt1LdV1oRkFTHIdxjUkV72z3Fz3cmmy HoAxf79DSEQh8CPyr+w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_05,2026-08-04_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 phishscore=0 impostorscore=0 clxscore=1015 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608050135 On 8/4/2026 8:51 PM, Bryan O'Donoghue wrote: > On 04/08/2026 21:05, Deepa Guthyappa Madivalara wrote: >> @@ -1588,6 +1606,7 @@ void cur_to_new(struct v4l2_ctrl *ctrl) >>           return; >>       if (ctrl->is_dyn_array) >>           ctrl->new_elems = ctrl->elems; >> + >>       ptr_to_ptr(ctrl, ctrl->p_cur, ctrl->p_new, ctrl->new_elems); >>   } >> >> @@ -2030,6 +2049,9 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct >> v4l2_ctrl_handler *hdl, >>       case V4L2_CTRL_TYPE_U32: >>           elem_size = sizeof(u32); >>           break; >> +    case V4L2_CTRL_TYPE_S8: >> +        elem_size = sizeof(s8); >> +        break; >>       case V4L2_CTRL_TYPE_MPEG2_SEQUENCE: >>           elem_size = sizeof(struct v4l2_ctrl_mpeg2_sequence); >>           break; >> @@ -2247,7 +2269,6 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct >> v4l2_ctrl_handler *hdl, >> >>       if (flags & V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX) { >>           void *ptr = ctrl->p_def.p; >> - >>           if (p_min.p_const) { >>               ptr += elem_size; >>               ctrl->p_min.p = ptr; > > You're adding and subtracting newlines here in code you otherwise > aren't touching. > > --- > bod > ack, will fix this in v4