From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753306AbcKEFvC (ORCPT ); Sat, 5 Nov 2016 01:51:02 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:37646 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbcKEFte (ORCPT ); Sat, 5 Nov 2016 01:49:34 -0400 Subject: Re: [PATCH] phy-rockchip-pcie: remove deassert of phy_rst from exit callback To: Heiko Stuebner , Shawn Lin References: <1476333733-9696-1-git-send-email-shawn.lin@rock-chips.com> <2348307.ygIaYT7LcH@phil> CC: , , Jeffy Chen , Wenrui Li , Brian Norris From: Kishon Vijay Abraham I Message-ID: <196d1fd0-bcc6-a866-cf90-1623f213ce66@ti.com> Date: Sat, 5 Nov 2016 11:18:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <2348307.ygIaYT7LcH@phil> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 28 October 2016 02:01 PM, Heiko Stuebner wrote: > Am Donnerstag, 13. Oktober 2016, 12:42:13 CEST schrieb Shawn Lin: >> The deassert of phy_rst from exit callback is incorrect as when >> doing phy_exit, we expect the phy_rst is on asserted state which was >> done by power_off callback, but not deasserted state. Meanwhile when >> disabling clk_pciephy_ref, the assert/deassert signal can't actually >> take effect on the phy. So let's fix it anyway. >> >> Signed-off-by: Shawn Lin > > looks ok to have that removed, as any future phy_init call will make sure it > gets asserted anyway. > > Reviewed-by: Heiko Stuebner merged, thanks. -Kishon >