From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754182AbbKWJNk (ORCPT ); Mon, 23 Nov 2015 04:13:40 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:34014 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753901AbbKWJNg (ORCPT ); Mon, 23 Nov 2015 04:13:36 -0500 X-AuditID: cbfee68f-f79666d0000076bb-d5-5652d8bec42d Date: Mon, 23 Nov 2015 09:13:34 +0000 (GMT) From: MyungJoo Ham Subject: Re: Re: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device To: Chanwoo Choi Cc: =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20151123090834266@myungjoo.ham Msgkey: 20151123090834266@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20151123090834266@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <1970403923.135851448270013777.JavaMail.weblogic@epmlwas06a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkSHffjaAwg6mnJS0u75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAlfGziXXmAr28FUcnf6DvYGxg6+LkZNDSEBdYtGSk2wgtoSAicTb da/YIWwxiQv31rNB1CxllNg6pQamZs7lNqAaLqD4HEaJ739OgTWwCKhK7JnbwNLFyMHBJqAn MfNzMkhYWCBO4vvkk4wgtgjQruZnqxlBepkFDjNKvNhzhhligZLEmn2vWEBsXgFBiZMzn7BA LFOVmL17IVRcTaJ552kmiLi4xIW5l6AO5ZWY0f4Uql5OYtrXNcwQtrTE+VkbGGGeWfz9MVSc X+LY7R1QcwQkpp45CFWjJTHl+1qoOXwSaxa+ZYGp33VqOTPMrvtb5kL1SkhsbXnCCmIzCyhK TOl+yA7yO7OApsT6XfroXuEV8JC48+0XC8jvEgITOSQuTljBPoFRaRaSullIRs1CGIWsZAEj yypG0dSC5ILipPQiY73ixNzi0rx0veT83E2MwLRw+t+z/h2Mdw9YH2IU4GBU4uHV1A8KE2JN LCuuzD3EaAqMpYnMUqLJ+cDkk1cSb2hsZmRhamJqbGRuaaYkzrtQ6mewkEB6YklqdmpqQWpR fFFpTmrxIUYmDk6pBsYFNvVXba4tZulb+HCrU+hidvaVRZwmPrb/J8j5PN0ZPift45mrwZF7 9tU2LJR3lpJrW7H6eG2alNQZ3fNxp8uqs7+7ai5w+7p/5kt+tQcXXol4zH4UzSTi8L7l8RW/ JRbecbsO7Lw/VaI+V/zJ7HlSwk+lTh0QZ5y/MvPYgxOisbLbM24t49yqxFKckWioxVxUnAgA YKSRywYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKKsWRmVeSWpSXmKPExsVy+t/tPt19N4LCDO7uEbW4vGsOmwOjx+dN cgGMUWk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBD lRTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2StGG5kZ6RgZ6pkZ6hsaxVoYGBkamQDUJaRk7 l1xjKtjDV3F0+g/2BsYOvi5GTg4hAXWJRUtOsoHYEgImEnMut7FD2GISF+6tB4pzAdXMYZT4 /ucUWIJFQFViz9wGli5GDg42AT2JmZ+TQcLCAnES3yefZASxRYBmNj9bzQjSyyxwmFHixZ4z zBDLlCTW7HvFAmLzCghKnJz5hAVimarE7N0LoeJqEs07TzNBxMUlLsy9BHUQr8SM9qdQ9XIS 076uYYawpSXOz9rACHP04u+PoeL8Esdu74CaIyAx9cxBqBotiSnf10LN4ZNYs/AtC0z9rlPL mWF23d8yF6pXQmJryxNWEJtZQFFiSvdDdpDfmQU0Jdbv0kf3Cq+Ah8Sdb79YJjDKzkKSmoWk exZCN7KSBYwsqxhFUwuSC4qT0iuM9YoTc4tL89L1kvNzNzGCk9CzxTsY/5+3PsQowMGoxMOr oR8UJsSaWFZcmXuIUYKDWUmE98hWoBBvSmJlVWpRfnxRaU5q8SFGU2CcTWSWEk3OBybIvJJ4 Q2NjEzMTU0sTCwNTcyVx3tv7/MKEBNITS1KzU1MLUotg+pg4OKUaGGvk75b4pbBExzOL3e1x +h4d+kjgIm9rXtn6vx8jn9hEXbFX5AvKXm/NZvXlfGnjnq7oU4xd/29se736aBLfwb+PlXOX n29h27COmfnrknSJuDv61VLLJH1PTZuqY7Nul07N+V//5qmteZm9poH36+r34n/fJ/hdyu15 XP1J6JHJ74lmCQwhc5VYijMSDbWYi4oTAQL4HGRYAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAN9Dkh7011124 > On Mon, Nov 23, 2015 at 4:21 PM, MyungJoo Ham wrote: > > [] > >> > > >> > The value 0 is used for min/max_freq to declare > >> > that min/max_freq is deactivated. Therefore, it is not > >> > required to do so; they are not intended to show the hardware > >> > configuration as well. > >> > >> This case consider the devfreq device using OPP because devfreq_set_freq_table() > >> get the number of OPP entry in OPP list before setting the min_freq/max_freq. > >> If the devfreq device don't use the OPP entry, devfreq_set_freq_table() > >> will return without any operation. > >> > >> IMHO, when devfreq device uses the OPP table including the frequency, > >> min_freq/max_freq should show the correct value as CPUFREQ framework. > >> > > > > The side effect of this patch shows up when opp_disable() and opp_enable() > > are used. > > Ah. You're right. > I was not considering the the case of using opp_disable() and opp_enable(). > I'll consider it again including the usage case of opp_diable/opp_enable. > Even without the side effect, what would be the meaning of initializing min/max-freq to the device min/max capabilities when the users may override it with arbitrary lower/higher values? Cheers, MyungJoo ps. you will be one or two floors away from my office next week. :) {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I