From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751496AbdALLTz (ORCPT ); Thu, 12 Jan 2017 06:19:55 -0500 Received: from mail.eperm.de ([89.247.134.16]:55460 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbdALLTx (ORCPT ); Thu, 12 Jan 2017 06:19:53 -0500 From: Stephan =?ISO-8859-1?Q?M=FCller?= To: George Cherian Cc: George Cherian , herbert@gondor.apana.org.au, davem@davemloft.net, david.daney@cavium.com, clabbe.montjoie@gmail.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v4 2/3] drivers: crypto: Add the Virtual Function driver for CPT Date: Thu, 12 Jan 2017 12:19:38 +0100 Message-ID: <1970611.axXSiX4HVh@positron.chronox.de> User-Agent: KMail/5.3.3 (Linux/4.8.16-300.fc25.x86_64; KDE/5.29.0; x86_64; ; ) In-Reply-To: <58776428.1060308@caviumnetworks.com> References: <1484132211-917-1-git-send-email-george.cherian@cavium.com> <1522639.tMShRcNLPc@positron.chronox.de> <58776428.1060308@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 12. Januar 2017, 16:40:32 CET schrieb George Cherian: Hi George, > > > > Sure, please do not forget to invoke xts_verify_key. > > Should I be using xts_check_key or xts_verify_key? Both are identical except for the input parameter -- the one requires crypto_skcipher, the other crypto_tfm. Depending what pointer you have handy in your setkey function, you would use the most appropriate one. Ciao Stephan