From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751644AbdL2RXb (ORCPT ); Fri, 29 Dec 2017 12:23:31 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:62747 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbdL2RX2 (ORCPT ); Fri, 29 Dec 2017 12:23:28 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171229172326epoutp027e0e8198acec77841f4309d2bd6f0a8d~E08JxHew21023710237epoutp02z X-AuditID: b6c32a39-e27ff700000010dd-09-5a467a0d45e4 From: Bartlomiej Zolnierkiewicz To: Johan Hovold Cc: Nicolas Ferre , Alexandre Belloni , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable , Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH] video: fbdev: atmel_lcdfb: fix display-timings lookup Date: Fri, 29 Dec 2017 18:23:23 +0100 Message-id: <1971311.3PN1zRAlXO@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20171113102719.9634-1-johan@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplleLIzCtJLcpLzFFi42LZdlhTV5e3yi3K4NAfc4uOa4uZLK58fc9m 0XSjh9XiRN8HVovLu+awWWzfvJDZYt3DF0wWCzY+YnTg8Hiy6SKjx6sLd1g8Nq3qZPO4332c yePOj6WMHp83yQWwRXHZpKTmZJalFunbJXBlPDl6gr3gFVtF560dTA2MJ1i7GDk5JARMJOZ+ 6GTpYuTiEBLYwSix5OoZZgjnO6PEsW9XmWCq3mxqZYNI7GaUePCsCcr5yijx/eAcdpAqNgEr iYntqxi7GDk4RASUJaa8EQSpYRZYwSTx+c0jsBphAS+Jpe17mUFqWARUJR5s8AEJ8wpoSqw8 /xnsJFGgki372sEWcwqYSqw4eYwZokZQ4sfkeywgNrOAvMS+/VNZIWwdibPH1jGC7JIQuMwm 8W7mPHaIq10kJv6+BGULS7w6voUdZK+EgLTEpaO2EOHpjBLbf0tA9G5mlFi1ewJUvbXE4eMX oRbwSbz72sMK0csr0dEmBFHiIbFy4zVoMDpKPDy2iRUSJh2MEhPuT2GcwCg7C8nds5DcPQvJ 3QsYmVcxiqUWFOempxYbFpjqFSfmFpfmpesl5+duYgQnDi3LHYzHzvkcYhTgYFTi4eVId40S Yk0sK67MPcQowcGsJMLLEOQWJcSbklhZlVqUH19UmpNafIhRmoNFSZw3IMAlSkggPbEkNTs1 tSC1CCbLxMEp1cAY3OxqcvTHn9exWRcTPjiKx3Qs5VB7tKK1tsA96PUU91BtttfyrRMtnqzm 33lWLNj0TlDqVxHJDFUb1rNv76gdEq94vYX7UI5EfKcnix3TlLOTIo23bhZQPOk2WWaS9AH/ rT0ePrsnn2XpZD1hc1zH0fYk15LS7d7zLyTUxSTcebM6LWel80wlluKMREMt5qLiRACbNdES GAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t9jAV3eKrcogzsvVC06ri1msrjy9T2b RdONHlaLE30fWC0u75rDZrF980Jmi3UPXzBZLNj4iNGBw+PJpouMHq8u3GHx2LSqk83jfvdx Jo87P5YyenzeJBfAFsVlk5Kak1mWWqRvl8CV8eToCfaCV2wVnbd2MDUwnmDtYuTkkBAwkXiz qZWti5GLQ0hgJ6NEQ+sbFgjnK6PEojO32UCq2ASsJCa2r2LsYuTgEBFQlpjyRhCkhllgBZPE rn+3mUBqhAW8JJa272UGqWERUJV4sMEHJMwroCmx8vxnsGWiQCVb9rWDlXMKmEqsOHmMGWJX F6PEsulr2SAaBCV+TL7HAmIzC8hL7Ns/lRXC1pJYv/M40wRG/llIymYhKZuFpGwBI/MqRsnU guLc9NxiowLDvNRyveLE3OLSvHS95PzcTYzAUN92WKtvB+P9JfGHGAU4GJV4eDnSXaOEWBPL iitzDzFKcDArifAyBLlFCfGmJFZWpRblxxeV5qQWH2KU5mBREue9nXcsUkggPbEkNTs1tSC1 CCbLxMEp1cAoX+Szf6rABZEVnZ5NM19ZRXVPu/2wYGXdc5mtZ7uzPzFtq7pczV4puDo8f/6a dwt2ct9SZVGX6e1yLd52tXtqGo9azcRTZWazpukd1Mm+wHey4G/Za21xZZuvrelvXn1rP3rL 8HPgvSjryMqXXGsVTvLc/qTRMC9i/bF1c1N1v8i8ubTLL85EiaU4I9FQi7moOBEAqSXLBHEC AAA= X-CMS-MailID: 20171229172325epcas1p39458c1d6da512dde6d80f3ef23a4e057 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171113102758epcas2p433e3d361b93e9030ffe53a2c65268d38 X-RootMTR: 20171113102758epcas2p433e3d361b93e9030ffe53a2c65268d38 References: <20171113102719.9634-1-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 13, 2017 11:27:19 AM Johan Hovold wrote: > Fix child-node lookup during probe, which ended up searching the whole > device tree depth-first starting at the parent rather than just matching > on its children. > > To make things worse, the parent display node was also prematurely > freed. > > Note that the display and timings node references are never put after a > successful dt-initialisation so the nodes would leak on later probe > deferrals and on driver unbind. > > Fixes: b985172b328a ("video: atmel_lcdfb: add device tree suport") > Cc: stable # 3.13 > Cc: Jean-Christophe PLAGNIOL-VILLARD > Signed-off-by: Johan Hovold Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics