From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbbJOIkM (ORCPT ); Thu, 15 Oct 2015 04:40:12 -0400 Received: from mout.gmx.net ([212.227.15.18]:64814 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbbJOIkH (ORCPT ); Thu, 15 Oct 2015 04:40:07 -0400 From: Marc Dietrich To: Dan Carpenter , gregkh@linuxfoundation.org, linux-tegra@vger.kernel.org Cc: Sakshi Bansal , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: nvec: fixed few coding style warnings Date: Thu, 15 Oct 2015 10:39:02 +0200 Message-ID: <1971511.Ec7FdKlGRN@fb07-iapwap2> User-Agent: KMail/4.14.10 (Linux/4.2.1-1-desktop; KDE/4.14.10; x86_64; ; ) In-Reply-To: <20151014181236.GX7340@mwanda> References: <20151014140822.GA23114@localhost.localdomain> <20151014181236.GX7340@mwanda> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1500583.9d3drafbiy"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:FbmnOH1vnM6yiPfL0TiDIMIy1fw46KkoG1pVDfiBf/o2piLibm6 UMdQWHEBlS+9uysAE8M37JvpW2AxQcCUtQ2vx5X2cUHkLLPM2pT5/4JVfzyH3AkDkrD1Xpu l20RGiQosPMTAzAunOuoT6RuMRG8hZtDc+q8WmTyWePDQLsQnA68O0XUhM6GTCVn8J1c5MN ejDw9JuYc2bkATHkgdOtA== X-UI-Out-Filterresults: notjunk:1;V01:K0:rHMBff8+q1c=:rLSedSnBl/cYIV5fZkiXNB hHHhVbbos8FNklCvJGQ3njtY1YkrGXGJ0Ji7h1ElW5CYnP6qT46EHQNp6FeynfKlpFILC3zeU ExRD0BiZ7AkE//qoKMMR1W8t/tttSnTt1nlr6Pq+Fkd8ECe5OUWBpLMIJFMk09/q/Gj+YuLo6 ep+Cj8QcKiiXKh6A1QkBn+7tmwiASE65jwZQj0IThpb5MW5tKwaGN52pjgmTbIvGT8D9e1asY IDzdw6jHcClJ6nfm5F1B0b8dKGF9UxdkurmwF4mC108rcfLU0OJpLTIzb7EKqkwVbsA3fF6Wj a0J6E38K3XFXpSUTD+KtjXB7SJ0S5UiLGcq+DWnY8ODxMKK1rBl/KfRkPdko8DqWOLRjLGQu4 /wCxC8vavSsDZesYWx/M1gIoTQsWGjoaKlcPrTX232gezdrpnuLWRhIEoNIxY30WJJcCW2W/d EZhHXhRGpu1pjKCHebXBMREN0CLGLRGXtlppNLXRT7yhbA5yRQo8T75qjDlt++EMC75qRc5tz LEZH8oNmfkBCGA6RKIzUrFQZ25k/uCBQaKdXIUqU4D4irOvQAJZhFD6B9xJRy2Q5Z2gB8ls45 WIPo6hhvTzhOeXXwNt6z4AcwkElUe+DomRs35BS5yDxgGqgcujqs+i6ySTvfHQ5dKXsk8aqqN mhdKJ+QVrYfEeGwCtG45d+E+ctqNrmOJlIpqJQFkHuI49zO0k9v1GM9NPHHtxcLlZpzMEL973 +yO3vLN/K8Vihw2XBvqOumHvdZCEbUIYip+xW5I6UHFuIe9CnNNeC3Td++A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1500583.9d3drafbiy Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Mittwoch, 14. Oktober 2015, 21:12:36 schrieb Dan Carpenter: > On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote: > > Fixed allignmnet issues and block comments usage > > Split it apart by type of fix. > > > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) > > > > } else { > > > > nvec->rx = nvec_msg_alloc(nvec, NVEC_MSG_RX); > > /* Should not happen in a normal world */ > > > > - if (unlikely(nvec->rx == NULL)) { > > + if (!unlikely(nvec->rx)) { > > This isn't right. You intented to say: > > if (unlikely(!nvec->rx)) { > > But even better to just remove the unlikely entirely. > > if (!nvec->rx) { why? the "unlikely" is there to optimize a critical interrupt path. Marc --nextPart1500583.9d3drafbiy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJWH2YmAAoJEKyeR39HFBtolPgIAIkJL+K+midjxPnhyzUrVKJD eAbjGo566cRR1KV9sV7/ormHRxW2OPMeilIW4uJB33hF08sDGxfiCBKekPkTHB8h KRfmY5CiZqcA2NJRYp1lIX1gBybYwyIHkhuAullMi/5ixm5GV9cSiqBybMkW2sni M4PuDLw7BaX+DDfiVTbI4Y+q4LEy1rvtEHfvofvIc27gQfb2fV5MCeaH6lZ6KV7h WWUy8+xl51WV1BfHIhHIEkI6paDf1yCHu+74QrckzLX42aANwdgiDD3UhD33kTS4 RecwQUN+eo2BE/fFLcpBSB/YRn93GoVGiaByLWQW2nxrFg4y99PNBkHEjlnQbD4= =xrvC -----END PGP SIGNATURE----- --nextPart1500583.9d3drafbiy--