mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Chen <me@linux.beauty>
To: "Thomas Gleixner" <tglx@linutronix.de>
Cc: "Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"x86" <x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"K Prateek Nayak" <kprateek.nayak@amd.com>,
	"Sohil Mehta" <sohil.mehta@intel.com>,
	"Brian Gerst" <brgerst@gmail.com>,
	"Patryk Wlazlyn" <patryk.wlazlyn@linux.intel.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
	"Li Chen" <chenl311@chinatelecom.cn>
Subject: Re: [PATCH 2/2] x86/smpboot: avoid SMT domain attach/destroy if SMT is not enabled
Date: Tue, 24 Jun 2025 22:02:08 +0800	[thread overview]
Message-ID: <197a23f047d.1095ea2d92028509.1160531071010499395@linux.beauty> (raw)
In-Reply-To: <875xglntx1.ffs@tglx>

Hi Thomas. 

 ---- On Tue, 24 Jun 2025 21:36:10 +0800  Thomas Gleixner <tglx@linutronix.de> wrote --- 
 > On Tue, Jun 24 2025 at 16:08, Li Chen wrote:
 > > From: Li Chen <chenl311@chinatelecom.cn>
 > >
 > > Currently, the SMT domain is added into sched_domain_topology
 > > by default if CONFIG_SCHED_SMT is enabled.
 > >
 > > If cpu_attach_domain finds that the CPU SMT domain’s cpumask_weight
 > 
 > If cpu_attach_domain()
 > 
 > IIRC, I told you that before.
 > 
 > > is just 1, it will destroy_sched_domain it.
 > >
 > > On a large machine, such as one with 512 cores, this results in
 > > 512 redundant domain attach/destroy operations.
 > >
 > > We can avoid these unnecessary operations by simply checking
 > 
 > s/We can avoid/Avoid/
 > 
 > Care to read my reviews? If you disagree, then discuss it with me, but

I'm sorry that I forget to say that your previous wording review have already been fixed in v2 https://lore.kernel.org/all/20250624085559.69436-3-me@linux.beauty/

And I would replace cpu_attach_domain with cpu_attach_domain().

Sorry for wasting your time. 

 > silently ignoring it them is not an option.
 > 
 > > cpu_smt_num_threads and not inserting SMT domain into x86_topology if SMT
 > 
 > not inserting? That's not what this new version does.
 > 
 > > +static void __init maybe_remove_smt_level(void)
 > > +{
 > > +    if (cpu_smt_num_threads <= 1) {
 > > +        /*
 > > +         * SMT level is x86_topology[0].  Shift the array left by one,
 > > +         * keep the sentinel { NULL } at the end.
 > > +         */
 > > +        memmove(&x86_topology[0], &x86_topology[1],
 > > +            sizeof(x86_topology) - sizeof(x86_topology[0]));
 > > +        memset(&x86_topology[ARRAY_SIZE(x86_topology) - 1], 0,
 > > +               sizeof(x86_topology[0]));
 > 
 > So this sets the last entry in the array, aka the original sentinel in
 > the last array entry, to zero...
 > 
 > This is completely pointless. The above memmove() copies
 > 
 >     topo[1 .. (N - 1)] 
 > to
 >     topo[0 .. (N - 2)]
 > 
 > Where N = ARRAY_SIZE(topo).
 > 
 > Therefore
 >         topo[N - 1] == NULL
 > and
 >         topo[N - 2] == NULL
 > 
 > No?
 > 
 > But then what's worse is that you fail to take that removal into account
 > for the x86_has_numa_in_package case, which still unconditionally sets
 > topo[N - 2] to zero even if the SMT level had been removed...
 > 
 > Please take your time and do not rush out half baked stuff.
 
Sorry again for my mistake. I will fix it in v3.

Regards,
Li

      reply	other threads:[~2025-06-24 14:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24  8:08 [PATCH 0/2] x86/smpboot: tidy sched-topology and drop useless SMT level Li Chen
2025-06-24  8:08 ` [PATCH 1/2] x86/smpboot: Decrapify build_sched_topology() Li Chen
2025-06-24  8:08 ` [PATCH 2/2] x86/smpboot: avoid SMT domain attach/destroy if SMT is not enabled Li Chen
2025-06-24 13:36   ` Thomas Gleixner
2025-06-24 14:02     ` Li Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=197a23f047d.1095ea2d92028509.1160531071010499395@linux.beauty \
    --to=me@linux.beauty \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=chenl311@chinatelecom.cn \
    --cc=dave.hansen@linux.intel.com \
    --cc=gautham.shenoy@amd.com \
    --cc=hpa@zytor.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=patryk.wlazlyn@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®