From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932687AbbI2Hnf (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 03:43:35 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:60197 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755800AbbI2Hn0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 03:43:26 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: David Daney <ddaney.cavm@gmail.com>, linux-kernel@vger.kernel.org,
        Will Deacon <will.deacon@arm.com>, Marc Zyngier <marc.zyngier@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        "Sean O. Stalley" <sean.stalley@intel.com>,
        David Daney <david.daney@cavium.com>
Subject: Re: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs.
Date: Tue, 29 Sep 2015 09:42:48 +0200
Message-ID: <1981236.3bSkWiA8PH@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1443488184-12633-1-git-send-email-ddaney.cavm@gmail.com>
References: <1443488184-12633-1-git-send-email-ddaney.cavm@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:JtBSseyQdSyaNMT7JFluJK8+xPzW59FR2FnnqLWafUakeXTz3ex
 tVcPJrGINVKIFJTbFmx8Db/dESuMYtvWBLrffVnsu9H/hhvC/u4mSbwpTmSXB255NgxvvUT
 CYURT6Qy+ALBB6hqt0f6KMAylGg4sjkkj0A/eUm1OT5tIwxdd0jlIrz60qcaJVpBrWrbFXC
 EsCd2lmKe3jBtsorzycsw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:yGzEUm97ewU=:aQKhVV7TPGAVl45CARw7Aa
 2zSiJjG//afjguSugcCCO4WkgjB8VOo/xzdga6QBTXwUINBGGjnNAPc+SJK6a4ykQvFiKu/iG
 5FokqBVg6OeAH7tR9GVR3OGSaw4ffTvD8dDYLwbRq+R7OTiioEKuHyOCiVquyI5U8L0e+5Fez
 RBxFe2siPziH3e/cnKxDXm5wjmTdqXqngx9E+hczCyDrvGvP/IpYdwQsnd1AFa0BnB18XLoOx
 leTN1zXb+haGhXdffNn4d9b8Mz+TPz/j8NAQ6GWXOQUcabS91fpYLiMFzTzLJghl4rPFLWeC7
 TtwzCvg9zcvwNeRsHasfeAVbzccGVf3y5aXhmj1zmm2+gWBq61+GzLEz8cmhOFEdGk6F7j64t
 OvvS3GiNSBwhxDp2g7jckFVGm4UjGE7obxeIuY7CztKJUcckHMK4szZsbrAK1wStvy58PKTSw
 6EalF0/k5SwFUxsH4TdUzFgOJA6hsTdA7teZHatjJaLHW1O12HCw3we7fLLUYjdHHa4Z0PZ5O
 133ZhanwNZOt0JbC923hcMTvPpFRL8lwrRJwf/Xf+J1+UVtpIVm6tdmBMkakW9nm0LyKYGaSa
 eDTwXGST8u1E4Q837vIXK1FCBgzV4IizJRyzvXmXNxc5yULuRT1DDW0wmNpHzA+ZTEq5MOVbK
 lqA8k58oZXUeWKWjDYWeB075+gB9eO1Q6zS3yFpeqeyjlP1bDZ4Pga/Mj9ndk0riskfszkpjn
 y13jXboBjiDZS9dz
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 28 September 2015 17:56:24 David Daney wrote:
> From: David Daney <david.daney@cavium.com>
> 
> Early versions of the Cavium Thunder CN88XX processor are missing
> Enhanced Allocation (EA) capabilities for the fixed BAR addresses used
> by the on-SoC hardware blocks.
> 
> Add config access functions that synthesize the missing EA
> capabilities for versions that are missing that information.  Since
> this is a little hacky, gate the inclusion of the code with a new
> Kconfig variable.
> 
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> 
> As suggested by Bjorn Helgaas...  It is RFC at this point, but this is
> working well for me.

I don't have an opinion on the way you implement the config space
accessors, but it seems that the overall amount of code is comparable
to the normal pci-host-generic driver without this, and it is not
really generic at all.

I think because of this, it makes more sense to have a separate top-level
driver for this and not reuse the pci-host-generic implementation here.

	Arnd