From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will.deacon@arm.com>,
trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL/PATCH] ARM: hw_breakpoint: Fix newlines in WARN messages
Date: Fri, 25 Feb 2011 07:38:23 +0100 [thread overview]
Message-ID: <19815.20063.647326.437650@ipc1.ka-ro> (raw)
In-Reply-To: <1298573739-25144-1-git-send-email-sboyd@codeaurora.org>
Hi,
Stephen Boyd writes:
> These warnings are missing newlines and spaces causing confusing
> looking output when they trigger.
>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> arch/arm/kernel/hw_breakpoint.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
> index d600bd3..5aab00e 100644
> --- a/arch/arm/kernel/hw_breakpoint.c
> +++ b/arch/arm/kernel/hw_breakpoint.c
> @@ -238,8 +238,8 @@ static int enable_monitor_mode(void)
> ARM_DBG_READ(c1, 0, dscr);
>
> /* Ensure that halting mode is disabled. */
> - if (WARN_ONCE(dscr & ARM_DSCR_HDBGEN, "halting debug mode enabled."
> - "Unable to access hardware resources.")) {
> + if (WARN_ONCE(dscr & ARM_DSCR_HDBGEN, "halting debug mode enabled. "
> + "Unable to access hardware resources.\n")) {
>
I'd prefer the message text not to be line wrapped, even if it
violates the general line length rule, because that makes it easier to
grep for the message in the source code.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2011-02-25 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 18:55 Stephen Boyd
2011-02-25 6:38 ` Lothar Waßmann [this message]
2011-02-25 11:31 ` Will Deacon
2011-02-26 4:06 ` [PATCH] ARM: hw_breakpoint: Fix newlines in WARNings Stephen Boyd
2011-03-09 19:36 ` Stephen Boyd
2011-03-09 21:58 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19815.20063.647326.437650@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=trivial@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®