From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DACAC7EE23 for ; Thu, 1 Jun 2023 09:05:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbjFAJEw (ORCPT ); Thu, 1 Jun 2023 05:04:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232587AbjFAJEt (ORCPT ); Thu, 1 Jun 2023 05:04:49 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AD59E50; Thu, 1 Jun 2023 02:04:24 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R681e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0Vk41CPa_1685610190; Received: from 30.221.149.38(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0Vk41CPa_1685610190) by smtp.aliyun-inc.com; Thu, 01 Jun 2023 17:03:11 +0800 Message-ID: <19823e23-cefa-a582-9e59-af0f963aef85@linux.alibaba.com> Date: Thu, 1 Jun 2023 17:03:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 3/7] perf vendor events: Add JSON metrics for CMN To: Ian Rogers Cc: John Garry , Will Deacon , Shuai Xue , Robin Murphy , James Clark , Mike Leach , Leo Yan , Mark Rutland , Ilkka Koskinen , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Zhuo Song References: <1685438374-33287-1-git-send-email-renyu.zj@linux.alibaba.com> <1685438374-33287-4-git-send-email-renyu.zj@linux.alibaba.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/5/31 上午9:18, Ian Rogers 写道: > On Tue, May 30, 2023 at 2:19 AM Jing Zhang wrote: >> >> Add JSON metrics for arm CMN. Currently just add part of CMN PMU >> metrics which are general and compatible for any SoC and CMN-ANY. >> >> Signed-off-by: Jing Zhang >> --- >> .../pmu-events/arch/arm64/arm/cmn/sys/metrics.json | 74 ++++++++++++++++++++++ >> tools/perf/pmu-events/jevents.py | 1 + >> 2 files changed, 75 insertions(+) >> create mode 100644 tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metrics.json >> >> diff --git a/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metrics.json >> new file mode 100644 >> index 0000000..e70ac1a >> --- /dev/null >> +++ b/tools/perf/pmu-events/arch/arm64/arm/cmn/sys/metrics.json >> @@ -0,0 +1,74 @@ >> +[ >> + { >> + "MetricName": "slc_miss_rate", >> + "BriefDescription": "The system level cache miss rate include.", > > Nit, partial sentence? Yes my mistake. > >> + "MetricGroup": "arm_cmn", >> + "MetricExpr": "hnf_cache_miss / hnf_slc_sf_cache_access", >> + "ScaleUnit": "100%", >> + "Unit": "arm_cmn", >> + "Compat": "arm_cmn600;arm_cmn650;arm_cmn700;arm_ci700" >> + }, >> + { >> + "MetricName": "hnf_message_retry_rate", >> + "BriefDescription": "HN-F message retry rate indicates whether a lack of credits is causing the bottlenecks.", >> + "MetricGroup": "arm_cmn", >> + "MetricExpr": "hnf_pocq_retry / hnf_pocq_reqs_recvd", >> + "ScaleUnit": "100%", >> + "Unit": "arm_cmn", >> + "Compat": "arm_cmn600;arm_cmn650;arm_cmn700;arm_ci700" >> + }, >> + { >> + "MetricName": "sf_hit_rate", >> + "BriefDescription": "Snoop filter hit rate can be used to measure the Snoop Filter efficiency.", > > Nit, inconsistent capitalization? Ok, fix it in next version. > >> + "MetricGroup": "arm_cmn", >> + "MetricExpr": "hnf_sf_hit / hnf_slc_sf_cache_access", >> + "ScaleUnit": "100%", >> + "Unit": "arm_cmn", >> + "Compat": "arm_cmn600;arm_cmn650;arm_cmn700;arm_ci700" >> + }, >> + { >> + "MetricName": "mc_message_retry_rate", >> + "BriefDescription": "The memory controller request retries rate indicates whether the memory controller is the bottleneck.", >> + "MetricGroup": "arm_cmn", >> + "MetricExpr": "hnf_mc_retries / hnf_mc_reqs", >> + "ScaleUnit": "100%", >> + "Unit": "arm_cmn", >> + "Compat": "arm_cmn600;arm_cmn650;arm_cmn700;arm_ci700" >> + }, >> + { >> + "MetricName": "rni_actual_read_bandwidth.all", >> + "BriefDescription": "This event measure the actual bandwidth(MB/sec) that RN-I bridge sends to the interconnect.", > > Nit, the MB/sec is in the ScaleUnit so could be dropped here. ok > >> + "MetricGroup": "arm_cmn", >> + "MetricExpr": "rnid_rxdat_flits * 32 / 1e6 / duration_time", >> + "ScaleUnit": "1MB/s", >> + "Unit": "arm_cmn", >> + "Compat": "arm_cmn600;arm_cmn650;arm_cmn700;arm_ci700" >> + }, >> + { >> + "MetricName": "rni_actual_write_bandwidth.all", >> + "BriefDescription": "This event measures the actual write bandwidth(MB/sec) at RN-I bridges.", > > Nit, same thing. ok > >> + "MetricGroup": "arm_cmn", >> + "MetricExpr": "rnid_txdat_flits * 32 / 1e6 / duration_time", >> + "ScaleUnit": "1MB/s", >> + "Unit": "arm_cmn", >> + "Compat": "arm_cmn600;arm_cmn650;arm_cmn700;arm_ci700" >> + }, >> + { >> + "MetricName": "rni_retry_rate", >> + "BriefDescription": "RN-I bridge retry rate indicates whether the memory controller is the bottleneck.", >> + "MetricGroup": "arm_cmn", >> + "MetricExpr": "rnid_txreq_flits_retried / rnid_txreq_flits_total", >> + "ScaleUnit": "100%", >> + "Unit": "arm_cmn", >> + "Compat": "arm_cmn600;arm_cmn650;arm_cmn700;arm_ci700" >> + }, >> + { >> + "MetricName": "sbsx_actual_write_bandwidth.all", >> + "BriefDescription": "sbsx actual write bandwidth(MB/sec).", > > Nit, same thing. > Ok, Thanks Ian.