From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755008Ab3G2UTl (ORCPT ); Mon, 29 Jul 2013 16:19:41 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:46461 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754889Ab3G2UTj (ORCPT ); Mon, 29 Jul 2013 16:19:39 -0400 From: "Rafael J. Wysocki" To: Ben Guthro Cc: Konrad Rzeszutek Wilk , Jan Beulich , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, xen-devel@lists.xen.org, tboot-devel@lists.sourceforge.net, Gang Wei Subject: Re: [PATCH v7 2/3] x86/tboot: Fail extended mode reduced hardware sleep Date: Mon, 29 Jul 2013 22:29:48 +0200 Message-ID: <1982892.4uOzLBL3Sx@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <51F6CE0E.3080807@citrix.com> References: <1375118055-15942-1-git-send-email-benjamin.guthro@citrix.com> <8791139.q8n07ejQ71@vostro.rjw.lan> <51F6CE0E.3080807@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 29, 2013 04:18:22 PM Ben Guthro wrote: > > On 07/29/2013 04:21 PM, Rafael J. Wysocki wrote: > > On Monday, July 29, 2013 01:14:14 PM Ben Guthro wrote: > >> Register for the extended sleep callback from acpi. > >> As tboot currently does not support the reduced hardware sleep > >> interface, fail this extended call. > >> > >> Signed-off-by: Jan Beulich > >> Signed-off-by: Ben Guthro > >> Cc: tboot-devel@lists.sourceforge.net > >> Cc: Gang Wei > >> Reviewed-by: Konrad Rzeszutek Wilk > >> --- > >> arch/x86/kernel/tboot.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c > >> index addf7b5..760f431 100644 > >> --- a/arch/x86/kernel/tboot.c > >> +++ b/arch/x86/kernel/tboot.c > >> @@ -301,6 +301,17 @@ static int tboot_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control) > >> return 0; > >> } > >> > >> +static int tboot_extended_sleep(u8 sleep_state, u32 val_a, u32 val_b) > >> +{ > >> + if (!tboot_enabled()) > >> + return 0; > >> + > >> + pr_warning("tboot is not able to suspend on platforms with" > >> + " reduced hardware sleep (ACPIv5). Please contact" > >> + " tboot-devel@lists.sourceforge.net mailing list."); > >> + return -1; > > > > Please use a meaningful error code here. For example -ENODEV. > > Would AE_NOT_IMPLEMENTED be more appropriate? > > include/acpi/acexcep.h: > #define AE_NOT_IMPLEMENTED EXCEP_ENV (0x000E) This is not an ACPI error. :-) Rafael