From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00574174C for ; Fri, 19 Jul 2024 20:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721419509; cv=none; b=OmtN1hcySv+lWxS1BWJ0DHorAq9SC6ErJQkuaTvDXP0V+KUtBXlO6/SyLW2u+40FRZKzQczV4tr8Ic4anRh3r4yIZibFGqw5PKg4YF7ygnMLTiA8U5gE2MwSL3LxwI8c+5BVXzMxJ4j6noJaMytLemkp32lfyehVIafKA48EbCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721419509; c=relaxed/simple; bh=WlRaYVk8kiuGuIRxThg+drnyJnD/pvFi2Gq6q0mZnlQ=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=c3aNCa6LPwwVp75vddjnLwOuhMKlgWfpf42oUsi//p1KbAaMmXPUPeqcDbSYttn/dqlHQjgEHKHwVnlIMk0pIBtaAxp36QJP+nWfFqHfWu5lwB6bOd4N7zoshv+2i/jf87hbdclAVDTaPOtKTsxa307Uh42leHh3n/Gxv+tGy14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=PM4Iiq6e; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="PM4Iiq6e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1721419493; x=1722024293; i=markus.elfring@web.de; bh=R9jxLflpcSdMk7trtrZDbkZwir57Xu0Y57MmRqddR/4=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=PM4Iiq6eSd4vJzp4Jw9V6V+qFDpXKebHRP/9HabT5bfiGzqLoMjs+lHMuLvIYPOu 6G3HgPI6P2Dyav/pckM/VfpmZAmsP9R5LTiglL3tL0f0CP7aOB7ihP9r/7V/McUu1 GdAL7xqpDdrwtAilf+jneWQrMTIQ9kPeu/jWdbGKo38dE5vCpLi19uu+U6xK2aObK 3pB7oVIHbQUVvHXGks9ZrJX0iOr9Ikxk/pF5TfRhxibwUeU8+FjT93S2Sn5AV6q5/ 1hwVmKLlD+O3ZG9nn63/fQmBpyP2k0l2sjUgTP/GIyhyvNXjwuLlKxAXxeWdIdWKY /Pl6iO9xuBiRYKsQfg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.86.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MVrg7-1swdQe1rIz-00RcPq; Fri, 19 Jul 2024 22:04:53 +0200 Message-ID: <198384d7-23a6-4866-9f22-3aac028e0ee0@web.de> Date: Fri, 19 Jul 2024 22:04:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: George Yang , Lizhi Hou , Min Ma , Narendra Gutta , dri-devel@lists.freedesktop.org, Oded Gabbay Cc: LKML , Max Zhen , Sonal Santan References: <20240719175128.2257677-3-lizhi.hou@amd.com> Subject: Re: [PATCH 02/10] accel/amdxdna: Support hardware mailbox Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240719175128.2257677-3-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:b7Bd8PQGXZNNTXQ5cchbuNbvP4kWwX7zVqY6GVQgKzVzCw66v5W 3F9nWuXsjpz4W6L+qfEr6V0Ffs3hdWHgiYPDGRHOCLNl0yfbjwLWKZMBgORNCNTLbKf4NIO QpBNwk4/F2lfmy340ab5rvf6rerzINKWXqxxImH/XCKWDCydwmjANQ1y1hjxIPoOzY/GWNe RjhZAx3keS7fxZqFtTWHQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:jpR54G7ergQ=;Eb3YztXnztUA0Yl4vvLhPxUygIz IOUeTYqQAvb8A0P/ogdCvWYtziucIBW0C2sZ5ta/6ws6XK0K9DlTeYr+MTbRO/Fqrhj+xZdUa TeOfcYIPsZmXgOkMB1YwkPxz4ItZRBQj1uq+tk2sLEvvwOw23Aosz9/1EUABFtzE35coFrnWx 3AACOq72rophWIye04EO8aiAlNYEbSkDJDBD1X+zJH13pLKKWvsT4+i/FkWy2l2B6YDiRhhSZ ivs5R70bN6gSf4GQkgrGK8TbLBvxcOwzwSouIAOZg/YZNbb6lWboplFibcwsVM0nMmogOVvuW CtBrpXsTmb4t117zVm4wpwuyLegwn/q/kllbcwhVmnF2QUqocUhFOoqfDsPmMVWMM9+QrUBR6 2BbeHgp8keCm2vaWK6Bm1OYMKW+56CxUHK15TxzPTZt1fuNFmqHbMLlsKmAteY5I0qjpYwXSx VWg20citUNkMJt7TAk2FE96BUUknfkuzv5huEj0ljXcZuhJn/7tZFUGv98ueSUx/mp7K9h/IZ PEVpxRw6/k2ss6pL4Uhcs0RSbWjmkVJRbd+c165jBpHkyvfy/NBrOB2EhC2Q0/4SWgT9HLmIx jcmit6r0msXiBCA8Ec+zvG4Blyu7B/sL0Z8TzXb12aSxFx4eo0sNdPTKkfpctFkN8lvrZSiTk oA6Dyr2yahS5usgazbKWXjl89KnKOEQl35iCR34J/+dH2KPvh8Y2nRMtAW7bpIy/AIBfBOnBe N6H91qgmDLJpneVosPuRvLOskZvyIu9bvi3axp0KrCD6PfXvWOqDUCjNXW7Wo3GRiQzCQnKJI CunBDU9xK0sTQhfTRiPFTkIg== =E2=80=A6 > +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c > @@ -0,0 +1,582 @@ =E2=80=A6 > +static int mailbox_acquire_msgid(struct mailbox_channel *mb_chann, stru= ct mailbox_msg *mb_msg) > +{ =E2=80=A6 > + spin_lock_irqsave(&mb_chann->chan_idr_lock, flags); > + msg_id =3D idr_alloc_cyclic(&mb_chann->chan_idr, mb_msg, 0, > + MAX_MSG_ID_ENTRIES, GFP_NOWAIT); > + spin_unlock_irqrestore(&mb_chann->chan_idr_lock, flags); =E2=80=A6 Under which circumstances would you become interested to apply a statement like =E2=80=9Cguard(spinlock_irqsave)(&mb_chann->chan_idr_lock);=E2=80=9D? https://elixir.bootlin.com/linux/v6.10/source/include/linux/spinlock.h#L57= 4 Regards, Markus