From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755661AbcARPky (ORCPT ); Mon, 18 Jan 2016 10:40:54 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:60512 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755430AbcARPkv (ORCPT ); Mon, 18 Jan 2016 10:40:51 -0500 From: "Rafael J. Wysocki" To: Sudeep Holla Cc: Dmitry Torokhov , Greg Kroah-Hartman , Rob Herring , Grant Likely , Linus Walleij , Thierry Reding , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , open list , "Rafael J. Wysocki" Subject: Re: [PATCH] driver-core: platform: automatically mark wakeup devices Date: Mon, 18 Jan 2016 16:41:32 +0100 Message-ID: <1984537.Ed4NObzuHH@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.4.0; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <20160118021138.GA20498@dtor-ws> <2182115.GafOXid1Dx@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, January 18, 2016 03:23:18 PM Sudeep Holla wrote: > On Mon, Jan 18, 2016 at 2:47 PM, Rafael J. Wysocki wrote: > > On Sunday, January 17, 2016 06:11:38 PM Dmitry Torokhov wrote: > >> When probing platform drivers let's check if corresponding devices have > >> "wakeup-source" property defined (either in device tree, ACPI, or static > >> platform properties) and automatically enable such devices as wakeup > >> sources for the system. This will help us standardize on the name for this > >> property and reduce amount of boilerplate code in the drivers. > > > > ACPI has other ways of telling the OS that the device is wakeup-capable, > > but I guess the property in question can be used too (as long as it is > > consistent with the other methods). > > > > Just curious to know what you mean when you say this property can also > be used with ACPI. Do you mean we could use "wakeup-source" DSD ? Yes. > If so, won't that go against rule for DSD (i.e we *should not* bypass the > existing mechanisms defined by the ACPI, e.g. _SxW in this case) Not necessarily. What if the device doesn't use ACPI PM and still can wake up the system? Thanks, Rafael