From: Komuro <komurojun-mbn@nifty.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] Fix pd6729.c on architectures which define NO_IRQ
Date: Mon, 21 Nov 2005 21:41:59 +0900 (JST) [thread overview]
Message-ID: <1988091.1132576919549.komurojun-mbn@nifty.com> (raw)
In-Reply-To: <E1Ee0G0-0004CL-5E@localhost.localdomain>
Thanks for pointing this out!
I have misused the NO_IRQ definition.
Best Regards
Komuro
>
>Use pci_valid_irq() instead of a custom NO_IRQ definition.
>
>Signed-off-by: Matthew Wilcox <matthew@wil.cx>
>Acked-by: Ingo Molnar <mingo@elte.hu>
>
>---
>
> drivers/pcmcia/pd6729.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
>applies-to: 26750e45f268b109d418c91b01a55e124bd879e1
>fd1b59b22f926ee7daa097166d9e7ac6005b1284
>diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
>index 20642f0..72720f2 100644
>--- a/drivers/pcmcia/pd6729.c
>+++ b/drivers/pcmcia/pd6729.c
>@@ -39,10 +39,6 @@ MODULE_AUTHOR("Jun Komuro <komurojun-mbn
> */
> #define to_cycles(ns) ((ns)/120)
>
>-#ifndef NO_IRQ
>-#define NO_IRQ ((unsigned int)(0))
>-#endif
>-
> /*
> * PARAMETERS
> * irq_mode=n
>@@ -733,7 +729,7 @@ static int __devinit pd6729_pci_probe(st
> goto err_out_disable;
> }
>
>- if (dev->irq == NO_IRQ)
>+ if (!pci_valid_irq(dev->irq))
> irq_mode = 0; /* fall back to ISA interrupt mode */
>
> mask = pd6729_isa_scan();
>---
>0.99.8.GIT
prev parent reply other threads:[~2005-11-21 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 1:14 Matthew Wilcox
2005-11-21 12:41 ` Komuro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1988091.1132576919549.komurojun-mbn@nifty.com \
--to=komurojun-mbn@nifty.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®