From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Hannes Reinecke <hare@suse.com>,
Khalid Aziz <khalid@gonehiking.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Finn Thain <fthain@linux-m68k.org>,
Michael Schmitz <schmitzmic@gmail.com>,
James Smart <james.smart@broadcom.com>,
Ram Vegesna <ram.vegesna@broadcom.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
"Juergen E. Fischer" <fischer@norbit.de>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<target-devel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: add missing MODULE_DESCRIPTION() macros
Date: Mon, 10 Jun 2024 07:57:20 -0700 [thread overview]
Message-ID: <1988d782-e9a1-4099-9ca4-4a4d7c560554@quicinc.com> (raw)
In-Reply-To: <58217b4a-d731-4bc2-b625-9a5f0b9b17c0@suse.com>
On 6/9/2024 11:10 PM, Hannes Reinecke wrote:
> On 6/8/24 17:33, Jeff Johnson wrote:
[...]
>> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
>> index 9503996c6325..add10098a569 100644
>> --- a/drivers/scsi/aha1542.c
>> +++ b/drivers/scsi/aha1542.c
>> @@ -1009,6 +1009,7 @@ static int aha1542_biosparam(struct scsi_device *sdev,
>>
>> return 0;
>> }
>> +MODULE_DESCRIPTION("Adaptec AHA-1542 SCSI host adapter driver");
>> MODULE_LICENSE("GPL");
>
> Please add a newline before the MODULE_DESCRIPTION line.
>
>>
>> static int aha1542_init_cmd_priv(struct Scsi_Host *shost, struct scsi_cmnd *cmd)
[...]
>> --- a/drivers/scsi/atp870u.c
>> +++ b/drivers/scsi/atp870u.c
>> @@ -1724,6 +1724,7 @@ static void atp870u_remove (struct pci_dev *pdev)
>> atp870u_free_tables(pshost);
>> scsi_host_put(pshost);
>> }
>> +MODULE_DESCRIPTION("ACARD SCSI host adapter driver");
>> MODULE_LICENSE("GPL");
>
> Again, missing newline.
I'll update these in v2
prev parent reply other threads:[~2024-06-10 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 15:33 Jeff Johnson
2024-06-08 23:43 ` Finn Thain
2024-06-10 6:10 ` Hannes Reinecke
2024-06-10 14:57 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1988d782-e9a1-4099-9ca4-4a4d7c560554@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=artur.paszkiewicz@intel.com \
--cc=fischer@norbit.de \
--cc=fthain@linux-m68k.org \
--cc=hare@suse.com \
--cc=james.smart@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ram.vegesna@broadcom.com \
--cc=schmitzmic@gmail.com \
--cc=target-devel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®