From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBE4ECDFB8 for ; Tue, 24 Jul 2018 14:44:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA0552064D for ; Tue, 24 Jul 2018 14:44:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA0552064D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aosc.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388580AbeGXPvE convert rfc822-to-8bit (ORCPT ); Tue, 24 Jul 2018 11:51:04 -0400 Received: from hermes.aosc.io ([199.195.250.187]:53237 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388495AbeGXPvE (ORCPT ); Tue, 24 Jul 2018 11:51:04 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 4D6BF9F7AE; Tue, 24 Jul 2018 14:43:19 +0000 (UTC) Date: Tue, 24 Jul 2018 22:42:32 +0800 In-Reply-To: <20180724144151.myyg7slocsfjjsfi@flea> References: <20180724011551.49603-1-icenowy@aosc.io> <20180724011551.49603-4-icenowy@aosc.io> <20180724144151.myyg7slocsfjjsfi@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [linux-sunxi] Re: [PATCH 3/3] arm64: allwinner: dts: h6: add Wi-Fi support for Pine H64 model A/B To: maxime.ripard@bootlin.com, Maxime Ripard , Chen-Yu Tsai CC: linux-arm-kernel , devicetree , linux-kernel , linux-sunxi From: Icenowy Zheng Message-ID: <198DB486-4789-4777-9596-2BD6FAFFB741@aosc.io> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年7月24日 GMT+08:00 下午10:41:51, Maxime Ripard 写到: >On Tue, Jul 24, 2018 at 10:37:51AM +0800, Chen-Yu Tsai wrote: >> On Tue, Jul 24, 2018 at 10:28 AM, Icenowy Zheng >wrote: >> > >> > >> > 于 2018年7月24日 GMT+08:00 上午10:26:02, Chen-Yu Tsai 写到: >> >>On Tue, Jul 24, 2018 at 10:23 AM, Icenowy Zheng >> >>wrote: >> >>> >> >>> >> >>> 于 2018年7月24日 GMT+08:00 上午10:21:59, Chen-Yu Tsai >写到: >> >>>>On Tue, Jul 24, 2018 at 9:15 AM, Icenowy Zheng >> >>wrote: >> >>>>> The Pine H64 model A has a Wi-Fi module connector and the model >B >> >>has >> >>>>an >> >>>>> on-board RTL8723BS Wi-Fi module. >> >>>>> >> >>>>> Add support for them. For model A, as it's not defaultly >present, >> >>>>keep >> >>>>> it disabled now. >> >>>> >> >>>>Nope. Pine64 actually has two WiFi/BT modules. And they require >> >>>>different >> >>>>device tree snippets for both the WiFi and BT side. This is >better >> >>>>resolved >> >>>>with device tree overlays. >> >>>> >> >>>>I have both, though I've yet found time to work on them. >> >>> >> >>> I have also both. >> >>> >> >>> The skeleton here can get the Wi-Fi of both to work. >> >> >> >>Cool. Then I can put away my RTL module for now. :) >> > >> > P.S. SDIO is auto detectable, and for BCM chips, the OOB interrupt >> > is only a bonus function and it can fall back to standard in-band >> > interrupt (which doesn't need special binding, and is currently >> > used by mainline r8723bs driver.) >> >> Correct. With BT you'll have serdev device nodes with different >> compatibles. Then you'll have to resort to overlays, and you'd >probably >> end up adding WiFi OOB interrupt bits as well. >> >> So the question remaining is: should we enable the MMC part, along >> with power sequencing and regulator supplies, by default? Thinking >> more about it, I'm actually OK with it. The board connectors are >> clearly marked as being for a WiFi+BT module. The whole space on >> the board is surrounded by a box in silkscreen. Sorry for the >> initial nack. >> >> Maxime, any thoughts? > >If there's a need for an overlay anyway, there's no real reason to >enable it by default, especially if not everything is there. Everything is there, for model B support. > >Maxime