From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69A82242D6C for ; Wed, 24 Jun 2026 07:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782286773; cv=none; b=C6eX2Tdw84ZRKqVJRn/XG3i5Kbz3+UZ6pZ/yCpb0A2g6NJopfU/IZG/cwtvCrquNyTfMoxnPJMdyfgdiZMG5WhkdZ8AwupfF7X4/EWI4zcBuErQv4ZI4LxT0BLlCaWNtv2FMPaS/OUkDEvqQR1nPvcgUh5SBpr12C6ql2huRFw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782286773; c=relaxed/simple; bh=jJ9YG2tB1GQah48jOchhDBoZwkGDBycXPbvfGVlIL4s=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=OjvsKm6EuPvem3XKyd3fuIGgpIY9I1YdM2ULJ2oTQ7Eza7kBWSZhMNlUU9jHwcBBHzwE2NFf4LnVqTrGNqgXbRdpg2KP78lvjVQ91UAvBAk2MEDEKqYLwJqMwKdkpTgcDHAwltTpnMW5X8tgYWYjHho86k6XA1Z0DDZgHLtKz3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ERDeY80/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RmuSb19y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ERDeY80/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RmuSb19y" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65O5u80B2555573 for ; Wed, 24 Jun 2026 07:39:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GBY28EHIgWlqZkL2cdIhQQofqRyA4PuEZ3MPh7m5b74=; b=ERDeY80/dGKOTaIa HxwnKaAN4KUN10EXybqJOY7kI/hV9NNdJoNHOzxE2fNnPz4HnmVLTKyVGbwmviUa iJfg+cPJFLAt1t8k4tQIbcixBRmmB4bHEVKWxoGS6HAbZv163Zax6OYqYOmwJ2+K HBXwUXgdEjJlbzl+SdO6qdPWGQfO/dKyd5TADUzApG1A8cUhDm6Kh7LNQZ03M8lF NgdOcmceiclG4ejYeBtADRzyENFKosq7VubuCjMyNCzdVoVlVLoPUgme3TjA0ZQt +xwehtNajWTMwj8r7zIE4aK+ZtgcuSOgBrIU6HReK8bZfDNJ/P4uy6yJHSaurawv AJuc2w== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0996gdkt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 07:39:30 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8de97bd8459so2532256d6.0 for ; Wed, 24 Jun 2026 00:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782286770; x=1782891570; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GBY28EHIgWlqZkL2cdIhQQofqRyA4PuEZ3MPh7m5b74=; b=RmuSb19ygR/lDH2EyG4OMUHuqCtxcD0W/abrpybHpZ7TL5ivVays2Fq8rWLmd4u7jB I6ar6gHW5+nq6tASrO1wQTKxDAhlFAUo+brbMkGsYNHzeFvxMxSVE8eNOxEOXANqVpyd QeW/ypFuF9oXs8dWRz7zjMQw+LyC6J6ZL/mDOKpKdCGXNXUHGlYsFJy+MyyVHJA/6SOR JdkaSsc0+PWuZlVvk+kk2o/9sLZfmhjNn9Wv7zsdC/QW+JirOgm1iF4FQBw7Fdk1/i+E mvzL97GYMfQ7UnlWv3wRJZ8Pls0KggCQIFptXQYzivWmrs8dmot5cLZ6PZZD/LRHEKRI rDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782286770; x=1782891570; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GBY28EHIgWlqZkL2cdIhQQofqRyA4PuEZ3MPh7m5b74=; b=ZebMFI1p8rgpj0N6TscQEV+TMu6oT9WGp3qUm96oCczeXKN1w74JSuN7nMf0Gda50Y r/LxJaZ+aesydO2X4SnSC9RSMSSgTHUwJBoO3US5qjtDoogKw+BsiGwhKUEgLaq14lhB TDChKAIJeLJGtWpagDh4+wloqiW1+wAoK+VteTruqapE1eX9EhTqHIyn4hMAbBuwVpRv aiAnkQFWWx4JuHkvzuAINxbqVNJqZWCBy7rXAcz8R4p50YVs2ojeUoMMUlNpiBjCbcIn kF5ErMYd1zfNdF+NlaliT/kG6PUYqo5OXj7JNJfxqfdS+5d85UlEuGtI9GRTBgp5aMba gxuA== X-Forwarded-Encrypted: i=1; AFNElJ9L9zvAKBvFoSZz6e/pb0gVbPTM4GQASVR9AcF8yre0FxTx/uM4bofwVZfVhuX3KwJyUHK6PgDyXjVYqr8=@vger.kernel.org X-Gm-Message-State: AOJu0YyNCBSQiB1bWSjTgX5CL/3FH2XE3IlvCKwjH/J0TV9Xmr+ebHyG 71pclytYUMK8iXdaK/RtLv6i8rip1DWW9CcDky6DkLdYUWEZ3rzzlMR11krw1hbVdsaPLuu02nl tT2YKA/gIGH6lkpB4pGTho6L40zB09zgpEG1xwe3KIVzdWjzN2H/GtiIMwrbSGaAAjZI= X-Gm-Gg: AfdE7clQDd4h50xOGqjPUFWGgPsXEkkV/Tjk5EjAp2raXVK+aKqJCm9+kqjqSCVHUiK Vz+f76wrNH6rtdryvn+z7NSzRBz19LK+gFBxuvcqM4ma+lf8N1ma+BvNpCO/AEjZPcgta/6Mr4M KI5tOGYe7bzHGtUl4FwgvI4gOozuQs3oEx05jTGuUNQloOq85yIpQum2Yr+1a72r0d1NWFxkbK4 bccBkVJztw1K0L86ciIfi6EItgVTuaZsrtSCSON/evK4HxUsM37xSxCx90tEE/TDG7+smTu3vQh t73eVSqieCWkjJbagYDMUtEDvTYj2ftBGKe6e6wLz4B+IoZ4he58FvmdVZZAOh8ccWV3y7OSIKR 4SrvA8/N0Tz2qWz3WIHz++gO/mQoffXeXacQ= X-Received: by 2002:a05:620a:4009:b0:8ee:f43a:bb63 with SMTP id af79cd13be357-921805433f2mr1904887685a.0.1782286769867; Wed, 24 Jun 2026 00:39:29 -0700 (PDT) X-Received: by 2002:a05:620a:4009:b0:8ee:f43a:bb63 with SMTP id af79cd13be357-921805433f2mr1904885685a.0.1782286769459; Wed, 24 Jun 2026 00:39:29 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e99bd0bsm617009366b.23.2026.06.24.00.39.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 00:39:28 -0700 (PDT) Message-ID: <198ad9ab-6e8e-4c67-afc2-01962ea12dde@oss.qualcomm.com> Date: Wed, 24 Jun 2026 09:39:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] clk: qcom: hfpll: return lock timeout from enable paths To: Antony Kurniawan Soemardi , Pengpeng Hou , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Herman van Hazendonk , Dmitry Baryshkov References: <20260623060517.10889-1-pengpeng@iscas.ac.cn> <8e7a4cd1-ff17-4052-938b-5cb2ee8576f0@oss.qualcomm.com> <36f37fa0-94f3-498b-86ca-b431436750e1@smankusors.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <36f37fa0-94f3-498b-86ca-b431436750e1@smankusors.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: lfO9FyRH3dVSAK5itHS2J4omPmFyk9rc X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDA2MiBTYWx0ZWRfX5qMkipTy11b1 QXku93AIgSJdZB6UX+n3HvwjOyuS6BtfGCJFFP4xiqnUV4YCG4kjx9Q1hssSJxfseAMcfDJi3Xe EItD0lw4BPhb/awpAr1zjCxQwF+ILCo= X-Proofpoint-ORIG-GUID: lfO9FyRH3dVSAK5itHS2J4omPmFyk9rc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDA2MiBTYWx0ZWRfX4gFlygoXSqvE q8FJUY/XISItaRqsGia3ly3sovLCf1ZwoJJIno1UR9ROgOEI2isiJ3XMMca6hbl/gvm6vKtEXp2 uxmEoCnZDOow+EviluPPgSQpmb4jMA/F5wMsxlDKdl8yt4fOjshklnlTZfPL1HVuvwQmpn/Spcp AWCWE7lGZHgwMvZLnFVYywSxU/WXF73Vyh6Skv1tpU1A7JxnlElnYridw0L2lG+dVSn25Ta29Lm I/o+2SyOxV73QrKqRa/xd/1ASdeym34wGBC/zOyLT9chMtQ9vvqlqFzOV131G/M/WT2zq8DyAXf fnzNbwPIh4w+EnfQRlZfktpA/b2Qxja0RM9s6HVhshcv2AIQsYQoggsbGTQBSp2zmFJyZgS5AWb drfgoxGztfbJ++bPHucdN/coZNTzXw== X-Authority-Analysis: v=2.4 cv=Tv/WQjXh c=1 sm=1 tr=0 ts=6a3b89b2 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=zM5_-Fq6ha1Ldok9JJkA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240062 On 6/24/26 3:57 AM, Antony Kurniawan Soemardi wrote: > On 6/23/2026 4:43 PM, Konrad Dybcio wrote: >> On 6/23/26 8:05 AM, Pengpeng Hou wrote: >>> The HFPLL enable helper waits for the lock bit but ignores the >>> regmap_read_poll_timeout() result. The polling condition is also >>> inconsistent with clk_hfpll_init(), which treats the lock bit being set >>> as the locked state. >>> >>> Wait for the lock bit to become set, return timeout errors from the >>> helper, and propagate those errors through clk_hfpll_enable() and >>> clk_hfpll_set_rate() instead of enabling the output unconditionally. >>> >>> Signed-off-by: Pengpeng Hou >>> --- >> >> This looks good on the surface.. >> >> +Herman, Anthony, Dmitry could you please give this a spin on 8x60? >> >> Konrad > > Just to clarify, this patch impacts cpufreq and gpufreq for Qualcomm > Krait era, is that correct? Seems that way - cpu, L2, and GPU, maybe others > I could try this over the weekend on top of Rudraksha Gupta's cpufreq > patch for msm8960 [1]. We don't have a gpu patch for msm8960 on LKML > yet... That's fine > (also my name doesn't have an "h" :D ) My mistake! Konrad > > [1] https://lore.kernel.org/all/20260527-expressatt_cpufreq-v2-0-b9b7726ccb6d@gmail.com/ >