From: Samuel Holland <samuel.holland@sifive.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"'Björn Töpel'" <bjorn@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>
Subject: Re: [PATCH 4/7] riscv: Simplify text patching loops
Date: Wed, 27 Mar 2024 10:12:34 -0500 [thread overview]
Message-ID: <198af54d-10da-4320-9623-85dfb102f5de@sifive.com> (raw)
In-Reply-To: <cb89b03b34d6403685297f95924524a7@AcuMS.aculab.com>
Hi David,
On 2024-02-19 4:13 PM, David Laight wrote:
> ...
>>> - while (patched < len && !ret) {
>>> - size = min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr + patched), len - patched);
>>> - ret = __patch_insn_set(addr + patched, c, size);
>>> + while (len && !ret) {
>>> + size = min_t(size_t, PAGE_SIZE * 2 - offset_in_page(addr), len);
>
> Does that need to be min_t()?
> Both arguments seem to be unsigned.
> (Did it even ever need to be?)
You're right, this never needed min_t(). I'll update this for v2.
Regards,
Samuel
next prev parent reply other threads:[~2024-03-27 15:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 2:55 [PATCH 0/7] riscv: Various text patching improvements Samuel Holland
2024-02-12 2:55 ` [PATCH 1/7] riscv: jump_label: Batch icache maintenance Samuel Holland
2024-02-19 12:27 ` Björn Töpel
2024-02-12 2:55 ` [PATCH 2/7] riscv: jump_label: Simplify assembly syntax Samuel Holland
2024-02-19 12:27 ` Björn Töpel
2024-02-12 2:55 ` [PATCH 3/7] riscv: kprobes: Use patch_text_nosync() for insn slots Samuel Holland
2024-02-19 12:52 ` Björn Töpel
2024-02-12 2:55 ` [PATCH 4/7] riscv: Simplify text patching loops Samuel Holland
2024-02-19 13:03 ` Björn Töpel
2024-02-19 22:13 ` David Laight
2024-03-27 15:12 ` Samuel Holland [this message]
2024-03-27 15:11 ` Samuel Holland
2024-02-12 2:55 ` [PATCH 5/7] riscv: Pass patch_text() the length in bytes Samuel Holland
2024-02-19 13:04 ` Björn Töpel
2024-02-12 2:55 ` [PATCH 6/7] riscv: Use offset_in_page() in text patching functions Samuel Holland
2024-02-19 13:07 ` Björn Töpel
2024-02-12 2:55 ` [PATCH 7/7] riscv: Remove extra variable in patch_text_nosync() Samuel Holland
2024-02-19 13:08 ` Björn Töpel
2024-02-13 12:58 ` [PATCH 0/7] riscv: Various text patching improvements Andrea Parri
2024-02-19 12:25 ` Björn Töpel
2024-02-20 22:11 ` Alexandre Ghiti
2024-03-27 15:32 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198af54d-10da-4320-9623-85dfb102f5de@sifive.com \
--to=samuel.holland@sifive.com \
--cc=David.Laight@ACULAB.COM \
--cc=bjorn@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®