From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5500B284B58 for ; Wed, 17 Dec 2025 17:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765990983; cv=none; b=m/4nqMGG5LZaEoc6WfFA+oQVfvqRgBHQ8eI5uQ8yOOfHz9b52hGp9zmitSP69xzB/+GsrznHNAywnb+uquORxEH37ndlhCTnGqEtqXRGaUCmmvPWlVto9fYNdUt8iRqBkNlaric4NRmcq0rlsaaryk9HdPm4VLUy7TSw0p8YE08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765990983; c=relaxed/simple; bh=MkAOw2BSglp2aTNFcNu2h+CZ00Ka1yjH+aL1APkD2FU=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ukB1Vx40Wn2IazyVyqR7rPSiv6qKrixkRcLrfKiG19YtHVgGCwJpS/eQztvFxaVZAGDPi15DPA0QqTvQo42yF4OK/zu4IcDAV98KPbeCXW5CguH2+BkxwYmqaIe13YEf5UzpgBXjjEvg8Cm9JKakcsSkGfMT10U4bPevE0CQsVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E/pM3HQ3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OSe8LoKe; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E/pM3HQ3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OSe8LoKe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765990981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R6D/twUjpVaN7/2LE7FByWy0dht+yFlBfxvyhXSnqag=; b=E/pM3HQ3upSSAX02s45Q47WwD/Jt09C8DZ/Id3mmN1Q9k4v1ZlL/Kx/R+VK95UBINq/Zfb AxIhB2Vk3iUzG23R047jiAkC2o6MeEEJbbwkE3cd+gJzCaZXsvTty97+/3M54Hzz9m4lxi yZCeMHXMeapbz29loigliIPpdtxdM+I= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-ezk08ja7P3SG-ujwiZY_lw-1; Wed, 17 Dec 2025 12:02:59 -0500 X-MC-Unique: ezk08ja7P3SG-ujwiZY_lw-1 X-Mimecast-MFC-AGG-ID: ezk08ja7P3SG-ujwiZY_lw_1765990979 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8bb9f029f31so1157938385a.2 for ; Wed, 17 Dec 2025 09:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765990979; x=1766595779; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=R6D/twUjpVaN7/2LE7FByWy0dht+yFlBfxvyhXSnqag=; b=OSe8LoKeA0kkomiRxeaWS7j4cdwcf2uM53bUwp7Q1vslATO6lVlGFsS0DUVKdUsnlS StkN8aTICv0FDHTZEWb8t7zsMVaN2nkyMMZO4AfTObDl/arLl0QAX96H0MnHVWEgehFI JMkOjoxuQuqwYtxREhT/Q40i/Q5v4A980++nH4EXbQjzxht90XnDCVVdYiHlHrRwfD62 0AleCOVMEGziL/mkZ59STDOILyfMGjhvMRUPB4Bdqoej/75VtyIphgnLH6fxhfc4brTp oYRatekNYm6e21/NduIDGcpOhjKhQixW7yIT/9ekIgjJTS2hayloONptlPi8BBIRiFx+ 2a1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765990979; x=1766595779; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R6D/twUjpVaN7/2LE7FByWy0dht+yFlBfxvyhXSnqag=; b=KejBzFfLRW5fXKKUo9IkqOKcxOIeEgr8z3giaUyjJcTZzjFbd3S1djniHTAK6F37mf jZmZgTUQSLX1u5MOQcB4+dQjrqYl1ff5STQOSF7N6RmWuUa5noyUCGK91id0a6XA2OSs Mvhio+nJwGrxhs/TCzySnkyr1oEqK40oH/x70S6X5/csz+moOTf+UKI54f1lWwtv6VU1 DEkEPNN4HFS+PALjy7F6Qy9kRTsy9oat2BAnVK+q6pIQ+bS4b6oZ16KtWh1GVjcZgO1D B0hg7dgAcJYpMYhEXZNrTEPFuYILS351Q7LLxveBjwUoE4te27x1YZcHen9mD58SStvR sd4w== X-Forwarded-Encrypted: i=1; AJvYcCXcSBOW/NEnS53KdLNASZnSussrL6/0ZNqMIS1pPjaqDyAc5xaSnG6dsr3afXY9joiNwPNf0XTTTpWBXiE=@vger.kernel.org X-Gm-Message-State: AOJu0YzVt2pFfGorrLwLtmHxBi2onZjBNZC2o3c1VTkMTe4dO4UqK1S1 HuYhRk8VJlB3u90/t5pX0mJyxbvg3bSriXb02XXOsKLq8o1wWSMyIPXoOfP6qMmqX6GubjkuClz S7Mwgscx8izLCYf8ynlAFzhFvSLI02BBF/wvICtWDCZ/5VagYliYchyyuJq79FTBLhg== X-Gm-Gg: AY/fxX4lDxDOpqoi4nxWkZPkgBBLyicEeVYryGekeEtw48IWlC/oWCJXzqoZ87bxPI7 zRFNn/9HReIF0LVj4s8OZ42TLm46lk4SDviAhvMDGKT9urFAXAcEfdPA2ZWNF/wBwT1mryo1gO2 oFwsn7/gnfRNZLVGJdwAtvHPrFELz9BgI5jw8gr9hgMdfUksJwPytS2DddOq1LTHVmmhGj0q8RV PPUo433TMwr3uLb7ItqSxnIMZWDuWgirLCy0YrWUJAWr46GxLf762WEcCKLPrl6q0DWVEQ891BJ fToNCP4P96eUSCkQsnOVVuspQ9LTadsdjrXD8bzmakbnJqqIiefTfydqNf+iBeuoSWwkeJPZmNi PlgEatJjy3OLpQdf4bVgyxLqWK+y8L1KZXoOWgQxy4thh5hFu1hpN1bfY X-Received: by 2002:a05:620a:4589:b0:85c:bb2:ad8c with SMTP id af79cd13be357-8bb3a2495abmr2603900985a.74.1765990978822; Wed, 17 Dec 2025 09:02:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBDyuzbsCeW4xAU+wI9KUPEJo+vLDUjXrnECfI5NKbMOzF1M5IO7XVO1lPhXKQQ68k4qHxJg== X-Received: by 2002:a05:620a:4589:b0:85c:bb2:ad8c with SMTP id af79cd13be357-8bb3a2495abmr2603887585a.74.1765990977564; Wed, 17 Dec 2025 09:02:57 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8be31c75b45sm430186385a.52.2025.12.17.09.02.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 09:02:57 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <198cec94-6d2c-46c0-a46a-9ab810deb7e0@redhat.com> Date: Wed, 17 Dec 2025 12:02:55 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next 1/6] cpuset: add assert_cpuset_lock_held helper To: Chen Ridong , tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, lujialin4@huawei.com References: <20251217084942.2666405-1-chenridong@huaweicloud.com> <20251217084942.2666405-2-chenridong@huaweicloud.com> Content-Language: en-US In-Reply-To: <20251217084942.2666405-2-chenridong@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/17/25 3:49 AM, Chen Ridong wrote: > From: Chen Ridong > > Add assert_cpuset_lock_held() to allow other subsystems to verify that > cpuset_mutex is held. Sorry, I should have added the "lockdep_" prefix when I mentioned adding this helper function to be consistent with the others. Could you update the patch to add that? Thanks, Longman > > Suggested-by: Waiman Long > Signed-off-by: Chen Ridong > --- > include/linux/cpuset.h | 2 ++ > kernel/cgroup/cpuset.c | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > index a98d3330385c..af0e76d10476 100644 > --- a/include/linux/cpuset.h > +++ b/include/linux/cpuset.h > @@ -74,6 +74,7 @@ extern void inc_dl_tasks_cs(struct task_struct *task); > extern void dec_dl_tasks_cs(struct task_struct *task); > extern void cpuset_lock(void); > extern void cpuset_unlock(void); > +extern void assert_cpuset_lock_held(void); > extern void cpuset_cpus_allowed_locked(struct task_struct *p, struct cpumask *mask); > extern void cpuset_cpus_allowed(struct task_struct *p, struct cpumask *mask); > extern bool cpuset_cpus_allowed_fallback(struct task_struct *p); > @@ -195,6 +196,7 @@ static inline void inc_dl_tasks_cs(struct task_struct *task) { } > static inline void dec_dl_tasks_cs(struct task_struct *task) { } > static inline void cpuset_lock(void) { } > static inline void cpuset_unlock(void) { } > +static inline void assert_cpuset_lock_held(void) { } > > static inline void cpuset_cpus_allowed_locked(struct task_struct *p, > struct cpumask *mask) > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index fea577b4016a..a5ad124ea1cf 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -271,6 +271,11 @@ void cpuset_unlock(void) > mutex_unlock(&cpuset_mutex); > } > > +void assert_cpuset_lock_held(void) > +{ > + lockdep_assert_held(&cpuset_mutex); > +} > + > /** > * cpuset_full_lock - Acquire full protection for cpuset modification > *