From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686CDC2D0A3 for ; Thu, 22 Oct 2020 03:04:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9C32208C3 for ; Thu, 22 Oct 2020 03:04:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="WKvT4hO4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895292AbgJVDEz (ORCPT ); Wed, 21 Oct 2020 23:04:55 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:13455 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895283AbgJVDEy (ORCPT ); Wed, 21 Oct 2020 23:04:54 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603335893; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=+nQ5ZSBmVVyAWKnZjaUdFuEquc1+aCE/YrO2L81++rQ=; b=WKvT4hO4aXkuFvqNNh7HWvReQF+FICNiUgPloB1IovvP4vZXgS5hiXRLQthK/sIy1s6uPs9E Ynq9r7RJTtw0SWNiHeDRLb1BSNaOU6u4MA+tsZ/sWKJEB0IIJRHcUDmn5Hi93lhrM2T93wpI +E9hL+WCdW1p1U4oa+pEjX6kIpw= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5f90f6d44f8cc67c313300a5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 22 Oct 2020 03:04:52 GMT Sender: jhugo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BD1E3C433FE; Thu, 22 Oct 2020 03:04:51 +0000 (UTC) Received: from [10.226.59.216] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B0472C433C9; Thu, 22 Oct 2020 03:04:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B0472C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH v7 3/4] docs: Add documentation for userspace client interface To: Hemant Kumar , manivannan.sadhasivam@linaro.org, gregkh@linuxfoundation.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, bbhatt@codeaurora.org, loic.poulain@linaro.org References: <1602907457-13680-1-git-send-email-hemantk@codeaurora.org> <1602907457-13680-4-git-send-email-hemantk@codeaurora.org> From: Jeffrey Hugo Message-ID: <198e5431-756c-38b1-2426-eb4ab8074b60@codeaurora.org> Date: Wed, 21 Oct 2020 21:04:50 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/21/2020 11:46 AM, Hemant Kumar wrote: > Hi Jeff, > > On 10/21/20 8:28 AM, Jeffrey Hugo wrote: >> On 10/16/2020 10:04 PM, Hemant Kumar wrote: >>> +release >> >> Should this be "close" since close() is the actual function userspace >> would call? > I was keeping kernel driver in mind while writing this, i can change it > to close() if release() is confusing here. I guess I was considering the client perspective, but this is kernel documentation so I can see your perspective. I don't have a strong preference. I suppose keep it as is. >> >>> +------- >>> + >>> +Decrements UCI device reference count and UCI channel reference >>> count upon last >>> +release(). UCI channel clean up is performed. MHI channel moves to >>> disabled >>> +state and inbound buffers are freed. >>> + >> >> > Thanks, > Hemant -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.