mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Salil Mehta <salil.mehta@huawei.com>
Cc: <netdev@vger.kernel.org>, Linuxarm <linuxarm@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: hns3: Compilation of hns3_enet.c is triggered without changes
Date: Wed, 2 Jan 2019 10:44:12 +0000	[thread overview]
Message-ID: <199310fa-e088-1b36-77b9-da696fea4dec@huawei.com> (raw)
In-Reply-To: <430207483.256478.1546089053476@email.ionos.de>

On 29/12/2018 13:10, Stefan Wahren wrote:
> Hi,
>
> during development i noticed that hns3_enet.c is compiled even without any changes to this file.
>
> I think the reason for this is the usage of VERMAGIC_STRING in this file. So it would be nice if you could somehow replace this define.
>
> Kind regards
> Stefan
>
>

I reported this issue internally some time ago. Apparently it is 
required to reference VERMAGIC_STRING, but I don't know why.

I see that this driver has similar issue:
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/netronome/nfp/nfp_main.c#L34

Another annoying thing I find is the amount of references to UTS_RELEASE 
(which also causes rebuilds), like:
https://elixir.bootlin.com/linux/latest/source/drivers/base/firmware_loader/main.c#L281

Can't we just make a static string for these, to save the rebuilding the 
dependent modules?

Thanks,
John



           reply	other threads:[~2019-01-02 10:44 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <430207483.256478.1546089053476@email.ionos.de>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199310fa-e088-1b36-77b9-da696fea4dec@huawei.com \
    --to=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=stefan.wahren@i2se.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®