mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Bligh - linux-kernel <linux-kernel@alex.org.uk>
To: john@grabjohn.com, "René Scharfe" <l.s.r@web.de>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au,
	Alex Bligh - linux-kernel <linux-kernel@alex.org.uk>
Subject: Re: [TRIVIAL] Cleanup in fs/devpts/inode.c
Date: Sat, 29 Mar 2003 20:14:13 -0000	[thread overview]
Message-ID: <1995917808.1048968853@[192.168.100.5]> (raw)
In-Reply-To: <200303291829.h2TITPPi000418@81-2-122-30.bradfords.org.uk>



--On 29 March 2003 18:29 +0000 john@grabjohn.com wrote:

>> this patch un-complicates a small piece of code of the dev/pts
>> filesystem and decreases the size of the object code by 8 bytes
>> for my build. Yay! :)
>
>> -		err = PTR_ERR(devpts_mnt);
>> -		if (!IS_ERR(devpts_mnt))
>> -			err = 0;
>> +		if (IS_ERR(devpts_mnt))
>> +			err = PTR_ERR(devpts_mnt);
>
> Why not use
>
> err = (IS_ERR(devpts_mnt) ? err = 0 : PTR_ERR(devpts_mnt));

Perhaps because it inverts the logic, and has a superfluous
assignment causing a warning? :-) I think you meant:

  err = IS_ERR(devpts_mnt) ? PTR_ERR(devpts_mnt) : 0;

--
Alex Bligh

  parent reply	other threads:[~2003-03-29 20:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-29 18:26 René Scharfe
2003-03-29 18:29 ` john
2003-03-29 18:36   ` Robert P. J. Day
2003-03-29 19:12   ` Robert Love
2003-03-29 20:00   ` Felipe Alfaro Solana
2003-03-29 20:14   ` Alex Bligh - linux-kernel [this message]
2003-03-29 21:39     ` john

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1995917808.1048968853@[192.168.100.5]' \
    --to=linux-kernel@alex.org.uk \
    --cc=john@grabjohn.com \
    --cc=l.s.r@web.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®