From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754999AbdEMNSH (ORCPT ); Sat, 13 May 2017 09:18:07 -0400 Received: from mout.web.de ([212.227.15.3]:58250 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdEMNSF (ORCPT ); Sat, 13 May 2017 09:18:05 -0400 To: linux-mmc@vger.kernel.org, Ludovic Desroches , Ulf Hansson Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: SF Markus Elfring Subject: [PATCH] mmc: atmel-mci: Delete an error message for a failed memory allocation in atmci_of_init() Message-ID: <199b33a2-6722-fba1-e7ec-5ac016c5bad0@users.sourceforge.net> Date: Sat, 13 May 2017 15:17:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Jm0FCW9fmKngukGm7Hx8ggZJB7IEHZ7flxSylhpRoVwiX7CJqlb EgRSd+RgJ3KPv9+fxR3mWLmjss3U1mneuAWCKWLv2urb//IwKwKWw2+hbiDAm3l7KvWH3Uf 03jcCQBv1YnOtxmvigjpPE6QZmSYgBYaCgGXOsWXWiRksW/OgtiqxXyb8bks7a8YYVf14jt FrUSOyH4utlJuxTosugrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:HB/wK38g0cY=:sJpFv1RVSt6agzqxBhwMXt ytUhO4x0HboiBL0vKB+HP45nNVedCmtBGilYBT9Qgd3El2mXTDXIUsd3Tg/Q1gz9pJALdBcG+ FLXY0ZXR/8TT96NsKDqjE+tlbaAX4m5TpMNmG/pJt8/C3cvJhdqeIRsEE5bbLHohSwA3namZ7 sApM3PqFuKQCwI4A/SCB6Of3y/H2wodsJ1fal3See1aWGvRfGqDBmscjeZV65b5+eogtrC7g4 0wBo6DWGgY+oSeHaqHZ6QgVqWNGvOiA2e23xcIyEUREgwcYf4TPvTg3ZFyrK3YO3I3JpyoY0N 0Hcr0qx9oGF/fbzQDfyZ0hfngb/FZLNIuaMERF29hJCTFkC484vTcFeBJ4wnaqhALJCXoFiKU Y23Ob5cIz8jDo2ZHnHaNsufITpL2FRRNwGPi0Vy1XXWB958KQI5NBjSS8cdOUnSfSMekMMiww 7+5PomhRsRZzcurElAMVEeVWdkbsYA2KoQjmOJiJxjYuFVrrR3Jy8GFOLOlo4CwOuRWdYwBGW vFCu+0uoTtTn/Di+Ow6ieRc9iBw/oeF2rr687kcrfMFCTPiekfearU4zu5mOYZwA8aVelhshR jSpbF64F11xpslccjXOhQMSu20tM9FdMOD1rtJQfXfmbQ1MYtgP+IJU5sFhH0EcY0RfPKkFXi NckDmlTVAJ9HRjnU+Yt8Th1H7cvFp9JaCzHIvYFHXhXlsPALcVPWiZF5DwhcdVTCeg2p7Hznc +C/ePIts4xIfXAaZBcUOLt8IX2Iv7VpRM71B2OqZNWWaGw5sH9UVcx0YShoTcmFitu3WJvC1b vtf7x67 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 13 May 2017 15:05:28 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/mmc/host/atmel-mci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 388e4a3f13e6..584247464eb8 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -667,10 +667,8 @@ atmci_of_init(struct platform_device *pdev) } pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); - if (!pdata) { - dev_err(&pdev->dev, "could not allocate memory for pdata\n"); + if (!pdata) return ERR_PTR(-ENOMEM); - } for_each_child_of_node(np, cnp) { if (of_property_read_u32(cnp, "reg", &slot_id)) { -- 2.12.3