From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934963AbcIVQB5 (ORCPT ); Thu, 22 Sep 2016 12:01:57 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:52486 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbcIVQBx (ORCPT ); Thu, 22 Sep 2016 12:01:53 -0400 Subject: Re: [PATCH] drm/tilcdc: mark tilcdc_atomic_check() static To: Baoyou Xie , , References: <1474434876-9293-1-git-send-email-baoyou.xie@linaro.org> CC: , , , From: Jyri Sarha Message-ID: <199cb69f-fab1-d202-5ee8-70665217c66d@ti.com> Date: Thu, 22 Sep 2016 19:01:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474434876-9293-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank, But I already have this too: http://www.spinics.net/lists/kernel/msg2340400.html Best regards, Jyri On 09/21/16 08:14, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: no previous prototype for 'tilcdc_atomic_check' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 4405e4b..1d26bc9 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -61,7 +61,7 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev) > drm_fbdev_cma_hotplug_event(priv->fbdev); > } > > -int tilcdc_atomic_check(struct drm_device *dev, > +static int tilcdc_atomic_check(struct drm_device *dev, > struct drm_atomic_state *state) > { > int ret; >