From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752719AbdKMW0n (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Nov 2017 17:26:43 -0500
Received: from mail-pg0-f51.google.com ([74.125.83.51]:50432 "EHLO
        mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751350AbdKMW0k (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Nov 2017 17:26:40 -0500
X-Google-Smtp-Source: AGs4zMaicgZ+b4KfYjkMRK6dQ+P5Kb/sR9KPKqeqANSkWClUO1Nel+kBVLsP4JmBQ4xzosUoHtAlgA==
Date: Mon, 13 Nov 2017 14:26:36 -0800
User-Agent: K-9 Mail for Android
In-Reply-To: <CABXOdTfc1wWmjrExpGkpx6ccoiKBadVLCdSexBXqNCfG7apd=w@mail.gmail.com>
References: <9629c610-26cf-d64d-8351-b90273b09676@infradead.org> <CABXOdTfJkdWzqptbqkbJqNtxx5+qeW=+4CZFUG9UxJ6QADAsRw@mail.gmail.com> <6634ab5b-b21f-120e-2a29-52c824d5dcff@infradead.org> <20171113190400.hayy4iff5wmjy3qt@dtor-ws> <CABXOdTeBzGMrSquEyhCn1Oh4Fg_AfuoSOgUrtVC+zxLxOxDzmw@mail.gmail.com> <20171113192317.GA27109@kroah.com> <CABXOdTc-4dcuOvfQCUVB-JUcjK-Tc6xi7THAfLJjP1cJQFn8sQ@mail.gmail.com> <20171113220109.ibgsydspaj73l5d5@dtor-ws> <CABXOdTfc1wWmjrExpGkpx6ccoiKBadVLCdSexBXqNCfG7apd=w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Subject: Re: drivers/firmware/google/vpd.c: duplicate sysfs file
To: Guenter Roeck <groeck@google.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Guenter Roeck <groeck@chromium.org>,
        Wei-Ning Huang <wnhuang@google.com>
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Message-ID: <19B9CA48-C5CC-4EFD-AE6B-527D56F33249@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vADMQlY3024398

On November 13, 2017 2:24:23 PM PST, Guenter Roeck <groeck@google.com> wrote:
>On Mon, Nov 13, 2017 at 2:01 PM, Dmitry Torokhov
><dmitry.torokhov@gmail.com> wrote:
>> On Mon, Nov 13, 2017 at 12:14:41PM -0800, Guenter Roeck wrote:
>>> The sysfs warning, yes. However, after unbinding and rebinding the
>>> driver, "cat /sys/firmware/vpd/rw_raw" will result in a crash.
>>>
>>> Sequence:
>>>
>>> echo vpd > /sys/bus/platform/drivers/vpd/unbind
>>> echo vpd > /sys/bus/platform/drivers/vpd/bind # <-- nasty message
>>>
>>> cat /sys/firmware/vpd/rw_raw # <-- crash
>>
>> I'd disable unbind (.suppress_bind_attrs = true) and commented out
>> unload for now. And then looked into fixing properly.
>>
>
>Fixing properly is easy as long as we retain the platform device; I
>already have a set of patches doing just that. I have no idea how to
>implement the non-platform-device variant, if that is what you mean
>with "properly".

Ah, ok then.


Thanks.

-- 
Dmitry